From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D886EC7618D for ; Tue, 21 Mar 2023 07:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mbaMXB4MmsLj+MmC0Tdk2BKlu8IUYiUaE9ZSqU4vb2Q=; b=Su4lcjGoyGI9yi YcS4kfdzMsD8jN3t/s+x2tAKC8lmlpeYi4vH9B4GCYtpMk7J0z7uRyAuN/LA3xrKrAZGdhLQRp6fV tk5a9zbT7q8wDX3QusC5HCKpAFN/GMNEuhjgM6Be6i9CHO3uN62D2AoC3V6i2MRYqEYn6NsnRbp+A 5OEDafh0JvUcn7fQ/+LPnHwGZOoQTpMwaTsBHrva+d+WUUrggBBEmZMPfrsklRjbbMziHca62Jlf0 YDNkr4otOxXI4ZoffcTlagIz3hTgJi7Yn5OEq+SPxGpNcYWFKUmf+NVrSJYjRoUnFHUxEDlN1J+NT Z3y3wt4rQLtmcFsna+5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peWGw-00BVbF-1S; Tue, 21 Mar 2023 07:19:06 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peWGs-00BVZf-21 for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 07:19:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1679383142; x=1710919142; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oK6CV2HFA5Wiy/dDG0auXp4uS+U9M8gs2qElsMCsmaI=; b=LW40P2ZFZBQOph4KLsEBObmwInuyPZ1Y5aB1OdZP564H44EfZT3lkHkt r2F+6fOf6zkTPNM0cJa3TvrdDuIZDZTjj1wmup0CRVAQvnrtOdBhsjMp3 qWStzO/+5iBv30FnERmky2N7kGaR+4LhX0OzhzBfwS0M997ajvH86gu4b PqiFgGa+5P8yqpYh4yA1vjxqTLRh929bIXXqLK6NfgRKb/F7EeKRC/MLM eGN4Fcuk3+1P5ZvKHrK1KaaQuwYd+JXM11PUIOIgpWp7lFIhI0AUFMJUr 1uWJFxUH3gPcCdXNfJJZNH7l3m3jzeTzPDCKbJjL0PmpHniqFCzCld/wN Q==; X-IronPort-AV: E=Sophos;i="5.98,278,1673910000"; d="scan'208";a="29818752" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 21 Mar 2023 08:18:56 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 21 Mar 2023 08:18:56 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 21 Mar 2023 08:18:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1679383136; x=1710919136; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=oK6CV2HFA5Wiy/dDG0auXp4uS+U9M8gs2qElsMCsmaI=; b=N2x5dRrtvdgbqwdiym2PL4n1f4zbxCA/tAdGMz5KB0vOQycj+q5tL7oL Qk++boVynfMHOuSgvA080YWPyBedwEx27ztIEiFzQFrkwmpyr0JHnVua3 zKDk3xMmuJ5JGFFirIWFq9ZOStSB5LjQIIAXoNKx3vHAMAMGbP+E4KU9k lHkDIt8nq/SJ3mslFElf91RV3FqjnY6ahr5HEW+hiIxGious7LAoMVzUr kLALTgxeJ+EkhGwBx8xqQ9mlCuADLMKtpsjcJX8GahDKkpbKf4Tdj+rl2 ouR1NLPAYdzIATMeezRRYMFJ2vJANObeQtHK+4ThhoKQc5NdZJwSxMzA3 g==; X-IronPort-AV: E=Sophos;i="5.98,278,1673910000"; d="scan'208";a="29818751" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 21 Mar 2023 08:18:56 +0100 Received: from steina-w.localnet (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 20689280056; Tue, 21 Mar 2023 08:18:56 +0100 (CET) From: Alexander Stein To: Rui Miguel Silva , Laurent Pinchart Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] media: imx: imx7-media-csi: Fail for non video-capture formats Date: Tue, 21 Mar 2023 08:18:53 +0100 Message-ID: <5926875.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20230317175744.GA28322@pendragon.ideasonboard.com> References: <20230316143829.499039-1-alexander.stein@ew.tq-group.com> <20230317175744.GA28322@pendragon.ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_001903_075761_488462A5 X-CRM114-Status: GOOD ( 25.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi all, Am Freitag, 17. M=E4rz 2023, 18:57:44 CET schrieb Laurent Pinchart: > On Fri, Mar 17, 2023 at 05:23:29PM +0000, Rui Miguel Silva wrote: > > Hi Alexander, > > thanks for the patch. > > = > > Alexander Stein writes: > > > This driver only support V4L2_BUF_TYPE_VIDEO_CAPTURE, so fail for oth= er > > > passed types. > > > = > > > Signed-off-by: Alexander Stein > > > --- > > > = > > > drivers/media/platform/nxp/imx7-media-csi.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > = > > > diff --git a/drivers/media/platform/nxp/imx7-media-csi.c > > > b/drivers/media/platform/nxp/imx7-media-csi.c index > > > 389d7d88b341..e470b0505d3b 100644 > > > --- a/drivers/media/platform/nxp/imx7-media-csi.c > > > +++ b/drivers/media/platform/nxp/imx7-media-csi.c > > > @@ -1186,6 +1186,11 @@ __imx7_csi_video_try_fmt(struct v4l2_pix_format > > > *pixfmt,> > = > > > static int imx7_csi_video_try_fmt_vid_cap(struct file *file, void *f= h, > > > = > > > struct v4l2_format *f) > > > = > > > { > > > = > > > + struct imx7_csi *csi =3D video_drvdata(file); > > = > > Maybe copy/paste problem csi is never used. Yes, leftover from reordering patches. > > > + > > > + if (f->type !=3D V4L2_BUF_TYPE_VIDEO_CAPTURE) > > > + return -EINVAL; > > = > > Is this function ever called if f->type is not TYPE_VIDEO_CAPTURE? > = > It shouldn't, v4l_g_fmt() and v4l_s_fmt() check the type and call the > appropriate operation accordingly. I don't think this patch is needed. You are right. I was mislead by the fact that imx7_csi_video_g_selection do= es = need this check. Best regards, Alexander > > > + > > > = > > > __imx7_csi_video_try_fmt(&f->fmt.pix, NULL); > > > return 0; > > > = > > > } > > > = > > > @@ -1196,6 +1201,9 @@ static int imx7_csi_video_s_fmt_vid_cap(struct > > > file *file, void *fh,> > = > > > struct imx7_csi *csi =3D video_drvdata(file); > > > const struct imx7_csi_pixfmt *cc; > > > = > > > + if (f->type !=3D V4L2_BUF_TYPE_VIDEO_CAPTURE) > > > + return -EINVAL; > > = > > Ditto? > > = > > Cheers, > > = > > Rui > > > = > > > + > > > = > > > if (vb2_is_busy(&csi->q)) { > > > = > > > dev_err(csi->dev, "%s queue busy\n", __func__); > > > return -EBUSY; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel