From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED923C4346E for ; Mon, 21 Sep 2020 18:33:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9483E20888 for ; Mon, 21 Sep 2020 18:33:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GLPS6n5i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9483E20888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ontyQ2T1fGLhKtv/RZlMOmpeUbBmRFqgstU/p+GjlcM=; b=GLPS6n5iMR4peolCwt1Oicn/c LdzTyvHmXVnAl255hCGdfQWK4GkZ3hPYZqClVs0vbWAqQbJihdQr6A4nkbgaMykZNVIr5kQiuIQ/V freOHjyAdrqnqeJQzUir5JHIJKla6SQqlAgLs+cL0PqCWdnk78plyDAO4iuZrPsQEJLhZJp41tHvL YBBXpyZOH/peTCTflgoGUkWpb30b9cv5DkofG/6Amzyha8ZiOLpEgC+SmnAFSy4K2aOf4dJafhTrQ fdhFYRe/ane/jCZzsU/HpYmvr3racDXbSoaTk48KdS09W0iVtIigWuhzWzNNgTw1U9kjQwOzdbL09 BqoUCWbnQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKQbw-00021n-3V; Mon, 21 Sep 2020 18:32:24 +0000 Received: from mailoutvs32.siol.net ([185.57.226.223] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKQbt-00020m-KF for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 18:32:22 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTP id 3AD4E5274C3; Mon, 21 Sep 2020 20:32:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta12.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta12.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XJOz8y8z8RPg; Mon, 21 Sep 2020 20:32:16 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Zimbra) with ESMTPS id D10215274C4; Mon, 21 Sep 2020 20:32:16 +0200 (CEST) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Zimbra) with ESMTPA id F3DBC5274C3; Mon, 21 Sep 2020 20:32:15 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Subject: Re: Re: [PATCH v4 09/22] arm64: dts: allwinner: h6: Add HDMI audio node Date: Mon, 21 Sep 2020 20:37:09 +0200 Message-ID: <59286578.E0qSRroNqr@kista> In-Reply-To: References: <20200921102731.747736-1-peron.clem@gmail.com> <20200921135925.q7mde2cnt5jtzkb5@gilmour.lan> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_143221_788199_4FDC0A4A X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linux-ALSA , Liam Girdwood , linux-kernel , Mark Brown , linux-sunxi , Takashi Iwai , Jaroslav Kysela , Marcus Cooper , Chen-Yu Tsai , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 21. september 2020 ob 19:23:49 CEST je Cl=E9ment P=E9ron = napisal(a): > Hi Maxime, > = > On Mon, 21 Sep 2020 at 15:59, Maxime Ripard wrote: > > > > On Mon, Sep 21, 2020 at 12:27:18PM +0200, Cl=E9ment P=E9ron wrote: > > > From: Jernej Skrabec > > > > > > Add a simple-soundcard to link audio between HDMI and I2S. > > > > > > Signed-off-by: Jernej Skrabec > > > Signed-off-by: Marcus Cooper > > > Signed-off-by: Cl=E9ment P=E9ron > > > --- > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++++++++++++++++++= ++ > > > 1 file changed, 33 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm6= 4/ boot/dts/allwinner/sun50i-h6.dtsi > > > index 28c77d6872f6..a8853ee7885a 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > @@ -67,6 +67,25 @@ de: display-engine { > > > status =3D "disabled"; > > > }; > > > > > > + hdmi_sound: hdmi-sound { > > > + compatible =3D "simple-audio-card"; > > > + simple-audio-card,format =3D "i2s"; > > > + simple-audio-card,name =3D "sun50i-h6-hdmi"; > > > + simple-audio-card,mclk-fs =3D <128>; > > > + simple-audio-card,frame-inversion; > > > + status =3D "disabled"; > > > + > > > + simple-audio-card,codec { > > > + sound-dai =3D <&hdmi>; > > > + }; > > > + > > > + simple-audio-card,cpu { > > > + sound-dai =3D <&i2s1>; > > > + dai-tdm-slot-num =3D <2>; > > > + dai-tdm-slot-width =3D <32>; > > > > It looks weird to have both some TDM setup here, and yet the format in > > i2s? > = > Yes, I agree I will check if it's really needed. I think this was explained before. Anyway, this is needed to force width to = 32, no matter actual sample width. That's a requirement of HDMI codec. I = believe Marcus Cooper have another codec which also needs fixed width. There is no similar property for I2S, so TDM one is used here. Best regards, Jernej > = > Clement > = > > > > Maxime > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel