From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAF73C001B0 for ; Thu, 10 Aug 2023 12:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x7DFY0aVA8t9NaVywm81BH40YbO0hACmsqZHUrzr2Ug=; b=oY11mbAWu/xZjv CXkO19eglsYdZYLm7mLvZoEfopB9/EQAiM0D5TwPkG1pRNjjlIoMf4gY2cdRte8fUumSOyzi9lwKA KnO5t62CkI4NzPmVQJa97cCQ5ntZXr1Q9/K6tWPqdIprNLor8PXaCGoMlMNRr2ZwFiWzG3WNwstuw dW3PKHYWjtsL76kojyo4o6xvF29Wnk5U0WSIr2T8OdoSF0rLkmQ2Lpx6vr7Qigw+fehxcGjuwlH8X UWF/8oR/pbuu8JojeqP15cRBO2vvjoq0gZoWhHo6vdlu3joqUKzhc6Eu1Lh8aIU2UYaAHPttKZBqv se2GmFHp0qyMDdKX9i1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qU5EW-007fWV-1o; Thu, 10 Aug 2023 12:57:44 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qU5ET-007fWA-1E for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 12:57:43 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37ACvTcK049535; Thu, 10 Aug 2023 07:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691672249; bh=SRjRe34ehad5M7YRy/nqD3E5u+nolVOaUEPJlquRXus=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=T33uo7GyZVN3KQ9oPUdDikxNHd9TLkmpRr3i6Hk2A0B6i5oLbAgBsVJat0mcDWvvv L4G3TuwScjbhOtK065v67tGaJo9bybobDDMnrV2yNLHILqM13sBMJ8BkkFrBZE8kP9 uwC6Zhc/CvdQwPjWEHcaG+q1j5o8owVIq7RpOg5U= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37ACvTKT109279 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 10 Aug 2023 07:57:29 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 10 Aug 2023 07:57:29 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 10 Aug 2023 07:57:29 -0500 Received: from [172.24.227.217] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37ACvMRd013085; Thu, 10 Aug 2023 07:57:23 -0500 Message-ID: <593b3505-9c1e-47e6-e856-f299fc257fa8@ti.com> Date: Thu, 10 Aug 2023 18:27:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 1/5] dt-bindings: net: Add ICSS IEP Content-Language: en-US To: Conor Dooley CC: Conor Dooley , MD Danish Anwar , Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , , , , , , , References: <20230809114906.21866-1-danishanwar@ti.com> <20230809114906.21866-2-danishanwar@ti.com> <20230809-cardboard-falsify-6cc9c09d8577@spud> <0b619ec5-9a86-a449-e8db-b12cca115b93@ti.com> <20230810-drippy-draw-8e8a63164e46@wendy> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: <20230810-drippy-draw-8e8a63164e46@wendy> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_055741_519987_C9648191 X-CRM114-Status: GOOD ( 22.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/08/23 6:22 pm, Conor Dooley wrote: > On Thu, Aug 10, 2023 at 03:23:11PM +0530, Md Danish Anwar wrote: >> On 10/08/23 3:07 am, Conor Dooley wrote: >>> On Wed, Aug 09, 2023 at 05:19:02PM +0530, MD Danish Anwar wrote: >>>> Add DT binding documentation for ICSS IEP module. >>>> >>>> Signed-off-by: MD Danish Anwar >>>> --- >>>> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ >>>> 1 file changed, 37 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> new file mode 100644 >>>> index 000000000000..adae240cfd53 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >>>> @@ -0,0 +1,37 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >>> >>> Does the module here refer to the hw component or to the linux kernel >>> module? >>> >> >> The module here refers to the hardware component. > > Sweet, thanks. > >>>> + >>>> +maintainers: >>>> + - Md Danish Anwar >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,am654-icss-iep # for all TI K3 SoCs >>> >>> *sigh* Please at least give me a chance to reply to the conversation on >>> the previous versions of the series before sending more, that's the >>> second time with this series :/ >> >> My bad, I should have waited for your response. I will hold on posting next >> version until your response is received. >> >>> Right now this looks worse to me than what we started with given the >>> comment is even broader. I have not changed my mind re: what I said on >>> the previous version. >>> >> >> OK, so in the previous version [1] your reply was to have specific compatibles >> as bindings with "ti-am654-icss-iep" as a fall back. I will go with this only. >> >> Does the below looks good to you? Here "ti,am642-icss-iep" and >> "ti,j721e-icss-iep" are different compatibles for different SoCs where as >> "ti,am654-icss-iep" is the fall back. Compatible "ti,am654-icss-iep" will go in >> the driver. >> >> properties: >> compatible: >> oneOf: >> - items: >> - enum: >> - ti,am642-icss-iep >> - ti,j721e-icss-iep >> - const: ti,am654-icss-iep >> >> - items: >> - const: ti,am654-icss-iep > > This one doesn't need to be an items list, since there is only one item. > It should be able to just be const:. I much prefer this approach. > > Thanks, > Conor. Sure Conor, I will remove items from the last one and make it just const like below. Please let me know if this is ok. properties: compatible: oneOf: - items: - enum: - ti,am642-icss-iep - ti,j721e-icss-iep - const: ti,am654-icss-iep - const: ti,am654-icss-iep -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel