Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: wuyifan <wuyifan50@huawei.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
	<tony.luck@intel.com>, <Dave.Martin@arm.com>,
	<james.morse@arm.com>, <babu.moger@amd.com>, <shuah@kernel.org>,
	<tan.shaopeng@fujitsu.com>, <fenghuay@nvidia.com>,
	<ben.horgan@arm.com>, <zengheng4@huawei.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kselftest@vger.kernel.org>, <linuxarm@huawei.com>
Cc: <xiaqinxin@huawei.com>, <prime.zeng@hisilicon.com>,
	<wangyushan12@huawei.com>, <xuwei5@huawei.com>,
	<fanghao11@huawei.com>, <wangzhou1@hisilicon.com>
Subject: Re: [PATCH v3 2/3] selftests/resctrl: Replace counter index references with pointers
Date: Fri, 26 Jun 2026 17:41:48 +0800	[thread overview]
Message-ID: <593b5631-01ef-46ef-ba95-8ff8842bae4f@huawei.com> (raw)
In-Reply-To: <77d30d2d-91db-456e-bf41-2cc31165bd2d@intel.com>

Hi Reinette,

Thanks for the review.

On 6/26/2026 6:14 AM, Reinette Chatre wrote:
> On 5/22/26 2:05 AM, Yifan Wu wrote:
>> Replace direct counter number references with pointers to remove the
>> dependency on fixed array indexing and enable the use of different
>> data structures for counter management.
>>
>> Signed-off-by: Yifan Wu<wuyifan50@huawei.com>
>> ---
> Please improve readibility here by moving the above two lines up while ensuring alignment with
> open parenthesis. Specifically:
> 	imc_counter->fd = perf_event_open(&imc_counter->pe, -1, cpu_no, -1,
> 					  PERF_FLAG_FD_CLOEXEC);
> ...
>
> With the style fixups:
> | Reviewed-by: Reinette Chatre<reinette.chatre@intel.com>
>
> Reinette

I will fix that.

Thanks,
Yifan



  reply	other threads:[~2026-06-26  9:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  9:05 [PATCH v3 0/3] selftests/resctrl: Add dynamic linked list management for IMC counters Yifan Wu
2026-05-22  9:05 ` [PATCH v3 1/3] selftests/resctrl: Introduce " Yifan Wu
2026-06-25 22:14   ` Reinette Chatre
2026-05-22  9:05 ` [PATCH v3 2/3] selftests/resctrl: Replace counter index references with pointers Yifan Wu
2026-06-25 22:14   ` Reinette Chatre
2026-06-26  9:41     ` wuyifan [this message]
2026-05-22  9:05 ` [PATCH v3 3/3] selftests/resctrl: Enable dynamic management of IMC counters via linked list Yifan Wu
2026-06-25 22:14   ` Reinette Chatre
2026-06-26  9:43     ` wuyifan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=593b5631-01ef-46ef-ba95-8ff8842bae4f@huawei.com \
    --to=wuyifan50@huawei.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=fanghao11@huawei.com \
    --cc=fenghuay@nvidia.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=prime.zeng@hisilicon.com \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tony.luck@intel.com \
    --cc=wangyushan12@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=xiaqinxin@huawei.com \
    --cc=xuwei5@huawei.com \
    --cc=zengheng4@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox