From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA24AC433EF for ; Wed, 20 Apr 2022 15:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5CTe1VnVIxHlU9eOAE+/xrm4MBLziJ385IgwuQlTIvE=; b=kNkOFRcn/8pcHf pdJutTm4rMaxy/TttqQr2EP2gbkJjqJO5LAhzM2G5RidVLbMW66XDsSj7pIduoR52AnVUsCMuVTxe b/zj780W6Lq1OD92HiMmXvSrFrKApFmeA2w/sh0JH3LMyxxiGJAcga7OogGUCXImOjUkJYuy6Gtz/ llR8hZYsj2c7qIWOBgGkC14SpAmN89v1oGnKssDjwauZ1tIPGrrxuOrLt5qTn2KlpEpEcAos8yRy7 6jJet5WDWIwRCOebNYJl6didp17dgGaHfiJLglgB0R2Dem+f1hwbALdmZ0cv+viBJx3Wmh8AJLIwT i+Wd7+AYByfB0R36hRsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhBsn-009Vuy-6z; Wed, 20 Apr 2022 15:04:41 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhBsk-009Vtj-21; Wed, 20 Apr 2022 15:04:39 +0000 Received: from [185.156.123.69] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhBsd-0006QZ-7U; Wed, 20 Apr 2022 17:04:31 +0200 From: Heiko Stuebner To: linux-gpio@vger.kernel.org, Luca Ceresoli Cc: Luca Ceresoli , Linus Walleij , Jianqun Xu , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] pinctrl: rockchip: fix RK3308 pinmux bits Date: Wed, 20 Apr 2022 17:04:23 +0200 Message-ID: <5942762.lOV4Wx5bFT@phil> In-Reply-To: <20220420142432.248565-1-luca.ceresoli@bootlin.com> References: <20220420142432.248565-1-luca.ceresoli@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_080438_152826_CA90DE94 X-CRM114-Status: GOOD ( 22.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 20. April 2022, 16:24:31 CEST schrieb Luca Ceresoli: > Some of the pinmuxing bits described in rk3308_mux_recalced_data are wrong, > pointing to non-existing registers. > > Fix the entire table. > > Also add a comment in front of each entry with the same string that appears > in the datasheet to make the table easier to compare with the docs. > > This fix has been tested on real hardware for the gpio3b3_sel entry. > > Fixes: 7825aeb7b208 ("pinctrl: rockchip: add rk3308 SoC support") > Signed-off-by: Luca Ceresoli Reviewed-by: Heiko Stuebner Thanks for walking through the datasheet for the fixes :-) > --- > drivers/pinctrl/pinctrl-rockchip.c | 45 ++++++++++++++++++++---------- > 1 file changed, 30 insertions(+), 15 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index a1b598b86aa9..65fa305b5f59 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -457,95 +457,110 @@ static struct rockchip_mux_recalced_data rk3128_mux_recalced_data[] = { > > static struct rockchip_mux_recalced_data rk3308_mux_recalced_data[] = { > { > + /* gpio1b6_sel */ > .num = 1, > .pin = 14, > .reg = 0x28, > .bit = 12, > .mask = 0xf > }, { > + /* gpio1b7_sel */ > .num = 1, > .pin = 15, > .reg = 0x2c, > .bit = 0, > .mask = 0x3 > }, { > + /* gpio1c2_sel */ > .num = 1, > .pin = 18, > .reg = 0x30, > .bit = 4, > .mask = 0xf > }, { > + /* gpio1c3_sel */ > .num = 1, > .pin = 19, > .reg = 0x30, > .bit = 8, > .mask = 0xf > }, { > + /* gpio1c4_sel */ > .num = 1, > .pin = 20, > .reg = 0x30, > .bit = 12, > .mask = 0xf > }, { > + /* gpio1c5_sel */ > .num = 1, > .pin = 21, > .reg = 0x34, > .bit = 0, > .mask = 0xf > }, { > + /* gpio1c6_sel */ > .num = 1, > .pin = 22, > .reg = 0x34, > .bit = 4, > .mask = 0xf > }, { > + /* gpio1c7_sel */ > .num = 1, > .pin = 23, > .reg = 0x34, > .bit = 8, > .mask = 0xf > }, { > + /* gpio3b4_sel */ > .num = 3, > .pin = 12, > .reg = 0x68, > .bit = 8, > .mask = 0xf > }, { > + /* gpio3b5_sel */ > .num = 3, > .pin = 13, > .reg = 0x68, > .bit = 12, > .mask = 0xf > }, { > + /* gpio2a2_sel */ > .num = 2, > .pin = 2, > - .reg = 0x608, > - .bit = 0, > - .mask = 0x7 > + .reg = 0x40, > + .bit = 4, > + .mask = 0x3 > }, { > + /* gpio2a3_sel */ > .num = 2, > .pin = 3, > - .reg = 0x608, > - .bit = 4, > - .mask = 0x7 > + .reg = 0x40, > + .bit = 6, > + .mask = 0x3 > }, { > + /* gpio2c0_sel */ > .num = 2, > .pin = 16, > - .reg = 0x610, > - .bit = 8, > - .mask = 0x7 > + .reg = 0x50, > + .bit = 0, > + .mask = 0x3 > }, { > + /* gpio3b2_sel */ > .num = 3, > .pin = 10, > - .reg = 0x610, > - .bit = 0, > - .mask = 0x7 > + .reg = 0x68, > + .bit = 4, > + .mask = 0x3 > }, { > + /* gpio3b3_sel */ > .num = 3, > .pin = 11, > - .reg = 0x610, > - .bit = 4, > - .mask = 0x7 > + .reg = 0x68, > + .bit = 6, > + .mask = 0x3 > }, > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel