From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8B3BC433EF for ; Tue, 10 May 2022 14:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JE+tKKU3yKbB8Z77RRNNP7nS+ukx6c1/j1kB/RxeKGE=; b=hGX45+xo2Pk++i +LlvwrZi+XM4lYxQDYjdHblU0wJ1LyNH1OXjNvsPR71OZiw7eYHVT4h8pwPiFPm/EcqKPcv9XxFXh Kgk5HJ5RgUrQ58fGbbt5/pD6RYUUwL9OiG2GktvQA/FDUIohJ2RoXsAW5Q+47Z+egWwSwDOT58qsr c31VMLa3Eb0c6THFdDLeFqp26/f1Hd0ovPQOtzTQTefzZMs+e7411e/WiyRbBrpt8G2ifiNfn75qt xov+ytolxI1OanWhWoxcq6ofyfI/oAR/hGmP6xVq5deeKwIweHOMVdeFtqtMLU/pOD9dWjVc94IUw aM0hAEf7I2gIAChMTc0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noRE6-002bi3-BT; Tue, 10 May 2022 14:52:38 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noRE2-002bg6-Lo; Tue, 10 May 2022 14:52:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x1CTARxTCcBRmbOr4xdk6jXfgn0v4S9YKk4prgzATyE=; b=UleV9ZTWCCUELqwT4Zl/Uyh1D8 h/koyeCGeQ+PSs1/86JHD39OsfbdjRYromqJT11p00JgkD4b42U9LBVnjjKZ58nBoQPc2+J+U+kJR uX0yVmQsX/X7GqwdEQ9UZT5Bl7c69a5CH0LsBaf5A8DrLsVJUpLiQpWRlHHxHOxta6Pk=; Received: from p200300daa70ef200fccd1f935f1cf3cd.dip0.t-ipconnect.de ([2003:da:a70e:f200:fccd:1f93:5f1c:f3cd] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1noRDl-0000yY-5w; Tue, 10 May 2022 16:52:17 +0200 Message-ID: <5959946d-1d34-49b9-1abe-9f9299cc194e@nbd.name> Date: Tue, 10 May 2022 16:52:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] net: dsa: tag_mtk: add padding for tx packets Content-Language: en-US To: Vladimir Oltean Cc: Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220510094014.68440-1-nbd@nbd.name> <20220510123724.i2xqepc56z4eouh2@skbuf> From: Felix Fietkau In-Reply-To: <20220510123724.i2xqepc56z4eouh2@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_075235_008670_98F07327 X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10.05.22 14:37, Vladimir Oltean wrote: > On Tue, May 10, 2022 at 11:40:13AM +0200, Felix Fietkau wrote: >> Padding for transmitted packets needs to account for the special tag. >> With not enough padding, garbage bytes are inserted by the switch at the >> end of small packets. > > I don't think padding bytes are guaranteed to be zeroes. Aren't they > discarded? What is the issue? With the broken padding, ARP requests are silently discarded on the receiver side in my test. Adding the padding explicitly fixes the issue. - Felix _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel