From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F118C04FF3 for ; Mon, 24 May 2021 16:30:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E819613CC for ; Mon, 24 May 2021 16:30:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E819613CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D2tt52gTcJuBc8NobKL/V+eJrTDhMtPA+EOsELxUu9U=; b=XvVLshAYOFudNXu89jpzNuSo5 UDt45ZfYdXglIXhwyPb6aXhe0AkvyWDj6Dtw7slM/vSAJvygblnuu3HLzgwrlwyJm13gHjPmCuL5f qaHQuOZM0Ji223RfFnWk1maq/f65B++oEukZoRXe7e6DIpIco8fEN7uLWBixmrwLRGP10SuoVSA3G B4OHTScfRfc4pmGeJDd0hh0u+6ZpiM9swKrZR2jhrqw6Tsao9PIT7w8pD/DLBoIhRj6X80XaKGO/h qg5DhelOMIQsUD5sO/i+IryKN7sT+XJSpmIAMehW6nUcbfRntqadRrWyfQV53HTC+0Vb6oIvr/Ene z8wwwxCrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llDRM-0016l2-7r; Mon, 24 May 2021 16:28:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll9hW-000udT-AD for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 12:28:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621859330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4X7Q6cOoCe0hTVDV5ljv+76y3e0rtVo1k13v34nVV8=; b=e/OEF6XUQL1BMyyq3RLOXGHqP5vBpvTJ16i9B9+1qLFOxNwhVXJdVi+cPww+bbKtlQ84CF 2N6LQRoEgIB3LduFGAOZTqvFZL1ZweDIfdeWJP+p8IGK1JJp8w9huMh60o+R3XBRmI4L72 8QmIXPawKXM3PHMPB4xnLKfrKHyum2I= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-6RrvjCLqPfe5uGb8f0rMGA-1; Mon, 24 May 2021 08:28:48 -0400 X-MC-Unique: 6RrvjCLqPfe5uGb8f0rMGA-1 Received: by mail-ej1-f69.google.com with SMTP id eb10-20020a170907280ab02903d65bd14481so7193859ejc.21 for ; Mon, 24 May 2021 05:28:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P4X7Q6cOoCe0hTVDV5ljv+76y3e0rtVo1k13v34nVV8=; b=bkJZpjelr1WtSLpxR4QEJl53V2haNi+ReOERMqlfSZPEtyvzHOsjHJblL0pKtyBFhQ mo/9pRDD154UQkYR0T5Bcg3JGBOmgNOajx/Dyn1As8mlO3D66KhRBEEjlE7nCRV2tUKl 41ZjM0rphYQkIFjjR8AeRuqOp7j9aCRulLlw+X9OKDQBhosb/VRmzKBJ4xXv7DMdYK6j QjbYN0AO+C0gPrAwp0z+H2y/Irm3fRHGzJNiQ/6qZ6C8fmgh4+Ln/BJfJX072IPUDB2z +TjBZuC1JP+cAVmiIY/0SNlK+WJVtTwSTbOV/zq1O+vRNwg9zaYFppr+brNa9lBayiUe 17dQ== X-Gm-Message-State: AOAM5300roHOO0YqjKOFFXPLbEu/GH9WfrHXZL/omiVaT/Q0JKOaTg2m /1WK/kh1jdUZNtP8TArF9lQJmPLexbhmWMfwJsND+lg7zui6bXO0ERxQPnggHZzsyeOm+KUSr+F RsLZdvxaaAy9+bajmn0GQSgvztE7ZDjGlw8g= X-Received: by 2002:a17:906:6b96:: with SMTP id l22mr22720197ejr.456.1621859327373; Mon, 24 May 2021 05:28:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6VGkaZuxjCsNKEVJMf+xCBpZGuX4FX7erKeA5K1DM9WApJulSm4iVn6lzGshwE6t7/hh/NQ== X-Received: by 2002:a17:906:6b96:: with SMTP id l22mr22720186ejr.456.1621859327222; Mon, 24 May 2021 05:28:47 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id k11sm7899534ejc.94.2021.05.24.05.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 05:28:46 -0700 (PDT) Subject: Re: [PATCH v2 2/7] KVM: X86: Use _BITUL() macro in UAPI headers To: Joe Richey , trivial@kernel.org Cc: Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Andi Kleen , "Chang S. Bae" , Sasha Levin , Peter Xu , Lei Cao , Daniel Lezcano , "Rafael J. Wysocki" , Ulf Hansson , Jean-Philippe Brucker , Zaibo Xu , Kenneth Lee , Jonathan Cameron , Hans Verkuil , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org References: <20210520104343.317119-1-joerichey94@gmail.com> <20210521085849.37676-1-joerichey94@gmail.com> <20210521085849.37676-3-joerichey94@gmail.com> From: Paolo Bonzini Message-ID: <59754ef1-c49d-11a6-30ba-8b938a6bb45d@redhat.com> Date: Mon, 24 May 2021 14:28:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210521085849.37676-3-joerichey94@gmail.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_052854_438081_8E852CA7 X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/05/21 10:58, Joe Richey wrote: > From: Joe Richey > > Replace BIT() in KVM's UPAI header with _BITUL(). BIT() is not defined > in the UAPI headers and its usage may cause userspace build errors. > > Fixes: fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking") > Signed-off-by: Joe Richey > --- > include/uapi/linux/kvm.h | 5 +++-- > tools/include/uapi/linux/kvm.h | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 3fd9a7e9d90c..79d9c44d1ad7 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -8,6 +8,7 @@ > * Note: you must update KVM_API_VERSION if you change this interface. > */ > > +#include > #include > #include > #include > @@ -1879,8 +1880,8 @@ struct kvm_hyperv_eventfd { > * conversion after harvesting an entry. Also, it must not skip any > * dirty bits, so that dirty bits are always harvested in sequence. > */ > -#define KVM_DIRTY_GFN_F_DIRTY BIT(0) > -#define KVM_DIRTY_GFN_F_RESET BIT(1) > +#define KVM_DIRTY_GFN_F_DIRTY _BITUL(0) > +#define KVM_DIRTY_GFN_F_RESET _BITUL(1) > #define KVM_DIRTY_GFN_F_MASK 0x3 > > /* > diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h > index 3fd9a7e9d90c..79d9c44d1ad7 100644 > --- a/tools/include/uapi/linux/kvm.h > +++ b/tools/include/uapi/linux/kvm.h > @@ -8,6 +8,7 @@ > * Note: you must update KVM_API_VERSION if you change this interface. > */ > > +#include > #include > #include > #include > @@ -1879,8 +1880,8 @@ struct kvm_hyperv_eventfd { > * conversion after harvesting an entry. Also, it must not skip any > * dirty bits, so that dirty bits are always harvested in sequence. > */ > -#define KVM_DIRTY_GFN_F_DIRTY BIT(0) > -#define KVM_DIRTY_GFN_F_RESET BIT(1) > +#define KVM_DIRTY_GFN_F_DIRTY _BITUL(0) > +#define KVM_DIRTY_GFN_F_RESET _BITUL(1) > #define KVM_DIRTY_GFN_F_MASK 0x3 > > /* > Queued thi sone, thanks. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel