From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0C4BEB64DA for ; Wed, 19 Jul 2023 08:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d1AdYS9sGxbR2AxHSQe9Mp8IFYcCW7WAI5lGD7N4lmc=; b=2lywss5PuBOKbL D7jeoMhnoCyliWT37iC5P3/ln4rDyRsjLHUwQgzdi8tjv1qaFvAx5eM+51LpP1o99P0vMeQlTFs+w mUIsstMIBZiJndWbO4LJ2Deuqm3+0tda45o73BTA51kQCRx1qnJ0q4AT9xOfLuupHKcL2yLgveF/w ZZBdAhkhivI+GOZtoD5nFGeqcwcyZp5aepIB7iCzBFP0+rtzzhvTYaKQQFJE+tSPkbMkSRJu5Npbh ocZXFqHlR/P1rasKsSUFAn1g1oqbSZ4nOPkTDTIe40QpIWBTptoo75s/iAVy520RcWVoTU3ZaJ1Kb pxxdG+OJjmhKTeqTcdew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM277-006BfX-1e; Wed, 19 Jul 2023 08:00:49 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM275-006Bea-1d for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 08:00:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=MIME-Version:Content-Transfer-Encoding :Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=CkF7ei8V6KcKs7lrNCPbW6lGLHFiTs5XLOglwnOFVVc=; b=jysWMs6t0kHWK9BTFKXGTg3k/a 9ETEcsCUXUtgKQWNERKGzibZXJSAP8sxYw/+8ffnPGlpeF2Uy5Mo25HP+jxgrCLoKk1Z1zNM6eODN nIoVQIAWGK4UpY6Y/pvimxslu962UTDCRuQkLlRcxj+lBEKNaZ5X3ncZ4ZPORcgVfMf1olRFNZMVs vZvHWFFK5sY9jfruxeFJNscpzTSVl3qwH6+NrjIGWRPgeJSA4tFr8IZ95OP7szbdJPmEBR4S1x2gr rExSI6zG7/ftMe2w0xxqOcTA5dcL68No9NKekHJvOdpYg9PeQQmczcDxycwCgmCOYob+0wY3SdXtk ivJoy3QQ==; Received: from szxga02-in.huawei.com ([45.249.212.188]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLgVm-00BKr7-2G for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 08:56:53 +0000 Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R4t7N6L92zVjfM; Tue, 18 Jul 2023 16:54:56 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 18 Jul 2023 16:56:18 +0800 Received: from lhrpeml500005.china.huawei.com ([7.191.163.240]) by lhrpeml500005.china.huawei.com ([7.191.163.240]) with mapi id 15.01.2507.027; Tue, 18 Jul 2023 09:56:16 +0100 From: Shameerali Kolothum Thodi To: Lorenzo Pieralisi , Guanghui Feng CC: "Guohanjun (Hanjun Guo)" , "sudeep.holla@arm.com" , "rafael@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "baolin.wang@linux.alibaba.com" , "alikernel-developer@linux.alibaba.com" , "will@kernel.org" , "catalin.marinas@arm.com" Subject: RE: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Thread-Topic: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Thread-Index: AQHZuKLr8euEVepDckqwBEutSR/J0q+/F3qAgAAhwnA= Date: Tue, 18 Jul 2023 08:56:16 +0000 Message-ID: <597f481b0e5149dabe4821ca618af6b3@huawei.com> References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.227.178] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_095651_562134_ABA9CD35 X-CRM114-Status: GOOD ( 24.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Lorenzo Pieralisi [mailto:lpieralisi@kernel.org] > Sent: 18 July 2023 08:52 > To: Guanghui Feng > Cc: Guohanjun (Hanjun Guo) ; > sudeep.holla@arm.com; rafael@kernel.org; linux-acpi@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > baolin.wang@linux.alibaba.com; alikernel-developer@linux.alibaba.com; > will@kernel.org; catalin.marinas@arm.com; Shameerali Kolothum Thodi > > Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in > iort_node_get_rmr_info() > > [+Catalin, Will, Shameer] > > On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote: > > According to the ARM IORT specifications DEN 0049 issue E, > > the "Number of IDs" field in the ID mapping format reports > > the number of IDs in the mapping range minus one. > > > > In iort_node_get_rmr_info(), we erroneously skip ID mappings > > whose "Number of IDs" equal to 0, resulting in valid mapping > > nodes with a single ID to map being skipped, which is wrong. > > > > Fix iort_node_get_rmr_info() by removing the bogus id_count > > check. > > > > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR > reserved regions") > > Signed-off-by: Guanghui Feng > > --- > > drivers/acpi/arm64/iort.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > > index 3631230..56d8873 100644 > > --- a/drivers/acpi/arm64/iort.c > > +++ b/drivers/acpi/arm64/iort.c > > @@ -1007,9 +1007,6 @@ static void iort_node_get_rmr_info(struct > acpi_iort_node *node, > > for (i = 0; i < node->mapping_count; i++, map++) { > > struct acpi_iort_node *parent; > > > > - if (!map->id_count) > > - continue; > > - > > parent = ACPI_ADD_PTR(struct acpi_iort_node, iort_table, > > map->output_reference); > > if (parent != iommu) > > Shameer, I know this may look like overkill since the hunk we are > removing is buggy but can you please test this patch on platforms > with RMR to make sure we are not triggering regressions by removing > it (by the specs that's what should be done but current firmware > is always something to reckon with) ? Yes, that is a valid fix. Unlikely it will be a problem. Anyway, I have requested Hanjun to help with the testing as I don't have a test setup with me now. Hanjun, please help. Thanks, Shameer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel