From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [resend v2: PATCH 1/2] dt-bindings: Document the hi3660 reset bindings
Date: Fri, 02 Dec 2016 13:32:53 +0100 [thread overview]
Message-ID: <5982682.vMJxVociDa@wuerfel> (raw)
In-Reply-To: <e15e76e2-b32d-a4d0-eb8b-850626a3946a@linaro.org>
On Friday, December 2, 2016 8:21:33 AM CET zhangfei wrote:
> Hi, Arnd
>
> On 2016?12?01? 20:05, Arnd Bergmann wrote:
> > On Thursday, December 1, 2016 8:48:40 AM CET Zhangfei Gao wrote:
> >> + hisi,reset-bits = <0x20 0x8 /* 0: i2c0 */
> >> + 0x20 0x10 /* 1: i2c1 */
> >> + 0x20 0x20 /* 2: i2c2 */
> >> + 0x20 0x8000000>; /* 3: i2c6 */
> >> + };
> >> +
> >> +Specifying reset lines connected to IP modules
> >> +==============================================
> >> +example:
> >> +
> >> + i2c0: i2c at ..... {
> >> + ...
> >> + resets = <&iomcu_rst 0>;
> >> + ...
> >> + };
> > I don't really like this approach, since now the information is
> > in two places. Why not put the data into the reset specifier
> > directly when it is used?
> Any example, still not understand.
> They are consumer and provider.
I mean in the i2c node, have
i2c0: i2c at ..... {
...
resets = <&iomcu_rst 0x20 0x8>;
...
}
> > Also the format seems a little too close to the actual register
> > layout and could be a little more abstract, using bit numbers instead
> > of a bitmask and register numbers instead of offsets.
> We use bit numbers first.
> But in the developing process, we found several bits may be required for
> one driver.
> And they may not be continuous as the bits may already be occupied.
> Directly using offset, we can set several bits together for simple, to
> give more flexibility.
> So after discussion, we directly use offset.
Can you give an example for why this is needed? Is this different
from a device that has multiple reset lines?
Arnd
next prev parent reply other threads:[~2016-12-02 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 0:48 [resend V2:PATCH 0/2] add reset-hi3660 Zhangfei Gao
2016-12-01 0:48 ` [resend v2: PATCH 1/2] dt-bindings: Document the hi3660 reset bindings Zhangfei Gao
2016-12-01 12:05 ` Arnd Bergmann
2016-12-02 0:21 ` zhangfei
2016-12-02 12:32 ` Arnd Bergmann [this message]
2016-12-02 14:10 ` Philipp Zabel
2016-12-02 22:11 ` Arnd Bergmann
2016-12-06 13:40 ` Philipp Zabel
2016-12-05 23:40 ` Rob Herring
2016-12-06 13:40 ` Philipp Zabel
2016-12-06 1:10 ` zhangfei
2016-12-01 0:48 ` [resend V2: PATCH 2/2] reset: hisilicon: add reset-hi3660 Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5982682.vMJxVociDa@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox