From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2482CDB474 for ; Mon, 23 Oct 2023 06:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YMiMtOX5xMBZaTnKxGhSiHm57N7/huCeSotSBkJRfHo=; b=h0LGnOD6m7oQmz YUL9tWjk5U4a6eGE1/Evfn54T9+2lIaVpUiceRPSEkFjzTD6874EYL2gF9FqBxsPxHnz1KmV0AJYR 9Si+33Tqwx6cwS+RNonYf/JLZQ6G87IFhHfa43ZvD5RhgGmgU7AxBzDWSB4vwpjKijskNCTPRbgZ/ j5/Fd/gKoB1EqF7w1VnZYZnrYbG56bzwsnrGpahjg8pRyglHogQifDHz3j5dK46qKTCDkU1jQYLSZ LCr7t0FaauAEv7NMXxQ8AhNy7AvYrA8LTtOl9JQmSqQwiezv5wK7S0/K3hApjdDMq6OkGakAK9fNv NfM6JLSLlmf+Pe3k1AwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1quoPQ-006X3H-1K; Mon, 23 Oct 2023 06:27:28 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1quoPM-006X2j-22 for linux-arm-kernel@lists.infradead.org; Mon, 23 Oct 2023 06:27:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1698042444; x=1729578444; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=B4cdU/iC1dUVeB9k49fZxtcHN1oJA8yJgehxpOxX72I=; b=jiZG7mFRQg6YMk3zWswvEERWVZNbm3qGIE3k4ncPS/8vFIsqv5jcZAjI 3r615H/L2SXgpvlREeVMvdwXsZobQO3gmpKf9ZtI9waExE4/dKpij8eQN TaGjO5RSuhB8rebtmydtWeNTwRrJia+3LgEiAtARJHKv5s3yST7uUat2I j1AA/Q8cDbbFTkwYGipJKYlbCLX+HIUbp+7Walo/uy+wsBzv8+4JbsLhG 1dvuynQkYLnFBBPhJEBUmCMo2tFE9umoqWO7WU/R99k2Z/LfbJRj836ia NbFoAgnQtAfYTd7o4IRZ7ycpLAOGEbcUCzmlIoWtdFHGjZbC+ayTAZy/O A==; X-IronPort-AV: E=Sophos;i="6.03,244,1694728800"; d="scan'208";a="33590173" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 23 Oct 2023 08:27:17 +0200 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id E556728007F; Mon, 23 Oct 2023 08:27:16 +0200 (CEST) From: Alexander Stein To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Ulf Hansson , Marek Vasut , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: soc: imx93-media-blk-ctrl: Add LDB subnode into schema and example Date: Mon, 23 Oct 2023 08:27:20 +0200 Message-ID: <5986192.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231022-helper-dating-a0f65a8f6f72@spud> References: <20231020130019.665853-1-alexander.stein@ew.tq-group.com> <20231020130019.665853-3-alexander.stein@ew.tq-group.com> <20231022-helper-dating-a0f65a8f6f72@spud> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231022_232725_082634_A571139F X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Conor, Am Sonntag, 22. Oktober 2023, 19:39:12 CEST schrieb Conor Dooley: > Yo, > = > On Fri, Oct 20, 2023 at 03:00:15PM +0200, Alexander Stein wrote: > > Document the LDB bridge subnode and add the subnode into the example. > > For the subnode to work, the block control must scan its subnodes and > > bind drivers to them, do not misuse either simple-bus or simple-mfd > > here. > > = > > Signed-off-by: Alexander Stein > > --- > > = > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > = > > diff --git > > a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.ya= ml > > b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.ya= ml > > index b3554e7f9e76..5ba66dfb0e05 100644 > > --- > > a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.ya= ml > > +++ > > b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.ya= ml> = > > @@ -24,6 +24,12 @@ properties: > > reg: > > maxItems: 1 > > = > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 1 > > + > > = > > '#power-domain-cells': > > const: 1 > > = > > @@ -46,9 +52,16 @@ properties: > > - const: csi > > - const: dsi > > = > > + bridge@20: > > + type: object > > + $ref: /schemas/display/bridge/fsl,ldb.yaml# > > + unevaluatedProperties: false > > + > > = > > required: > > - compatible > > - reg > > = > > + - '#address-cells' > > + - '#size-cells' > = > It seems to make little sense to me that these would become required > when the bridge is optional. Is it valid to have one of these > media-blk-ctrls without the ldb subnode? fsl,imx93-media-blk-ctrl privides several power-domains (DSI, CSI, ISI, PXP = and LCDIF), currently unused. This series introduces the usage for LCDIF po= wer = domain. LDB is the LVDS display bridge. So there are several power domains = which don't requires the usage of ldb. On the other hand I prefer consistency, so I opted to keep things similar t= o = commit 1cb0c87d27dc. If it shall not be added here, it should be removed in = Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml as = well. Best regards, Alexander > = > > - power-domains > > - clocks > > - clock-names > > = > > @@ -77,4 +90,35 @@ examples: > > clock-names =3D "apb", "axi", "nic", "disp", "cam", > > = > > "pxp", "lcdif", "isi", "csi", "dsi"; > > = > > #power-domain-cells =3D <1>; > > = > > + #address-cells =3D <1>; > > + #size-cells =3D <1>; > > + > > + bridge@20 { > > + compatible =3D "fsl,imx93-ldb"; > > + reg =3D <0x20 0x4>, <0x24 0x4>; > > + reg-names =3D "ldb", "lvds"; > > + clocks =3D <&clk IMX93_CLK_LVDS_GATE>; > > + clock-names =3D "ldb"; > > + > > + ports { > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + port@0 { > > + reg =3D <0>; > > + > > + ldb_from_lcdif2: endpoint { > > + remote-endpoint =3D <&lcdif2_to_ldb>; > > + }; > > + }; > > + > > + port@1 { > > + reg =3D <1>; > > + > > + ldb_lvds: endpoint { > > + remote-endpoint =3D <&ldb_to_panel>; > > + }; > > + }; > > + }; > > + }; > > = > > }; -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel