From: "Heiko Stübner" <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>,
i@chainsx.cn,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC
Date: Fri, 23 May 2025 12:26:22 +0200 [thread overview]
Message-ID: <5989180.zQ0Gbyo6oJ@diego> (raw)
In-Reply-To: <65f95a57-64cb-4815-8ff2-9021ab7b7ae3@linaro.org>
Am Freitag, 23. Mai 2025, 09:12:08 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 23/05/2025 09:00, Chukun Pan wrote:
> >
> >> +&gmac1 {
> >> + clock_in_out = "output";
> >> + phy-handle = <&rgmii_phy1>;
> >> + phy-mode = "rgmii-id";
> >> + pinctrl-0 = ...
> >> + pinctrl-names = "default";
> >
> > pinctrl-names should be placed before pinctrl-0
>
> That's unusual - not inline with common coding style and with most of
> SoCs. Is this some kind of known rule valid in Rockchip?
nope it isn't any sort of rule :-) .
I _think_ in the past we generally had
pinctrl-names = "defaule", "whatever"
pinctrl-0 =
pinctrl-1 =
but that was more a "looking somewhat nice" thing from before we had the
more generic dts coding style .
So if in doubt nowadays, please follow the general coding style as written
down in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst
Heiko
next prev parent reply other threads:[~2025-05-23 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 7:54 [PATCH v4 0/2] Add support for Firefly Station-M3/ROC-RK3588S-PC Hsun Lai
2025-05-19 7:54 ` [PATCH v4 1/2] dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC Hsun Lai
2025-05-19 10:20 ` Quentin Schulz
2025-05-20 2:12 ` [v3,1/3] dt-bindings: vendor-prefixes: Add SakuraPi prefix Hsun Lai
2025-05-19 7:54 ` [PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC Hsun Lai
2025-05-23 7:00 ` Chukun Pan
2025-05-23 7:12 ` Krzysztof Kozlowski
2025-05-23 10:26 ` Heiko Stübner [this message]
2025-05-19 13:01 ` [PATCH v4 0/2] Add support for Firefly Station-M3/ROC-RK3588S-PC Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5989180.zQ0Gbyo6oJ@diego \
--to=heiko@sntech.de \
--cc=amadeus@jmu.edu.cn \
--cc=devicetree@vger.kernel.org \
--cc=i@chainsx.cn \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox