From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D28A2C5478C for ; Tue, 27 Feb 2024 17:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2SyH+qEFG1kOvy/z8wG7dtiBInpeuAFKO11iALZwneE=; b=UUKbmnSy+bS+KK sOsd3frx3hh+BwtcLhRlm1wHzo48FD0Aw8ogEV3Cxge5TkgCW9h9zO3j5ZfLPy5MubGeghMLsv8MA 9W3i+ixWeEYvbnCVGNTrxQNdvCeOL6ts44kvOg8QUaKq6Ly7EXvCTePJKzy5oegkndUydnSfDQx2X RGnlvo1Hm7JLJUW5JX5oifASwqQcwxJb7UCuj8m5bSuXBWIAv1DBP7R1L53mhz9GqfDWySfjI7m6X jbVYapjA/ySbVxZO+qVlcpQfoCSmmTeITVQ6B9tyEKVgt7I2QROsk8N3RgOHNMZmKJpayOiGJnLnZ tmaMf8ClVv7wtPAEVmOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf1V1-00000006HZD-32GY; Tue, 27 Feb 2024 17:44:15 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf1Uy-00000006HXy-3ivi for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 17:44:14 +0000 Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41RBi2s0029650; Tue, 27 Feb 2024 18:44:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=jTtuR9h+G7uKqcRPnsVn7E2jeHnidr9oglBzqkI2a+U=; b=1y oGKMjeYvQjnK1+hUSuaiK0UBujfXx++pour4YAnDdLL46F0nOa+bV3MvljzLkF75 aKl5JdLHn/hkoxcay9PA/SHFQQVoFG3WEAuNZMk1Qiig2SYkTH2j/8pdI4wT+B+C dzn2eKcpujpqjvteWr9aM2fSJAiaWNkW4jS8v2dnI0gsGIwx5HUDvCV/03VwJlj5 tRAGw4nt8Xj2p/OUFtVc/mbTpsA0kRWxYp7vnZiLIjAL5YFKWf9Q2IxnrrIu87sq 8rsUuq3pzZusu6OwHOHCOOjEKp31ggt4oVM7ACQ0e8cz5bkMpoyZJYujfQ5jjO+W fTyMUduEb5bZnKdsYyWg== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3whf4b9dp9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Feb 2024 18:44:06 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id EED2440045; Tue, 27 Feb 2024 18:44:02 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id A2F4D2ADF49; Tue, 27 Feb 2024 18:43:38 +0100 (CET) Received: from [10.252.26.109] (10.252.26.109) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Feb 2024 18:43:35 +0100 Message-ID: <599a7357-b4d6-4581-9d5c-c1d0ade3e410@foss.st.com> Date: Tue, 27 Feb 2024 18:43:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/10] counter: stm32-timer-cnt: introduce clock signal Content-Language: en-US To: William Breathitt Gray CC: , , , , , References: <20231220145726.640627-1-fabrice.gasnier@foss.st.com> <20231220145726.640627-5-fabrice.gasnier@foss.st.com> From: Fabrice Gasnier In-Reply-To: X-Originating-IP: [10.252.26.109] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-27_05,2024-02-27_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_094413_253429_D7D06F14 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/8/24 17:46, William Breathitt Gray wrote: > On Wed, Dec 20, 2023 at 03:57:20PM +0100, Fabrice Gasnier wrote: >> Introduce the internal clock signal, used to count when in simple rising >> function. Also add the "frequency" extension to the clock signal. >> >> With this patch, signal action reports a consistent state when "increase" >> function is used, and the counting frequency: >> $ echo increase > function >> $ grep -H "" signal*_action >> signal0_action:none >> signal1_action:none >> signal2_action:rising edge >> $ echo 1 > enable >> $ cat count >> 25425 >> $ cat count >> 44439 >> $ cat ../signal2/frequency >> 208877930 >> >> Signed-off-by: Fabrice Gasnier > > Reviewed-by: William Breathitt Gray > > The code is all right, but some minor suggestions below. > >> +static struct counter_comp stm32_count_clock_ext[] = { >> + COUNTER_COMP_SIGNAL_U64("frequency", stm32_count_clk_get_freq, NULL), > > It might be worth introducing a new COUNTER_COMP_FREQUENCY() macro now > that we have a second driver with the 'frequency' extension > (ti-ecap-capture also has 'frequency'). But it's up to you if you want > to add a precursor patch to this series, or I'll introduce it separately > myself in a independent patch. Thanks for suggesting. I added a precursor patch to this series. I guess you wishes to see it used in both ti-ecap-capture and stm32-timer-cnt. I only cared about stm32-timer-cnt in this series. Can I let you do ti-ecap-capture change if/when you're going to apply it? > >> @@ -287,7 +321,13 @@ static struct counter_signal stm32_signals[] = { >> { >> .id = STM32_CH2_SIG, >> .name = "Channel 2" >> - } >> + }, >> + { >> + .id = STM32_CLOCK_SIG, >> + .name = "Clock Signal", > > The word "Signal" feels unnecessary to me when both the sysfs path and > data structure will have 'signal' already. Do you think "Clock" by > itself is clear enough? Agreed, I updated in v4. Best Regards, Fabrice > > William Breathitt Gray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel