From: mathias.nyman@linux.intel.com (Mathias Nyman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3][for 4.14] xhci: allow TRACE to work with EVENT ring dequeue
Date: Tue, 26 Sep 2017 09:44:31 +0300 [thread overview]
Message-ID: <59C9F74F.2030306@linux.intel.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DD007F5A1@AcuExch.aculab.com>
On 25.09.2017 19:09, David Laight wrote:
> From: Adam Wallis
>> Sent: 25 September 2017 13:26
>> inc_deq() currently bails earlier for EVENT rings than the common return
>> point of the function, due to the fact that EVENT rings do not have
>> link TRBs. The unfortunate side effect of this is that the very useful
>> trace_xhci_inc_deq() function is not called/usable for EVENT ring
>> debug.
>
> Is it actually worth using different functions for the different
> ring types?
> From what I remember there are conditionals in a lot of the functions
> but they are fixed for most of the call sites.
>
There's some restructuring and refactoring that could be done in xhci,
but that's not part of this patch.
This will just enable better debugging.
Applying this patch
Thanks
-Mathias
next prev parent reply other threads:[~2017-09-26 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:26 [PATCH v3][for 4.14] xhci: allow TRACE to work with EVENT ring dequeue Adam Wallis
2017-09-25 16:09 ` David Laight
2017-09-25 17:03 ` Adam Wallis
2017-09-26 6:44 ` Mathias Nyman [this message]
2017-10-04 16:07 ` Adam Wallis
2017-10-05 9:52 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59C9F74F.2030306@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).