From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm: vdso: Rewrite gettimeofday to more closely match arm64 variant
Date: Wed, 11 Oct 2017 16:34:45 +0100 [thread overview]
Message-ID: <59DE3A15.90800@arm.com> (raw)
In-Reply-To: <20170911161827.112786-1-salyzyn@android.com>
Hi Mark,
On 11/09/17 17:18, Mark Salyzyn wrote:
> Take an effort to recode the arm64 vdso code from assembler to C
> previously submitted by Andrew Pinski <apinski@cavium.com>, rework
> it for use in both arm and arm64, overlapping any optimizations
> for each architecture.
>
> Side effects include renaming some vdso_datapage.h variables, adding
> a few more to enhance features and functionality to match.
There are quite a lot of different things going on here, all of which are
interleaved in this patch. Could you split them out into smaller simpler changes?
The bits I count are:
* Pulling 32bit specific eabi and fallback macro out into compiler.h,
* Adding support for __vdso_clock_getres,
* Flipping tk_is_cntvct's logic to become use_syscall,
* Variable renames to align 32/64 bit,
...are those 'coarse' versions of the timer calls being added, or just moved around?
Thanks,
James
prev parent reply other threads:[~2017-10-11 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 16:18 [PATCH 1/3] arm: vdso: Rewrite gettimeofday to more closely match arm64 variant Mark Salyzyn
2017-10-11 15:34 ` James Morse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59DE3A15.90800@arm.com \
--to=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).