[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[Thomas Rohloff]

Devices like DCF77 receivers need the baud-rate to be as low as 50.

I have tested this on a Meson GXL device with uart_A.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Signed-off-by: Thomas Rohloff <v10lator@myway.de>
---
 drivers/tty/serial/meson_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/meson_uart.c 
b/drivers/tty/serial/meson_uart.c
index 07c0f98be3ac..e281ce5d101d 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -362,7 +362,7 @@ static void meson_uart_set_termios(struct uart_port 
*port,
 
 	writel(val, port->membase + AML_UART_CONTROL);
 
-	baud = uart_get_baud_rate(port, termios, old, 9600, 4000000);
+	baud = uart_get_baud_rate(port, termios, old, 50, 4000000);
 	meson_uart_change_speed(port, baud);
 
 	port->read_status_mask = AML_UART_TX_FIFO_WERR;
-- 
2.13.6

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[V10lator]

Devices like DCF77 receivers need the baud-rate to be as low as 50.

I have tested this on a Meson GXL device with uart_A.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Signed-off-by: Thomas Rohloff <v10lator@myway.de>
---
 drivers/tty/serial/meson_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/meson_uart.c 
b/drivers/tty/serial/meson_uart.c
index 07c0f98be3ac..e281ce5d101d 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -362,7 +362,7 @@ static void meson_uart_set_termios(struct uart_port 
*port,
 
 	writel(val, port->membase + AML_UART_CONTROL);
 
-	baud = uart_get_baud_rate(port, termios, old, 9600, 4000000);
+	baud = uart_get_baud_rate(port, termios, old, 50, 4000000);
 	meson_uart_change_speed(port, baud);
 
 	port->read_status_mask = AML_UART_TX_FIFO_WERR;
-- 
2.13.6

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[Greg Kroah-Hartman]

On Sat, Nov 04, 2017 at 02:00:00PM +0100, V10lator wrote:
> Devices like DCF77 receivers need the baud-rate to be as low as 50.
> 
> I have tested this on a Meson GXL device with uart_A.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Carlo Caione <carlo@caione.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic at lists.infradead.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Thomas Rohloff <v10lator@myway.de>
> ---
> drivers/tty/serial/meson_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

What changed from v2?

And I need a real name as the author of the patch :(

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[Neil Armstrong]

Le 04/11/2017 14:13, Greg Kroah-Hartman a ?crit :
> On Sat, Nov 04, 2017 at 02:00:00PM +0100, V10lator wrote:
>> Devices like DCF77 receivers need the baud-rate to be as low as 50.
>>
>> I have tested this on a Meson GXL device with uart_A.
>>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Jiri Slaby <jslaby@suse.com>
>> Cc: Carlo Caione <carlo@caione.org>
>> Cc: Kevin Hilman <khilman@baylibre.com>
>> Cc: linux-amlogic at lists.infradead.org
>> Cc: linux-arm-kernel at lists.infradead.org
>> Cc: linux-kernel at vger.kernel.org
>> Signed-off-by: Thomas Rohloff <v10lator@myway.de>
>> ---
>> drivers/tty/serial/meson_uart.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> What changed from v2?
> 
> And I need a real name as the author of the patch :(
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 

Hi Thomas,

Make sure the "From" header of your mail matches the Signed-off-by tag, overwise use the --from option with "git send-email" to be sure, or generate the patch with the "git format-patch" with the "--from" option.

Anyway :
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[V10lator]

Am Samstag, 4. November 2017 14:13:52 CET schrieb Greg Kroah-Hartman:
> What changed from v2?

Nothing. I just re-based the patch on a fresh git clone as you couldn't 
merge v2.

> And I need a real name as the author of the patch :(

Damn, sorry about that. Will do a v4.

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[Greg Kroah-Hartman]

On Sun, Nov 05, 2017 at 05:26:59AM +0100, V10lator wrote:
> Am Samstag, 4. November 2017 14:13:52 CET schrieb Greg Kroah-Hartman:
> > What changed from v2?
> 
> Nothing. I just re-based the patch on a fresh git clone as you couldn't
> merge v2.

Then you need to say so somewhere otherwise I, and everyone else, has no
idea what changed.

Remember, I get thousands of patches a week to review, and have the
short-term memory of a squirrel :(

thanks,

greg k-h

[PATCH v3] tty: serial: meson: allow baud-rates lower than 9600

[Greg Kroah-Hartman]

On Sat, Nov 04, 2017 at 01:36:07PM +0100, Thomas Rohloff wrote:
> Devices like DCF77 receivers need the baud-rate to be as low as 50.
> 
> I have tested this on a Meson GXL device with uart_A.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Carlo Caione <carlo@caione.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic at lists.infradead.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Thomas Rohloff <v10lator@myway.de>
> ---
> drivers/tty/serial/meson_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/meson_uart.c
> b/drivers/tty/serial/meson_uart.c
> index 07c0f98be3ac..e281ce5d101d 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -362,7 +362,7 @@ static void meson_uart_set_termios(struct uart_port
> *port,
> 
> 	writel(val, port->membase + AML_UART_CONTROL);
> 
> -	baud = uart_get_baud_rate(port, termios, old, 9600, 4000000);
> +	baud = uart_get_baud_rate(port, termios, old, 50, 4000000);
> 	meson_uart_change_speed(port, baud);
> 
> 	port->read_status_mask = AML_UART_TX_FIFO_WERR;

This patch is corrupted (line-wrapped), and can not be applied.  Please
fix up and resend.

thanks,

greg k-h