public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Gabor Juhos <j4g8y7@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' from USB host nodes
Date: Thu, 19 Mar 2026 09:23:07 +0100	[thread overview]
Message-ID: <59ae3126-1074-4ff3-9474-9419f1042bb9@gmail.com> (raw)
In-Reply-To: <87o6klcswc.fsf@bootlin.com>

Hi Miquel,

2026. 03. 18. 11:51 keltezéssel, Miquel Raynal írta:

...

>>> When the nodes of the UTMI PHYs has been added to the SoC dtsi by
>>> commit 05d168a56fae ("arm64: dts: marvell: armada-37xx: declare USB2
>>> UTMI PHYs"), the properties has been added to the USB host controller
>>> nodes also. According to the commit message this was intentional,
>>
>> Miquel will confirm that, after speaking with him, it appears to be a
>> mistake rather than an intentional act.
> 
> Indeed, I believe it is a leftover, the property should have been added
> only to the PHY nodes, not the host nodes.
> 
> The sentence above should be: s/intentional/unintentional/, the commit
> messages clearly states that PHY nodes were targeted, not the
> host. Plus, a follow-up commit adds the missing phy properties to the
> hosts, so clearly reaching this syscon through the host node directly
> does not make sense and was not intended.

Sorry, I assumed that it was intentional because the commit message explicitly
mentioned the USB host node.

> Once this single word fixed, you can add my

Will fix it, and send a new version.

> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thank you for the review!

Regards,
Gabor


      reply	other threads:[~2026-03-19  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 12:33 [PATCH v2] arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' from USB host nodes Gabor Juhos
2026-03-18 10:40 ` Gregory CLEMENT
2026-03-18 10:51   ` Miquel Raynal
2026-03-19  8:23     ` Gabor Juhos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59ae3126-1074-4ff3-9474-9419f1042bb9@gmail.com \
    --to=j4g8y7@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=robh@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox