From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F27C8C433EF for ; Tue, 1 Mar 2022 08:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ggAhBZf3r8eHcCVPALm8SEHMywWhjmJvZ51EZdRdhLA=; b=GvmvP0wGuVm86p NkzPyhXs6NmQvFbutcWkni+tXgbF/9ZXpVlkhx5bpG0JGfZWX/cIBxyJvgHkkWc9Hina0oFKGy8tO DozD49oMmf/CxENZUfQeGbDokQgTRiGY848OkkDeKyz39W1Jg7OaWOLs0Zn99R9kcA0NxqYk9eseL AdApjAYXMdc/gTmDlqCkYms3rsKAjnCYfF7Q6CkovKHac1hqFNfAVmuWqpb3uz0wn7CADY0gx7v/Q zUNanmfx5+x6TWe7JxD+V0FarZr87eKGbvVYFFmixrVI5+PRB4zcApNeXuA3AJ3EsnaYTnBhHICMx lXodz28oJur4zt3E5TIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOy5C-00FedO-E8; Tue, 01 Mar 2022 08:42:10 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOy57-00FeZv-TC for linux-arm-kernel@lists.infradead.org; Tue, 01 Mar 2022 08:42:07 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id D02A13F19A for ; Tue, 1 Mar 2022 08:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646124119; bh=dZm4dVdpcvNRhKnzE3iapZ6aqr4LkpURHZ0F0cP2Ffk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WNozuzhh51MkPB6e5T6zDNZ9rtSg3VDRJWH1IDwZSfpJJa3XmxTsuEmO5tG+IrS9x sENmzqV0KRI+6VpVte7znN/e6JiOzWz/Ks05zoUusuYUk8lTVyfJ5DWP6AsPSMfX5K E04N9kSL9W50Y50K2H9Txk52qlMh20NMXd7vjuVfNOH0ohrD+UckfyarzdSIPJK+2N qqFl+dL87t/4REdj419Fhfn3RyK1OG4nT+5YxRXcSrStFV+KB1/8ra3R3aMeFSKKTl YJSrqr9uWK39ooxO7RjeY9lWE5+6KYf4kwswy0k+TQdYiM/qC3T1XIOSR++hi4xCHJ yjHyNwqXa9PFA== Received: by mail-ed1-f71.google.com with SMTP id l14-20020aa7cace000000b003f7f8e1cbbdso7381985edt.20 for ; Tue, 01 Mar 2022 00:41:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dZm4dVdpcvNRhKnzE3iapZ6aqr4LkpURHZ0F0cP2Ffk=; b=hrvJC5KilGVK28SfmT2WhSQofgXOEe6yjYehrRxIjn5Q5tdmFiyps6F10ujqs+Vxxm uL2bjBjdXMOq116IlcduQMwtvqzytgnCcy5xdZ5MPjQPopiWmIiUvrzR72Z7AmHcHFdB xWVZgDgVu5D7Kpqi9MSupgbkOfe5+l9l95nRmhouaGhBCnrvPR3znTfxyOLdjyWbPaSK FBabHA1xrnUAUQdAyW/HhaYpkA4vdk1Zw/WnJu82chlUkQcDV5ybzVuDyH1efpXn/4Fz BFgCCJfx8R8Tvg1TXYjYqtETPWrDwBwqgMrBPn6em2qUDrMOuoSnoJ2BlnGdEdL3j/EK qmnA== X-Gm-Message-State: AOAM532f2PUO72jtii9D2ktWnzMOhq7ds5GVZmGLqLdNQcHB//YE9Kcg azWb2jIsKvbbLrnQVH2+alT7Zl2BIASvl/HVAWnhzXDQcmRDWnDRUyXtM389hGkw8+nlyc5LAia FNz0SoxdAr4G2ywOTQjmK5BJmQWrJclGUN4bU5CaIu9tdKW9ELrpi X-Received: by 2002:a17:907:248a:b0:69b:ba2d:62cd with SMTP id zg10-20020a170907248a00b0069bba2d62cdmr18284930ejb.212.1646124119343; Tue, 01 Mar 2022 00:41:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkLsXZPJFLzXPV5FGYgxl+qkbahIyWcZp4Gh4Ixdg/+bf55XzGLZMALWtwePubTl5fD9ILsg== X-Received: by 2002:a17:907:248a:b0:69b:ba2d:62cd with SMTP id zg10-20020a170907248a00b0069bba2d62cdmr18284886ejb.212.1646124119100; Tue, 01 Mar 2022 00:41:59 -0800 (PST) Received: from [192.168.0.135] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id bo14-20020a170906d04e00b006ce98d9c3e3sm5116757ejb.194.2022.03.01.00.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Mar 2022 00:41:58 -0800 (PST) Message-ID: <59ba1fd5-4be5-278f-47df-d26c341da73a@canonical.com> Date: Tue, 1 Mar 2022 09:41:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 05/11] PCI: Use driver_set_override() instead of open-coding Content-Language: en-US To: Bjorn Helgaas Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes References: <20220228200606.GA516338@bhelgaas> From: Krzysztof Kozlowski In-Reply-To: <20220228200606.GA516338@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_004206_085606_4A96F7E7 X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/02/2022 21:06, Bjorn Helgaas wrote: > On Sun, Feb 27, 2022 at 02:52:08PM +0100, Krzysztof Kozlowski wrote: >> Use a helper for seting driver_override to reduce amount of duplicated >> code. Make the driver_override field const char, because it is not >> modified by the core and it matches other subsystems. > > s/seting/setting/ > or even better, s/for seting/to set/ > >> Signed-off-by: Krzysztof Kozlowski > > Acked-by: Bjorn Helgaas > >> - char *driver_override; /* Driver name to force a match */ >> + /* >> + * Driver name to force a match. >> + * Do not set directly, because core frees it. >> + * Use driver_set_override() to set or clear it. > > Wrap this comment to fill 78 columns or so. Thanks, I'll fix both. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel