From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1072CC4363D for ; Fri, 25 Sep 2020 11:46:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 950F32083B for ; Fri, 25 Sep 2020 11:46:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gic38/Fb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 950F32083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KMdc/JW6RP2v4EZ7xAwrYvcjPQNdx2YnZ7UUA8WANNE=; b=gic38/Fbh3FyupXqKeIpeCx07 1rL43BHoSJnbJ73dRNxDtQHk63IM1ceA1y8CTRILu50ycSuI/L0xf4qNXnEnvRSD6YV1oABCEToIY uSKquzoLts/jpXI8BbQtE9jBAP4l8E4KmYY0DARfWvUI8knZpWDptSObfkS6siq5iuirR1vVPekoB Eo4aoQG/6aBAsM2ZySetCi6jyLNw8ovvDj35QzpB2ugDxxzAOzQWm7/ugz97+rFqaLMZxolq3YZYT lEkgAoohYdGeCFI/EBC+r7TbHh0VeIIBCJF8kXMv1DJSAibNAEs3I45wVfOVTC6XV6ychOaCBkx0Z 4AZkk7jqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLm9T-0000Af-9t; Fri, 25 Sep 2020 11:44:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLm9Q-00009e-SS for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 11:44:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9EAB101E; Fri, 25 Sep 2020 04:44:31 -0700 (PDT) Received: from [10.37.12.53] (unknown [10.37.12.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 93BBE3F70D; Fri, 25 Sep 2020 04:44:28 -0700 (PDT) Subject: Re: [PATCH v3 30/39] arm64: kasan: Enable TBI EL1 To: Catalin Marinas , Andrey Konovalov References: <733e94d7368b54473b242bb6a38e421cf459c9ad.1600987622.git.andreyknvl@google.com> <20200925113748.GG4846@gaia> From: Vincenzo Frascino Message-ID: <59c25256-374e-9a13-8098-1543b1768248@arm.com> Date: Fri, 25 Sep 2020 12:47:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925113748.GG4846@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_074432_963253_22B005EA X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrew Morton , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/25/20 12:37 PM, Catalin Marinas wrote: > On Fri, Sep 25, 2020 at 12:50:37AM +0200, Andrey Konovalov wrote: >> diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S >> index 12ba98bc3b3f..dce06e553c7c 100644 >> --- a/arch/arm64/mm/proc.S >> +++ b/arch/arm64/mm/proc.S >> @@ -40,9 +40,13 @@ >> #define TCR_CACHE_FLAGS TCR_IRGN_WBWA | TCR_ORGN_WBWA >> >> #ifdef CONFIG_KASAN_SW_TAGS >> -#define TCR_KASAN_FLAGS TCR_TBI1 >> +#define TCR_KASAN_SW_FLAGS TCR_TBI1 >> #else >> -#define TCR_KASAN_FLAGS 0 >> +#define TCR_KASAN_SW_FLAGS 0 >> +#endif >> + >> +#ifdef CONFIG_KASAN_HW_TAGS >> +#define TCR_KASAN_HW_FLAGS TCR_TBI1 >> #endif >> >> /* >> @@ -454,6 +458,9 @@ SYM_FUNC_START(__cpu_setup) >> >> /* set the TCR_EL1 bits */ >> orr mte_tcr, mte_tcr, #SYS_TCR_EL1_TCMA1 >> +#ifdef CONFIG_KASAN_HW_TAGS >> + orr mte_tcr, mte_tcr, #TCR_KASAN_HW_FLAGS >> +#endif > > I missed this in an earlier patch. Do we need TCMA1 set without > KASAN_HW? If not, we could add them both to TCR_KASAN_HW_FLAGS. > We don't. I will move the code around in the next version. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel