From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E7F5EB8FA5 for ; Wed, 6 Sep 2023 09:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vxsEBR4wChE6v4vrC/V38ubkx2GB8JpW/PwRfFjMr40=; b=alatY/9wPTeBMN woI0XPSXQ+bBwKd4X260hWoLYlm3XqB8RIBSZmJ6nvFOYL6Qvz6eeiJObpiFH0kfm5SnJDKmORehk yKgMLQqftFxZDFKOMPI9jnzORDrJ8SbLdF/RTBXLdgVL0I3EDgN9KrR2XgPr70JMpR2JxmMz4T0t6 E1frKQwayTq918MlA03FFWRJXew1O9thGd+W3qilg8cgQCGXLLW4G0xF4omkh7zRfZ2AW4tuK8xS0 GlPeskKrWfLQpI+JJCi7lFhfARjBPBLIYbThWp5X6hDp2PcDq1TwvkN9wNhaMzdvwewlz5StXLNAO BodbCPJGcZ6B3O5VFEnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdojH-007tWR-1u; Wed, 06 Sep 2023 09:21:43 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdojD-007tTa-37 for linux-arm-kernel@lists.infradead.org; Wed, 06 Sep 2023 09:21:41 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-98377c5d53eso493392966b.0 for ; Wed, 06 Sep 2023 02:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693992093; x=1694596893; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mosQA1Z8AMW4TgZ1FXhqGU5ILwvCqddYrUv5k/pOamA=; b=BKxb4VdZAiOatmWR4ylA7Qcu72BSa5xYaXYUUeDHQxt7caI180+JFb47dEGBRghZGD ClodAMn9rpYjVjab8nW6aQHsECYRYTOZjyGHlAKqysgWmnnlQnBkgPH6dCOgpmm8I6Ed 3X74xfX5hkvPTGfLs6jzRMq1Nbv0D6KDJgp9t+jogTYzA9crJ8NAh+Rc/dNuLg48nvFl xHJl7Wed0loeVDO21Iye2mfqQfB+ZTClgkdC6f4RoUmIHN5ot6QhbAfGk3O7V4KNy7za fr4leZsfpeThKtb6B9VfxyVvPsj9xfJo7FxS8Eir9S59th7ZGB0EtN9VLbJtrozVb6ht iv1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693992093; x=1694596893; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mosQA1Z8AMW4TgZ1FXhqGU5ILwvCqddYrUv5k/pOamA=; b=bjdnkFNCE3qBJdZUmKQYAGEZJhCSIgmXmDEcNE8Yjmnmo0KPOaM2GTbIIcwA9b5t50 83U8AIgx/ZnywpjeR6MG3nob4cti7M98BD7qbeR+CW0VoHETJTR1FMd7fkVVDXU0PpBg NLi5bVYyEFoCMKSbuYgNq/hUwXtjry4oEp8BsG9beY/rGcNlGgZ7s2uTF3JJoIyX9Oti ouKd/3YSxSzuBp+dqtx1GHH0vuazpaIbrxZpGi/7hbeRxnuqXYp4k0KrYNDdsqmfSqEz tRj8TXqsCidUGnETSMKFBgbQOJZEu8+kEGq9jKf+ftvH550dha+tOfHU9aetZxT3XIBu HXCg== X-Gm-Message-State: AOJu0Yx9bs/lXVCQp+LUpdMm/mrpUJkIVctZuO5eCcGRmTKXWTTWYA/k xoz5b0KDG6OhVbl4XyiLbveRFg== X-Google-Smtp-Source: AGHT+IEqN8yumUMQ6iPTk72w0/+TSYnLcyYvOBAXXX38lgfTKbtqWsQSEHcxbrabVrpvOooKpQNTig== X-Received: by 2002:a17:906:846a:b0:99c:fb44:d4a9 with SMTP id hx10-20020a170906846a00b0099cfb44d4a9mr1493075ejc.77.1693992093387; Wed, 06 Sep 2023 02:21:33 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id z7-20020a1709060ac700b0098d2d219649sm8882459ejf.174.2023.09.06.02.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 02:21:32 -0700 (PDT) Message-ID: <59e07c6a-6f1b-0cc7-dddc-96d2a4050843@linaro.org> Date: Wed, 6 Sep 2023 11:21:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/3] arm64: dts: mediatek: mt8365-pumpkin: Add overlays for thp7312 cameras Content-Language: en-US To: Laurent Pinchart Cc: Paul Elder , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230905233118.183140-1-paul.elder@ideasonboard.com> <20230905233118.183140-4-paul.elder@ideasonboard.com> <502fc7b1-a32d-6901-3a45-d2aa0e0c3849@linaro.org> <20230906083237.GL7971@pendragon.ideasonboard.com> <20230906090058.GB17308@pendragon.ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: <20230906090058.GB17308@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230906_022140_012831_77478F64 X-CRM114-Status: GOOD ( 29.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/09/2023 11:00, Laurent Pinchart wrote: >>> has a regulator@0. There are similar instances for clocks. >>> >>> I understand why it may not be a good idea, and how the root node is >>> indeed not a bus. In some cases, those regulators and clocks are grouped >>> in a regulators or clocks node that has a "simple-bus" compatible. I'm >>> not sure if that's a good idea, but at least it should validate. >>> >>> What's the best practice for discrete board-level clocks and regulators >>> in overlays ? How do we ensure that their node name will not conflict >>> with the board to which the overlay is attached ? >> >> Top-level nodes (so under /) do not have unit addresses. If they have - >> it's an error, because it is not a bus. Also, unit address requires reg. >> No reg? No unit address. DTC reports this as warnings as well. > > I agree with all that, but what's the recommended practice to add > top-level clocks and regulators in overlays, in a way that avoids > namespace clashes with the base board ? Whether you use regulator@0 or regulator-0, you have the same chances of clash. > >>>>> + orientation = <0>; >>>>> + rotation = <0>; >>>>> + >>>>> + thine,rx,data-lanes = <4 1 3 2>; >>>> >>>> NAK for this property. >>> >>> Please explain why. You commented very briefly in the bindings review, >>> and it wasn't clear to me if you were happy or not with the property, >>> and if not, why. >> >> Because it is duplicating endpoint. At least from the description. > > The THP7312 is an external ISP. At the hardware level, it has an input > side, with a CSI-2 receiver and an I2C master controller, and an output > side, with a CSI-2 transmitter and an I2C slave controller. A raw camera > sensor is connected on the input side, transmitting image data to the > THP7312, and being controlled over I2C by the firmware running on the > THP7312. From a Linux point of view, only the output side of the THP7312 > is visible, and the combination of the raw camera sensor and the THP7312 > acts as a smart camera sensor, producing YUV images. None of this was explained in the device description or property field. I probably judged to fast but it just looked like duplicated property. Then shouldn't it have two ports, even if camera side is not visible for the Linux? > > As there are two CSI-2 buses, the data lanes configuration needs to be > specified for both sides. On the output side, connected to the SoC and > visible to Linux, the bindings use a port node with an endpoint and the > standard data-lanes property. On the input side, which is invisible to > Linux, the bindings use the vendor-specific thine,rx,data-lanes > property. Its semantics is identical to the standard data-lanes > property, but it's not located in an endpoint as there's no port for the > input side. And how does the property support multiple sensors? What if they data lanes are also different between each other? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel