From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA3C1C531DC for ; Fri, 23 Aug 2024 08:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fG9KNjBoDmO8zW0C42AiccF/rKtpUpUCjugH/PuwWu0=; b=ao28eZJvOc44epTLuEGNf5XuaT ep1cH4BzGxwD6KOOy4prjh/pQRGy4eXn8z6GDUaeEsRScOBGvauskpiw/ZPwtlQNVpjDnIVnF7jJO YQyv+4EPFldyj9qR7izfggKuXbweZYlIlC7mb+EaBhDGkEJiEUQKczrNhzy/lyc1ibMcY6WEC0SZm YaxDM6qsuiI4rH24CqyLUbMSeBriznscBWKty6ux/wmgVqY1mflFTZ1f8T7ttOW/S4v1crVe4o6qt TviZX/zEAg+nybtJRNaa2C4vU0jzwQRQkGK3XPg6aaVylmKOCeGnakwTy6d568nHAbSZUn+i9Fv3F 8gp5MBcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shPv9-0000000FwXp-2h8G; Fri, 23 Aug 2024 08:45:23 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shPqc-0000000FvE0-3Osx for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2024 08:40:45 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5a10835487fso2821967a12.1 for ; Fri, 23 Aug 2024 01:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724402441; x=1725007241; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fG9KNjBoDmO8zW0C42AiccF/rKtpUpUCjugH/PuwWu0=; b=WLTj1KGInCwc8tyt2969LkqhAJJpr68TBAegnd3OMVfsxLOVYVvFP8a8kPsBS3ne9T 9Y1rW/TakPE8OR3JiERBWOKL1eFsonc3e6kVqeDhhfmNSfpcsKzo8qYxTyBlmzSBe469 taR7xEy04n7qQomVOapUbytiZr8D/72kb18+5r6M4DlNpyKNqOSs6wfMg4qzLy1CfJQU yBOx+h4xrdkhDZz4sWMXnzx9Wkoc8VjJlz0x98Wl19BZLzbRuVdrX72RThDXnYWJ+Y0d S5LXfjSHzLhisA3yfwDd+IeF6m+KM99eY+PtbFa+UOAvoDwc5UWPsOJ/UTbAsosYWwW9 zMQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724402441; x=1725007241; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fG9KNjBoDmO8zW0C42AiccF/rKtpUpUCjugH/PuwWu0=; b=rbnAwxxnOgRflI9sMnh0b3fabBc9QjPZjiDLk6NOH+FBeuuPPLZpvHOchW21OKcQqC yAmkbmrfzs2grYwEOeeCNHZloz6vckMe9NqubdFbUeFBuEpccam4mZZ4dWq9BgFdr+3A FDIQPQvrxBWEailEc8cJwP6I8jwkhOxum2G2tR+U0/Og0PsgIm3uzHdMK+QKXCuW72uL /FKPemN2/0lPyM3IujuJ2TePICGgEJ+3kwXVAyIlDsptWgN5e7zfu4N8c7OWmjeNBFl7 TiidcmGW68F6ds3YR+Ms/ezltp3VPGaadsxdPGdtZwn2hi+UAMH3uAU2QuH5++DgcnYA byLw== X-Forwarded-Encrypted: i=1; AJvYcCVW+8PuP+Kw0UzpZk0DyKvpwQ140HZBNZsRKeN58dQN2sWmw3Pc8Wkuu8sQdElQhpWQ5pXPGaaNOK2oOsA+T7Tb@lists.infradead.org X-Gm-Message-State: AOJu0YzuF+BFR2AYP9W4HM6kX/VjZHLSYnIP4uc8XtCIJbZMqPi/+mQ6 DHinOGftrlzvJKYyxULOQHs9V94k2q8Elqk0Bjlyx+yfnU9V+FtnrapXvbZG+ng= X-Google-Smtp-Source: AGHT+IELJdt9NWz1Qyq2a+tw+U6RVfRhf7Xtr1odkIop07urXH/CbabXuHZJspnO7+6yMIrduwa9BA== X-Received: by 2002:a17:906:da82:b0:a77:dc70:b35f with SMTP id a640c23a62f3a-a86a54b694dmr101050966b.58.1724402440963; Fri, 23 Aug 2024 01:40:40 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f29004csm229783366b.46.2024.08.23.01.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Aug 2024 01:40:40 -0700 (PDT) Message-ID: <59f4d28b-5b9b-427a-baca-739fc03a5cc1@tuxon.dev> Date: Fri, 23 Aug 2024 11:40:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/16] reset: rzg2l-usbphy-ctrl: Add support for RZ/G3S Content-Language: en-US To: Biju Das , "vkoul@kernel.org" , "kishon@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" , "gregkh@linuxfoundation.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , Yoshihiro Shimoda , "ulf.hansson@linaro.org" Cc: "linux-phy@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-pm@vger.kernel.org" , Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-9-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_014042_995399_85C18A37 X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Biju, On 22.08.2024 19:59, Biju Das wrote: > Hi Claudiu, > >> -----Original Message----- >> From: Claudiu >> Sent: Thursday, August 22, 2024 4:28 PM >> Subject: [PATCH 08/16] reset: rzg2l-usbphy-ctrl: Add support for RZ/G3S >> >> From: Claudiu Beznea >> >> Add support for RZ/G3S SoC. It needs its own compatible as it uses 2 reset signals and it cannot work >> w/o both of them. To be able to fully validate this on DT schema, too, the RZ/G3S uses it's own >> compatible w/o a fallback (as if the fallback will be used the RZ/G3S will not work anyway). > > Other than reset/ power domain approach for handling USBPWRRDY signal > > Can't USBPWRRDY signal handled in SYSC driver directly? Since SYSC driver init happens at very early boot stage > Check for USBPHY control device availability and handle USBPWRRDY signal there?? In theory, it can be done this way, too. The downside I see at the moment with this approach would be that the USB, PCIe drivers will not be in charge with handling their signals, there will be no direct dependency available b/w SYSC and USB drivers. The HW manual doesn't mention anything about the power consumption of the USB, PCI areas based on the state of the signals from SYSC, so, I don't know if there will be any implication on this if the signals will be just de-asserted from the SYSC driver. Thank you, Claudiu Beznea > Cheers, > Biju > >> >> Signed-off-by: Claudiu Beznea >> --- >> drivers/reset/reset-rzg2l-usbphy-ctrl.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/reset/reset-rzg2l-usbphy-ctrl.c b/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> index 8b64c12f3bec..08b18d7de7ad 100644 >> --- a/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> +++ b/drivers/reset/reset-rzg2l-usbphy-ctrl.c >> @@ -93,6 +93,7 @@ static int rzg2l_usbphy_ctrl_status(struct reset_controller_dev *rcdev, >> >> static const struct of_device_id rzg2l_usbphy_ctrl_match_table[] = { >> { .compatible = "renesas,rzg2l-usbphy-ctrl" }, >> + { .compatible = "renesas,r9a08g045-usbphy-ctrl" }, >> { /* Sentinel */ } >> }; >> MODULE_DEVICE_TABLE(of, rzg2l_usbphy_ctrl_match_table); >> -- >> 2.39.2 >