From: laurentiu.tudor@nxp.com (Laurentiu Tudor)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] staging: fsl-mc: move bus driver out of staging
Date: Wed, 20 Dec 2017 11:52:32 +0000 [thread overview]
Message-ID: <5A3A4EFF.6050901@nxp.com> (raw)
In-Reply-To: <20171220110641.GB7001@kroah.com>
On 12/20/2017 01:06 PM, Greg KH wrote:
> On Wed, Dec 20, 2017 at 10:52:52AM +0000, Laurentiu Tudor wrote:
>>
>>
>> On 12/20/2017 12:42 PM, Greg KH wrote:
>>> On Wed, Dec 20, 2017 at 10:26:49AM +0000, Laurentiu Tudor wrote:
>>>> On 12/19/2017 06:10 PM, Greg KH wrote:
>>>>>>> But all of these .h files are only used by the code in this specific
>>>>>>> directory, no where else.
>>>>>>
>>>>>> They are also used by our ethernet driver, see:
>>>>>> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
>>>>>
>>>>> Ick, really? Then they should not be buried in a bus-specific
>>>>> location, but rather be in include/linux/SOMEWHERE, right?
>>>>
>>>> Right. The goal is that in the end, all headers be moved to the already
>>>> existing include/linux/fsl/. For now I've left these in staging because
>>>> they are not part of the bus "core" infrastructure.
>>>
>>> Then shouldn't they be in the drivers/staging/fsl-mc/include/ directory
>>> now to show this?
>>
>> Not sure i get your comment. Aren't we talking about the headers in there?
>>
>> This was your original comment:
>>
>> > Also, what's up with the .h files in drivers/staging/fsl-bus/include?
>> > You didn't touch those with this movement, right? Why?
>
> Ok, yeah, I'm getting confused now. Let's just see what you do with
> your next set of patches and we can go from there :)
Ok, I'll start working on it. Thanks for the review!
---
Best Regards, Laurentiu
prev parent reply other threads:[~2017-12-20 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171129100844.19874-1-laurentiu.tudor@nxp.com>
2017-12-19 14:48 ` [PATCH v4] staging: fsl-mc: move bus driver out of staging Greg KH
2017-12-19 15:21 ` Laurentiu Tudor
2017-12-19 15:29 ` Greg KH
2017-12-19 15:39 ` Laurentiu Tudor
2017-12-19 16:10 ` Greg KH
2017-12-20 10:26 ` Laurentiu Tudor
2017-12-20 10:42 ` Greg KH
2017-12-20 10:52 ` Laurentiu Tudor
2017-12-20 11:06 ` Greg KH
2017-12-20 11:52 ` Laurentiu Tudor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A3A4EFF.6050901@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).