linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arvind.yadav.cs@gmail.com (arvindY)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/11 v3] ARM: s3c24xx/s3c64xx: constify gpio_led
Date: Wed, 27 Dec 2017 16:33:09 +0530	[thread overview]
Message-ID: <5A437DED.3030703@gmail.com> (raw)
In-Reply-To: <CAJKOXPf3izR2nquBds3gvhXRRh=hx4JvAgC+XrJ=sUnq3tjexQ@mail.gmail.com>

Hi,

On Wednesday 27 December 2017 01:49 PM, Krzysztof Kozlowski wrote:
> On Tue, Dec 26, 2017 at 7:50 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
>> gpio_led are not supposed to change at runtime.
>> struct gpio_led_platform_data working with const gpio_led
>> provided by <linux/leds.h>. So mark the non-const structs
>> as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> changes in v2:
>>                The GPIO LED driver can be built as a module, it can
>>                be loaded after the init sections have gone away.
>>                So removed '__initconst'.
>> changes in v3:
>>               Description was missing.
>>
>>   arch/arm/mach-s3c24xx/mach-h1940.c    | 2 +-
>>   arch/arm/mach-s3c24xx/mach-rx1950.c   | 2 +-
>>   arch/arm/mach-s3c64xx/mach-hmt.c      | 2 +-
>>   arch/arm/mach-s3c64xx/mach-smartq5.c  | 2 +-
>>   arch/arm/mach-s3c64xx/mach-smartq7.c  | 2 +-
>>   arch/arm/mach-s3c64xx/mach-smdk6410.c | 2 +-
>>   6 files changed, 6 insertions(+), 6 deletions(-)
> There were few build errors reported by kbuild for your patches. Are
> you sure that you compiled every file you touch?
>
> Best regards,
> Krzysztof
Yes, I got few build error which I have fixed it. and send updated patch.
Now I have done cross checking.  It's not having any build failure.

Regards
arvind

  reply	other threads:[~2017-12-27 11:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <de0879ef47b96776e3f18a1889c41d976a677b21.1514267721.git.arvind.yadav.cs@gmail.com>
2017-12-26  6:37 ` [PATCH 06/11 v2] ARM: davinci: constify gpio_led Arvind Yadav
2017-12-26  6:37   ` [PATCH 07/11 v2] ARM: ixp4xx: " Arvind Yadav
2017-12-26  6:37   ` [PATCH 08/11 v2] ARM: OMAP1: " Arvind Yadav
2018-01-09 17:32     ` Aaro Koskinen
2018-07-02 11:16     ` Tony Lindgren
2017-12-26  6:37   ` [PATCH 09/11 v2] ARM: orion5x: " Arvind Yadav
2017-12-26 23:02     ` kbuild test robot
2017-12-26  6:37   ` [PATCH 10/11 v2] ARM: s3c24xx/s3c64xx: " Arvind Yadav
2017-12-26 17:42     ` Krzysztof Kozlowski
2017-12-26 18:40       ` arvindY
2017-12-27  8:19     ` [PATCH 10/11 v3] " Krzysztof Kozlowski
2017-12-27 11:03       ` arvindY [this message]
2017-12-26  6:37   ` [PATCH 11/11 v2] ARM: pxa: " Arvind Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A437DED.3030703@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).