From: jeffy.chen@rock-chips.com (JeffyChen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 09/13] iommu/rockchip: Use iommu_group_get_for_dev() for add_device
Date: Wed, 17 Jan 2018 20:53:32 +0800 [thread overview]
Message-ID: <5A5F474C.8020606@rock-chips.com> (raw)
In-Reply-To: <5A5F45DA.5000104@rock-chips.com>
On 01/17/2018 08:47 PM, JeffyChen wrote:
>>>
>>> +static struct iommu_group *rk_iommu_device_group(struct device *dev)
>>> +{
>>> + struct iommu_group *group;
>>> + int ret;
>>> +
>>> + group = iommu_group_get(dev);
>>> + if (!group) {
>>
>> This check is pointless - if dev->iommu_group were non-NULL you wouldn't
>> have been called in the first place.
> right, it's allocated in the probe.
oops, sorry, i see, this is not needed because device_group() is only be
called when iommu_group_get() returns NULL
next prev parent reply other threads:[~2018-01-17 12:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180116132540.18939-1-jeffy.chen@rock-chips.com>
[not found] ` <20180116132540.18939-3-jeffy.chen@rock-chips.com>
2018-01-17 4:23 ` [PATCH v2 02/13] iommu/rockchip: Suppress unbinding Tomasz Figa
2018-01-17 5:32 ` Tomasz Figa
[not found] ` <20180116132540.18939-5-jeffy.chen@rock-chips.com>
2018-01-17 5:22 ` [PATCH v2 04/13] iommu/rockchip: Fix error handling in probe Tomasz Figa
[not found] ` <20180116132540.18939-6-jeffy.chen@rock-chips.com>
2018-01-17 5:26 ` [PATCH v2 05/13] iommu/rockchip: Fix error handling in init Tomasz Figa
[not found] ` <5A5EF7D3.90405@rock-chips.com>
2018-01-17 7:19 ` Tomasz Figa
2018-01-17 12:27 ` Tomasz Figa
2018-01-17 11:36 ` Robin Murphy
[not found] ` <20180116132540.18939-11-jeffy.chen@rock-chips.com>
2018-01-17 5:37 ` [PATCH v2 10/13] iommu/rockchip: Use IOMMU device for dma mapping operations Tomasz Figa
[not found] ` <20180116132540.18939-12-jeffy.chen@rock-chips.com>
2018-01-17 5:44 ` [PATCH v2 11/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically Tomasz Figa
[not found] ` <5A5EF94E.7010806@rock-chips.com>
2018-01-17 7:30 ` Tomasz Figa
2018-01-17 7:47 ` JeffyChen
[not found] ` <20180116132540.18939-13-jeffy.chen@rock-chips.com>
2018-01-17 6:20 ` [PATCH v2 12/13] iommu/rockchip: Add runtime PM support Tomasz Figa
[not found] ` <5A5EFAB2.7040001@rock-chips.com>
2018-01-17 7:38 ` Tomasz Figa
2018-01-17 7:52 ` JeffyChen
2018-01-17 8:48 ` JeffyChen
[not found] ` <20180116132540.18939-2-jeffy.chen@rock-chips.com>
2018-01-17 4:21 ` [PATCH v2 01/13] iommu/rockchip: Request irqs in rk_iommu_probe() Tomasz Figa
[not found] ` <5A5EF672.6040304@rock-chips.com>
2018-01-17 7:16 ` Tomasz Figa
2018-01-17 7:45 ` JeffyChen
2018-01-17 12:18 ` Robin Murphy
2018-01-17 12:46 ` JeffyChen
[not found] ` <20180116132540.18939-10-jeffy.chen@rock-chips.com>
2018-01-17 12:31 ` [PATCH v2 09/13] iommu/rockchip: Use iommu_group_get_for_dev() for add_device Robin Murphy
2018-01-17 12:47 ` JeffyChen
2018-01-17 12:53 ` JeffyChen [this message]
[not found] ` <20180116132540.18939-14-jeffy.chen@rock-chips.com>
2018-01-17 13:00 ` [PATCH v2 13/13] iommu/rockchip: Support sharing IOMMU between masters Robin Murphy
2018-01-17 13:32 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A5F474C.8020606@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).