From: jeffy.chen@rock-chips.com (JeffyChen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove
Date: Thu, 18 Jan 2018 16:28:58 +0800 [thread overview]
Message-ID: <5A605ACA.7030207@rock-chips.com> (raw)
In-Reply-To: <CAAFQd5B24j6OSStpYWiO-xfhH131mwNRk3=cEBakMpvsEkQ7wg@mail.gmail.com>
Hi Tomasz,
Thanks for your reply.
and just found i forgot to add iommu clocks for other rockchip
platforms(rk3399 already has that)...will also do that in the next version.
On 01/18/2018 12:17 PM, Tomasz Figa wrote:
> On Thu, Jan 18, 2018 at 12:25 AM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
>> Removal the IOMMUs cannot be done reliably.
>
> nit: Perhaps "Removal of IOMMUs"?
>
ok
>>
>> This is similar to exynos iommu driver.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Changes in v3:
>> Also remove remove() and module_exit() as Tomasz suggested.
>>
>> Changes in v2: None
>>
>> drivers/iommu/rockchip-iommu.c | 21 +--------------------
>> 1 file changed, 1 insertion(+), 20 deletions(-)
>
> nit: Typo in subject: s/Prohibiat/Prohibit/
>
ok, will do that.
> Otherwise,
>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
>
> Best regards,
> Tomasz
>
>
>
next prev parent reply other threads:[~2018-01-18 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 15:25 [PATCH v3 00/12] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove Jeffy Chen
2018-01-18 4:17 ` Tomasz Figa
2018-01-18 8:28 ` JeffyChen [this message]
2018-01-17 15:25 ` [PATCH v3 02/12] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 03/12] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 04/12] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 05/12] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 06/12] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 07/12] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 08/12] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 09/12] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 10/12] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 11/12] iommu/rockchip: Add runtime PM support Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 12/12] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A605ACA.7030207@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).