* [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation.
@ 2019-09-03 6:54 zhong jiang
2019-09-04 10:25 ` Will Deacon
2019-09-09 7:48 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: zhong jiang @ 2019-09-03 6:54 UTC (permalink / raw)
To: herbert, davem, catalin.marinas
Cc: zhongjiang, will, linux-crypto, linux-arm-kernel, linux-kernel
PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
use it directly. hence just replace it.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
arch/arm64/crypto/aes-glue.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c
index ca0c84d..2a2e0a3 100644
--- a/arch/arm64/crypto/aes-glue.c
+++ b/arch/arm64/crypto/aes-glue.c
@@ -409,10 +409,8 @@ static int essiv_cbc_init_tfm(struct crypto_skcipher *tfm)
struct crypto_aes_essiv_cbc_ctx *ctx = crypto_skcipher_ctx(tfm);
ctx->hash = crypto_alloc_shash("sha256", 0, 0);
- if (IS_ERR(ctx->hash))
- return PTR_ERR(ctx->hash);
- return 0;
+ return PTR_ERR_OR_ZERO(ctx->hash);
}
static void essiv_cbc_exit_tfm(struct crypto_skcipher *tfm)
--
1.7.12.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation.
2019-09-03 6:54 [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation zhong jiang
@ 2019-09-04 10:25 ` Will Deacon
2019-09-05 6:25 ` zhong jiang
2019-09-09 7:48 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Will Deacon @ 2019-09-04 10:25 UTC (permalink / raw)
To: zhong jiang
Cc: herbert, catalin.marinas, linux-kernel, linux-crypto, davem,
linux-arm-kernel
On Tue, Sep 03, 2019 at 02:54:16PM +0800, zhong jiang wrote:
> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
> use it directly. hence just replace it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/arm64/crypto/aes-glue.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c
> index ca0c84d..2a2e0a3 100644
> --- a/arch/arm64/crypto/aes-glue.c
> +++ b/arch/arm64/crypto/aes-glue.c
> @@ -409,10 +409,8 @@ static int essiv_cbc_init_tfm(struct crypto_skcipher *tfm)
> struct crypto_aes_essiv_cbc_ctx *ctx = crypto_skcipher_ctx(tfm);
>
> ctx->hash = crypto_alloc_shash("sha256", 0, 0);
> - if (IS_ERR(ctx->hash))
> - return PTR_ERR(ctx->hash);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(ctx->hash);
> }
>
> static void essiv_cbc_exit_tfm(struct crypto_skcipher *tfm)
Acked-by: Will Deacon <will@kernel.org>
Assuming this will go via Herbert.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation.
2019-09-04 10:25 ` Will Deacon
@ 2019-09-05 6:25 ` zhong jiang
0 siblings, 0 replies; 4+ messages in thread
From: zhong jiang @ 2019-09-05 6:25 UTC (permalink / raw)
To: Will Deacon, herbert
Cc: linux-arm-kernel, catalin.marinas, davem, linux-kernel,
linux-crypto
On 2019/9/4 18:25, Will Deacon wrote:
> On Tue, Sep 03, 2019 at 02:54:16PM +0800, zhong jiang wrote:
>> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
>> use it directly. hence just replace it.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> arch/arm64/crypto/aes-glue.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c
>> index ca0c84d..2a2e0a3 100644
>> --- a/arch/arm64/crypto/aes-glue.c
>> +++ b/arch/arm64/crypto/aes-glue.c
>> @@ -409,10 +409,8 @@ static int essiv_cbc_init_tfm(struct crypto_skcipher *tfm)
>> struct crypto_aes_essiv_cbc_ctx *ctx = crypto_skcipher_ctx(tfm);
>>
>> ctx->hash = crypto_alloc_shash("sha256", 0, 0);
>> - if (IS_ERR(ctx->hash))
>> - return PTR_ERR(ctx->hash);
>>
>> - return 0;
>> + return PTR_ERR_OR_ZERO(ctx->hash);
>> }
>>
>> static void essiv_cbc_exit_tfm(struct crypto_skcipher *tfm)
> Acked-by: Will Deacon <will@kernel.org>
Thanks.
Sincerely,
zhong jiang
> Assuming this will go via Herbert.
>
> Will
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation.
2019-09-03 6:54 [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation zhong jiang
2019-09-04 10:25 ` Will Deacon
@ 2019-09-09 7:48 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2019-09-09 7:48 UTC (permalink / raw)
To: zhong jiang
Cc: catalin.marinas, linux-kernel, linux-crypto, will, davem,
linux-arm-kernel
On Tue, Sep 03, 2019 at 02:54:16PM +0800, zhong jiang wrote:
> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
> use it directly. hence just replace it.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/arm64/crypto/aes-glue.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-09 7:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-03 6:54 [PATCH] crypto: arm64: Use PTR_ERR_OR_ZERO rather than its implementation zhong jiang
2019-09-04 10:25 ` Will Deacon
2019-09-05 6:25 ` zhong jiang
2019-09-09 7:48 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).