From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1582EC433F5 for ; Fri, 8 Apr 2022 23:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5odGS+/hPABGyg0DYeqH3lmoy7vn5qsavJkKhlTHFOo=; b=daihyR4zrEXPza x53/gAEoHJmkW9XI+YAtyqXXPBMvWugfBlGCqz8MjRcj7xy/DwM9kmsOnEgHDXaFO52ErbRHzbCta El6ayi1aaDD5tGMFHIIoxv7LAymXQJe1CgyzQIrbdjKjqc6Auramuq1Th8qpdTWqaedQrytkGwnIe 5rpy+D04WxPua2sNj1ZYHPw77HrQWQBxgET3Was1mxc5TFshnULTqzA1+Uh00Rx1mo/8BYDqjDlm3 dF8E8G5b1ifWv5VqofqGFumM/eUn9Psn4vSfyyqtXyue092LfYmR6+g82+iSSi0FcuHUSIqmhTo9b NhzDOUBqA75GXrXXQfqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncyLv-001Ul5-6n; Fri, 08 Apr 2022 23:49:19 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncyLs-001Ukd-Ig for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 23:49:18 +0000 Received: by mail-wr1-x434.google.com with SMTP id k23so15025337wrd.8 for ; Fri, 08 Apr 2022 16:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jJJz58zv7KMZ+uRF9TJ9vVznBCdQcIV2nZTcm+DabQ4=; b=LeZBXq596L+RUC07MpUfK8sijkiOV/vjQN9FZpAqEwrZKQgAaBP8Xi+J4cOun+Ubzh VMuGOVeglyE1HfmvNlx3z9ylLBBnAv6sGLSBrNQVXA5gZzKeWM97/qpJrqGSIe/u3m/D /2E0GQ0SqViJw7LkoqXSEoCVFVTv4cG+J/1BWapGfMJjKj6WMbS+2IqQQSbUFYrCuxns Y1nBae1kNQncq/nTxRWsXNSfCm/BAe6MoAd/kWJ6NyopBkFDqwglTv8hHvT01tNGJh0S ku2qo8WIkBTQkoRh/EOdGMeU5dHrSa8P0pXDFG3zOfqFFuqYerPdMs3rng/UgFf4sEyP O2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jJJz58zv7KMZ+uRF9TJ9vVznBCdQcIV2nZTcm+DabQ4=; b=VSdSPL1kxHXdTBOJifuc0tf3R+ZDENgLrcXMas7gugl8J2tCQvUbUgZT91WGeLybq6 X/ngq6mqqGvX25IsJ3UhcU4jP6/u02HUHjM08ToK9vG+pKJn9bpaHzuQhw7Wy+nn3sQz n7aR7cyliEfVGESOOjYW2vTP3LoVPUI0tXlT7AJUah9yVyRFMmM9ZtOZnWKN9qYw3xCc 85y3OQlhR5V/Fd7iAfU2+9wqz1iqq5WZMIrVQyZUh8RU+vvOMJHI/A9l2iGFVJzTIbb0 YDT9hF/CPVyhTSPKFNyC8gQrRy0tRF+l+opRgl09tpoKw7srJo64AGp/5Dcza0D1nwGr v1Yg== X-Gm-Message-State: AOAM531BKJP+YBzm5Qj8Skfk0Tw3VLfIDsiimELFxuj3B6hOfcvNiMbR fr8x8p7h3AyBg82pyPF8K98= X-Google-Smtp-Source: ABdhPJziLwcsZqKYo3LDpwK2CM3T5m9xeYqROL4FNm0o8b9RWL3l+AB20WPLz1nFs+aacFs/QPi/nA== X-Received: by 2002:a05:6000:18ae:b0:204:62a:20f4 with SMTP id b14-20020a05600018ae00b00204062a20f4mr17229958wri.640.1649461754381; Fri, 08 Apr 2022 16:49:14 -0700 (PDT) Received: from smtpclient.apple ([185.238.38.242]) by smtp.gmail.com with ESMTPSA id l3-20020a05600002a300b00207902922cesm3588316wry.15.2022.04.08.16.49.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Apr 2022 16:49:13 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH net-next 02/15] net: dsa: sja1105: Remove usage of iterator for list_add() after loop From: Jakob Koschel In-Reply-To: Date: Sat, 9 Apr 2022 01:49:10 +0200 Cc: "David S. Miller" , Andrew Lunn , Cristiano Giuffrida , Eric Dumazet , Paul Mackerras , Ariel Elior , Florian Fainelli , Manish Chopra , Steen Hegelund , "Bos, H.J." , "linux-arm-kernel@lists.infradead.org" , Martin Habets , Paolo Abeni , Vivien Didelot , Bjarni Jonasson , Jiri Pirko , Arnd Bergmann , Brian Johannesmeyer , Christophe JAILLET , Jakub Kicinski , Di Zhu , Lars Povlsen , Colin Ian King , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "UNGLinuxDriver@microchip.com" , Edward Cree , Michael Walle , Xu Wang , Vladimir Oltean , "linuxppc-dev@lists.ozlabs.org" , Casper Andersson , Mike Rapoport Message-Id: <5F571243-683A-42F0-8E9B-4A8C9853A9D6@gmail.com> References: <20220407102900.3086255-1-jakobkoschel@gmail.com> <20220407102900.3086255-3-jakobkoschel@gmail.com> To: Christophe Leroy X-Mailer: Apple Mail (2.3696.80.82.1.1) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_164916_657763_2BFB3937 X-CRM114-Status: GOOD ( 26.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGV5IENocmlzdG9waGUsCgo+IE9uIDguIEFwciAyMDIyLCBhdCAwOTo0NywgQ2hyaXN0b3BoZSBM ZXJveSA8Y2hyaXN0b3BoZS5sZXJveUBjc2dyb3VwLmV1PiB3cm90ZToKPiAKPiAKPiAKPiBMZSAw Ny8wNC8yMDIyIMOgIDEyOjI4LCBKYWtvYiBLb3NjaGVsIGEgw6ljcml0IDoKPj4gSW4gcHJlcGFy YXRpb24gdG8gbGltaXQgdGhlIHNjb3BlIG9mIGEgbGlzdCBpdGVyYXRvciB0byB0aGUgbGlzdAo+ PiB0cmF2ZXJzYWwgbG9vcCwgdXNlIGEgZGVkaWNhdGVkIHBvaW50ZXIgdG8gcG9pbnQgdG8gdGhl IGZvdW5kIGVsZW1lbnQgWzFdLgo+PiAKPj4gQmVmb3JlLCB0aGUgY29kZSBpbXBsaWNpdGx5IHVz ZWQgdGhlIGhlYWQgd2hlbiBubyBlbGVtZW50IHdhcyBmb3VuZAo+PiB3aGVuIHVzaW5nICZwb3Mt Pmxpc3QuIFNpbmNlIHRoZSBuZXcgdmFyaWFibGUgaXMgb25seSBzZXQgaWYgYW4KPj4gZWxlbWVu dCB3YXMgZm91bmQsIHRoZSBsaXN0X2FkZCgpIGlzIHBlcmZvcm1lZCB3aXRoaW4gdGhlIGxvb3AK Pj4gYW5kIG9ubHkgZG9uZSBhZnRlciB0aGUgbG9vcCBpZiBpdCBpcyBkb25lIG9uIHRoZSBsaXN0 IGhlYWQgZGlyZWN0bHkuCj4+IAo+PiBMaW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwv Q0FIay09d2dScl9EOENCLUQ5S2ctYz1FSHJlQXNrNVNxWFB3cjlZN2s5c0E2Y1dYSjZ3QG1haWwu Z21haWwuY29tLyBbMV0KPj4gU2lnbmVkLW9mZi1ieTogSmFrb2IgS29zY2hlbCA8amFrb2Jrb3Nj aGVsQGdtYWlsLmNvbT4KPj4gLS0tCj4+IGRyaXZlcnMvbmV0L2RzYS9zamExMTA1L3NqYTExMDVf dmwuYyB8IDE0ICsrKysrKysrKy0tLS0tCj4+IDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMo KyksIDUgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZHNhL3Nq YTExMDUvc2phMTEwNV92bC5jIGIvZHJpdmVycy9uZXQvZHNhL3NqYTExMDUvc2phMTEwNV92bC5j Cj4+IGluZGV4IGI3ZTk1ZDYwYTZlNC4uY2ZjYWU0ZDE5ZWVmIDEwMDY0NAo+PiAtLS0gYS9kcml2 ZXJzL25ldC9kc2Evc2phMTEwNS9zamExMTA1X3ZsLmMKPj4gKysrIGIvZHJpdmVycy9uZXQvZHNh L3NqYTExMDUvc2phMTEwNV92bC5jCj4+IEBAIC0yNywyMCArMjcsMjQgQEAgc3RhdGljIGludCBz amExMTA1X2luc2VydF9nYXRlX2VudHJ5KHN0cnVjdCBzamExMTA1X2dhdGluZ19jb25maWcgKmdh dGluZ19jZmcsCj4+IAlpZiAobGlzdF9lbXB0eSgmZ2F0aW5nX2NmZy0+ZW50cmllcykpIHsKPj4g CQlsaXN0X2FkZCgmZS0+bGlzdCwgJmdhdGluZ19jZmctPmVudHJpZXMpOwo+PiAJfSBlbHNlIHsK Pj4gLQkJc3RydWN0IHNqYTExMDVfZ2F0ZV9lbnRyeSAqcDsKPj4gKwkJc3RydWN0IHNqYTExMDVf Z2F0ZV9lbnRyeSAqcCA9IE5VTEwsICppdGVyOwo+PiAKPj4gLQkJbGlzdF9mb3JfZWFjaF9lbnRy eShwLCAmZ2F0aW5nX2NmZy0+ZW50cmllcywgbGlzdCkgewo+PiAtCQkJaWYgKHAtPmludGVydmFs ID09IGUtPmludGVydmFsKSB7Cj4+ICsJCWxpc3RfZm9yX2VhY2hfZW50cnkoaXRlciwgJmdhdGlu Z19jZmctPmVudHJpZXMsIGxpc3QpIHsKPj4gKwkJCWlmIChpdGVyLT5pbnRlcnZhbCA9PSBlLT5p bnRlcnZhbCkgewo+PiAJCQkJTkxfU0VUX0VSUl9NU0dfTU9EKGV4dGFjaywKPj4gCQkJCQkJICJH YXRlIGNvbmZsaWN0Iik7Cj4+IAkJCQlyYyA9IC1FQlVTWTsKPj4gCQkJCWdvdG8gZXJyOwo+PiAJ CQl9Cj4+IAo+PiAtCQkJaWYgKGUtPmludGVydmFsIDwgcC0+aW50ZXJ2YWwpCj4+ICsJCQlpZiAo ZS0+aW50ZXJ2YWwgPCBpdGVyLT5pbnRlcnZhbCkgewo+PiArCQkJCXAgPSBpdGVyOwo+PiArCQkJ CWxpc3RfYWRkKCZlLT5saXN0LCBpdGVyLT5saXN0LnByZXYpOwo+PiAJCQkJYnJlYWs7Cj4+ICsJ CQl9Cj4+IAkJfQo+PiAtCQlsaXN0X2FkZCgmZS0+bGlzdCwgcC0+bGlzdC5wcmV2KTsKPj4gKwkJ aWYgKCFwKQo+PiArCQkJbGlzdF9hZGQoJmUtPmxpc3QsIGdhdGluZ19jZmctPmVudHJpZXMucHJl dik7Cj4+IAl9Cj4+IAo+PiAJZ2F0aW5nX2NmZy0+bnVtX2VudHJpZXMrKzsKPiAKPiBUaGlzIGNo YW5nZSBsb29rcyB1Z2x5LCB3aHkgZHVwbGljYXRpbmcgdGhlIGxpc3RfYWRkKCkgdG8gZG8gdGhl IHNhbWUgPyAKPiBBdCB0aGUgZW5kIG9mIHRoZSBsb29wIHRoZSBwb2ludGVyIGNvbnRhaW5zIGdh dGluZ19jZmctPmVudHJpZXMsIHNvIGl0IAo+IHdhcyBjbGVhbmVyIGJlZm9yZS4KPiAKPiBJZiB5 b3UgZG9uJ3Qgd2FudCB0byB1c2UgdGhlIGxvb3AgaW5kZXggb3V0c2lkZSB0aGUgbG9vcCwgZmFp ciBlbm91Z2gsIAo+IGFsbCB5b3UgaGF2ZSB0byBkbyBpczoKPiAKPiAJCXN0cnVjdCBzamExMTA1 X2dhdGVfZW50cnkgKnAsICppdGVyOwo+IAo+IAkJbGlzdF9mb3JfZWFjaF9lbnRyeShpdGVyLCAm Z2F0aW5nX2NmZy0+ZW50cmllcywgbGlzdCkgewo+IAkJCWlmIChpdGVyLT5pbnRlcnZhbCA9PSBl LT5pbnRlcnZhbCkgewo+IAkJCQlOTF9TRVRfRVJSX01TR19NT0QoZXh0YWNrLAo+IAkJCQkJCSAi R2F0ZSBjb25mbGljdCIpOwo+IAkJCQlyYyA9IC1FQlVTWTsKPiAJCQkJZ290byBlcnI7Cj4gCQkJ fQo+IAkJCXAgPSBpdGVyOwo+IAo+IAkJCWlmIChlLT5pbnRlcnZhbCA8IGl0ZXItPmludGVydmFs KQo+IAkJCQlicmVhazsKPiAJCX0KPiAJCWxpc3RfYWRkKCZlLT5saXN0LCBwLT5saXN0LnByZXYp OwoKVGhhbmtzIGZvciB0aGUgcmV2aWV3IGFuZCBpbnB1dC4KClRoZSBjb2RlIHlvdSBhcmUgc2hv d2luZyBoZXJlIHdvdWxkIGhhdmUgYW4gdW5pbml0aWFsaXplZCBhY2Nlc3MgdG8gJ3AnCmlmIHRo ZSBsaXN0IGlzIGVtcHR5LgoKQWxzbyAncC0+bGlzdC5wcmV2JyB3aWxsIGJlIHRoZSBzZWNvbmQg bGFzdCBlbnRyeSBpZiB0aGUgbGlzdCBpdGVyYXRvcgpyYW4gdGhyb3VnaCBjb21wbGV0ZWx5LCB3 aGVyZWFzIHRoZSBvcmlnaW5hbCBjb2RlIHdhcyBwb2ludGluZyB0byB0aGUgbGFzdAplbnRyeSBv ZiB0aGUgbGlzdC4KCklNTyBWbGFkaW1pciBPbHRlYW4gcG9zdGVkIGEgbmljZSBhbHRlcm5hdGl2 ZSB3YXkgdG8gc29sdmUgaXQsIHNlZSBbMV0uClRoYXQgd2F5IGl0IGtlZXBzIHRoZSBzZW1hbnRp Y3Mgb2YgdGhlIGNvZGUgdGhlIHNhbWUgYW5kIGRvZXNuJ3QgZHVwbGljYXRlCnRoZSBsaXN0X2Fk ZC4KCj4gCj4gCj4gCj4gQ2hyaXN0b3BoZQoKWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xp bnV4LWtlcm5lbC8yMDIyMDQwODExNDEyMC50dmYybHh2aGZxYm5ybG1sQHNrYnVmLwoKVGhhbmtz LApKYWtvYgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK