From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64085C43461 for ; Thu, 17 Sep 2020 01:40:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAA0D2076C for ; Thu, 17 Sep 2020 01:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c60Ezfha" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAA0D2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l7q66bPQeNdNQFogLScVBmnrZpYx+uesu8DjFrWTgxY=; b=c60Ezfha0D7SXVC1OVD0zdW5J rhyds+/AFwgNaSmTNMCuWOje9668u/IpEy1xfbqYdB5iY3jrn0IjEdPY1x+X2XQTKEoBTrLqKWP4p oGG14JNEIQyKJcDXoilASGCrUbwclWSfhvC9/dmRb65z6/BI5fClpLLNo23jOJhttWnjQkU5LBnpA EMxE+rEiskk2xiMk5f6w3eLDcHXdfkix+cR8E6BHr9gyL/1YFOGoRlsQhMZDZn1S9hEzvr3IFQ/nh qAnJgwppBYLUixaqbjIFx3+6hwsO0wSfWSJz7WWmBbSh3UyIHVWy7lpBnvJ8TGnqVORtQZFIC3CS9 aAMDmpqsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIisq-0000qs-K3; Thu, 17 Sep 2020 01:38:48 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIism-0000pd-5Z for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 01:38:45 +0000 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4C4479FA31C5FF9D6CFA; Thu, 17 Sep 2020 09:38:32 +0800 (CST) Received: from [127.0.0.1] (10.74.185.4) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Thu, 17 Sep 2020 09:38:22 +0800 Subject: Re: [PATCH v2] KVM: arm64: fix doc warnings in mmu code To: Will Deacon References: <1600221639-4471-1-git-send-email-tanxiaofei@huawei.com> <20200916083756.GD27496@willie-the-truck> From: Xiaofei Tan Message-ID: <5F62BE0E.9060208@huawei.com> Date: Thu, 17 Sep 2020 09:38:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20200916083756.GD27496@willie-the-truck> X-Originating-IP: [10.74.185.4] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_213844_969826_42B7C8B0 X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, maz@kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, Thanks for your advices, will accept all of them. On 2020/9/16 16:37, Will Deacon wrote: > On Wed, Sep 16, 2020 at 10:00:39AM +0800, Xiaofei Tan wrote: >> Fix following warnings caused by mismatch bewteen function parameters >> and comments. >> arch/arm64/kvm/mmu.c:128: warning: Function parameter or member 'mmu' not described in '__unmap_stage2_range' >> arch/arm64/kvm/mmu.c:128: warning: Function parameter or member 'may_block' not described in '__unmap_stage2_range' >> arch/arm64/kvm/mmu.c:128: warning: Excess function parameter 'kvm' description in '__unmap_stage2_range' >> arch/arm64/kvm/mmu.c:499: warning: Function parameter or member 'writable' not described in 'kvm_phys_addr_ioremap' >> arch/arm64/kvm/mmu.c:538: warning: Function parameter or member 'mmu' not described in 'stage2_wp_range' >> arch/arm64/kvm/mmu.c:538: warning: Excess function parameter 'kvm' description in 'stage2_wp_range' >> >> Signed-off-by: Xiaofei Tan >> --- >> arch/arm64/kvm/mmu.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c >> index e8a51799..909e995 100644 >> --- a/arch/arm64/kvm/mmu.c >> +++ b/arch/arm64/kvm/mmu.c >> @@ -114,9 +114,10 @@ static bool kvm_is_device_pfn(unsigned long pfn) >> */ >> /** >> * unmap_stage2_range -- Clear stage2 page table entries to unmap a range >> - * @kvm: The VM pointer >> + * @mmu: pointer to mmu structure to operate on >> * @start: The intermediate physical base address of the range to unmap >> * @size: The size of the area to unmap >> + * @may_block: The flag that if block is allowed here > > Whether or not we are permitted to block. > >> * >> * Clear a range of stage-2 mappings, lowering the various ref-counts. Must >> * be called while holding mmu_lock (unless for freeing the stage2 pgd before >> @@ -493,6 +494,7 @@ void kvm_free_stage2_pgd(struct kvm_s2_mmu *mmu) >> * @guest_ipa: The IPA at which to insert the mapping >> * @pa: The physical address of the device >> * @size: The size of the mapping >> + * @writable: If it is writable here > > Whether or not to create a writable mapping. > >> */ >> int kvm_phys_addr_ioremap(struct kvm *kvm, phys_addr_t guest_ipa, >> phys_addr_t pa, unsigned long size, bool writable) >> @@ -530,7 +532,7 @@ int kvm_phys_addr_ioremap(struct kvm *kvm, phys_addr_t guest_ipa, >> >> /** >> * stage2_wp_range() - write protect stage2 memory region range >> - * @kvm: The KVM pointer >> + * @mmu: pointer to mmu structure to operate on > > The KVM stage-2 MMU pointer. > > Will > > . > -- thanks tanxiaofei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel