From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 304D9C4332F for ; Thu, 2 Nov 2023 11:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ICvhwaHH0ChEMGr1Qr4w/U/R4Gs6eXT8hFonj0mAL8o=; b=gqa5FjsTNJkXBf QTDTME2T2ErGOG6zVopx6YkuYTkz4ZddsVLzKWCt1UUTHB8vlS+jbQIUFr0U4j3VjqWE2s1gKMgNy jE7EoMVstwFTANEQEysmOca5CEMp6drQlXDUrlyH/cs6EuSwVU3EWibFzab9F3bnJd/qugT1SSy4e 0jn56K9u2yaj9Bb5Lgw0H3Gjnk6KqyrGU3XadX6BA+jFHPDjhSdYlcX854Z8RxugGFs0GkHKSYThg YDjxpBwH0BscBgTYhE/WNfu/+lwemNMV4GDQQq6mk3HSDuNJIm0dF4OQPxcx/kaPJ00ART1jfi3w5 XnGKP78JTsX1k4Vr99OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyVpA-009LBK-0i; Thu, 02 Nov 2023 11:25:20 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyVp7-009LAp-04 for linux-arm-kernel@lists.infradead.org; Thu, 02 Nov 2023 11:25:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698924314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G9+EloQzdVYeoamONcM2Hc+44nMTwaQEa+a85PRBSe4=; b=LQdFt3ZKGdEApjSx/97bjMdIMNvO9Reubs6+q6d/ybk4JUSmqFjxmHQd9RS4HuhaZIHi7Q EBJP0G8XejMPD7A+oa0rFXD8arHVs0zCdgY8fsjK1q7ZG5JtxNldHwUDkL4DKTqmqOSZMf cB4Bp2eyoAGcRypkXsp01/OP4tmy4I0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-T2Z6ORYIOe-iIi9PvkoDtg-1; Thu, 02 Nov 2023 07:25:12 -0400 X-MC-Unique: T2Z6ORYIOe-iIi9PvkoDtg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-66fd88c39f6so2497796d6.0 for ; Thu, 02 Nov 2023 04:25:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698924312; x=1699529112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G9+EloQzdVYeoamONcM2Hc+44nMTwaQEa+a85PRBSe4=; b=gEiarkZsCrnCDdBH5eS1f3R45b0N5iyRcHcK6SQpoI6WNcc0FouLcHjoGpK+WHlnMS QxzsAciupXy7387MwGVFAVEilaC3/Q/1SKPmLf83ZSFut3fay6OblqcBazBXcy3nw9rd 3K2z5yCpIeLUEBeq/S5fhwCmgoziEWkumnDmMf0pnepKMtaK3bngJhwrmKFbIl39JQbk eBNQKgd7zscMds7d7X+wypPHUlbzGS/+QZJE/ZrO2OYEtPtMjY7EwgZvIHLVfN1vPLIk RJogRKy7pwEyuaFoUrFq0vfURQA0BHVrXgLaxJ7Cyz0lPCfYlj4mefw94r4BSFwhiBCn Fo4g== X-Gm-Message-State: AOJu0YzF4eUFg097wKE166rJiPXjPiPuGXli5037CSmhSaJ5jDoWTj9O 1UD2j7AH0gy7reG6uwMP4a9WuCUWO3DUlmJFNoiEfEBaqg9sPeqf/XksSjN4RW7DNuFvgWSrlAc 4M2s8N+iiQIjTQY6SxgS0jHFe8Vej3Q6hQNE= X-Received: by 2002:a05:620a:24c3:b0:76f:27af:2797 with SMTP id m3-20020a05620a24c300b0076f27af2797mr21315836qkn.0.1698924312386; Thu, 02 Nov 2023 04:25:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFT5geDHIolp0aNPY1+MLsvDeWC3teHeCm8p/b1jYgutWDc0LnG9FJFSFJHpLLBT8Z59NWKDA== X-Received: by 2002:a05:620a:24c3:b0:76f:27af:2797 with SMTP id m3-20020a05620a24c300b0076f27af2797mr21315813qkn.0.1698924311978; Thu, 02 Nov 2023 04:25:11 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-226-153.dyn.eolo.it. [146.241.226.153]) by smtp.gmail.com with ESMTPSA id i7-20020a05620a144700b0075ca4cd03d4sm2228731qkl.64.2023.11.02.04.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 04:25:11 -0700 (PDT) Message-ID: <5a265e5541ab1de2258a6e61bd672ef5fb6be65f.camel@redhat.com> Subject: Re: [PATCH] net: stmmac: Wait a bit for the reset to take effect From: Paolo Abeni To: Bernd Edlinger , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Date: Thu, 02 Nov 2023 12:25:07 +0100 In-Reply-To: References: User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_042517_162070_882DE4E8 X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2023-10-30 at 07:01 +0100, Bernd Edlinger wrote: > otherwise the synopsys_id value may be read out wrong, > because the GMAC_VERSION register might still be in reset > state, for at least 1 us after the reset is de-asserted. > > Add a wait for 10 us before continuing to be on the safe side. This looks like a bugfix: you should target explicitly the 'net' tree, adding such tag into the subj. More importantly you should include a suitable 'Fixes' tag. Please send a new revision with the above changes. You can retain the already collected reviewed tags. Thanks, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel