From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8789CC982FF for ; Tue, 22 Sep 2026 08:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nxecp8OUY0Lx57p1dANxfv0uvDW3w9nGB0PrL1gdmKA=; b=MAdjydbLrHfigzYsPsG9XzovEe NMvBO61SwbxEbyLeQ7xE0Q0WToooUbMRJMrM6NTflOy9t1SlaY1iF3cGglQkIjVpu36thej7ykTlc C/VIn03Gt/xcU1PCVkava4pwbHccdVhJSbFaQsGjSypQ+KRE1XsGFkO4AVaZtpKqKHjb5UARnF4E0 TpBOOw4JsIK4tfFZcV3YgNAmOpdib6KnXgwgK0dq+Tz9TAyMGlbmRWswRDxpBOTswkobBWmcuwFGS BHNuG92OkzOQciAqqM2zB52Hy87dKxyFgJ6vmnpwkTdRjGl2hhqgSZNCCi9guBS93PPmSsv/LS2zm 0BhTOdaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8wGZ-00000004mDJ-3brT; Tue, 22 Sep 2026 08:54:19 +0000 Received: from mail-m9371.xmail.ntesmail.com ([103.126.93.71]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8wGV-00000004m8h-0LUu; Tue, 22 Sep 2026 08:54:17 +0000 Received: from [172.16.12.74] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 4eb501a7b; Tue, 22 Sep 2026 16:54:04 +0800 (GMT+08:00) Message-ID: <5a411d61-18f4-4d12-9acf-78320ab97d6b@rock-chips.com> Date: Tue, 22 Sep 2026 16:54:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/19] drm/bridge: analogix_dp: don't create a panel_bridge To: Luca Ceresoli , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang , Laurentiu Palcu , Lucas Stach , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Paul Kocialkowski , Linus Walleij , Inki Dae , Jagan Teki , Marek Szyprowski , Sean Paul , Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: Albert Esteve , Anusha Srivatsa , Dmitry Baryshkov , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Heiko Stuebner References: <20260916-drm-bridge-every-panel-v3-0-83afb4f1a707@bootlin.com> <20260916-drm-bridge-every-panel-v3-19-83afb4f1a707@bootlin.com> <975a4d45-9a61-4858-b498-8bc0a1e44746@rock-chips.com> <96882735-091f-49c6-a47b-5da8be711818@rock-chips.com> Content-Language: en-US From: Damon Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0aa0c8527e9a03a8kunm0c11385e8262e X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCQk8YVh5KTU4fTBpIHUJPSVYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQkxVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=VUMZwH3ZKyjnCH60Goi5U3Vl4nFl+MAx1A1qjQ4sQPJsJELH/axOKlZpuWVXdpUvCCP00441WDmikcC3zP82z6IUPyTAT3cyO6aUOORiTTynOxObIcFhdpn7WhshuvAgZWqwqWeg91ArKUw1BugGOb8+J2UJCAexwN2J2SQ4UZo=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=nxecp8OUY0Lx57p1dANxfv0uvDW3w9nGB0PrL1gdmKA=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260922_015415_629260_5299811E X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/22/2026 4:07 PM, Luca Ceresoli wrote: > Hello Damon, > > On Mon Sep 21, 2026 at 8:34 AM CEST, Damon Ding wrote: >> On 9/21/2026 11:07 AM, Damon Ding wrote: >>> Hi Luca, >>> >>> On 9/16/2026 9:45 PM, Luca Ceresoli wrote: >>>> Now a panel_bridge is automatically created for every drm_panel and the >>>> panel-bridge API is just a deprecated wrapper to access it. >>>> >>>> Update and simplify the code by just getting a reference to the >>>> already-existing bridge using of_drm_get_bridge_by_endpoint(). >>>> >>>> As of_drm_get_bridge_by_endpoint() returns a refcounted bridge, take care >>>> of putting the bridge reference. This is not easily done in the remove >>>> path >>>> due to the different probe paths of the user drivers, so add a devm >>>> action >>>> to ensure the reference is put only when it was taken. >>>> >>>> Assisted-by: opencode:deepseek-v4-flash-0731 >>>> Signed-off-by: Luca Ceresoli >>>> --- >>>>   drivers/gpu/drm/bridge/analogix/Kconfig            |  1 - >>>>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 40 ++++++++++++ >>>> +--------- >>>>   drivers/gpu/drm/exynos/exynos_dp.c                 | 36 + >>>> +----------------- >>>>   drivers/gpu/drm/rockchip/analogix_dp-rockchip.c    |  9 ----- >>>>   include/drm/bridge/analogix_dp.h                   |  1 - >>>>   5 files changed, 25 insertions(+), 62 deletions(-) >>>> >> >> [snip] >> >>>> @@ -488,14 +487,6 @@ static void rockchip_dp_remove(struct >>>> platform_device *pdev) >>>>   { >>>>       struct rockchip_dp_device *dp = platform_get_drvdata(pdev); >> >> The above unused &rockchip_dp_device could be also remved. > > Ah, indeed! > > I guess I can keep your review tags if applying this patch with only this > line removed. Correct? > Yeah, sure! Best regards, Damon