From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E760BC433DB for ; Sat, 20 Feb 2021 19:20:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0A1064E54 for ; Sat, 20 Feb 2021 19:20:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0A1064E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JO7vkxIEbaihMaVBapkcmuDhJLAiZcv+x6U8lBHz9NQ=; b=FZ392t/03lrastz5Lpl0qvshz CIQCFd66BRBC7S6IfHAV7kSg5o+OrJJKz28UG0wsi0aQLoK92BDweDhRLAuekPHapOql6Gc85EZeF 11MxZUAtGS5g9ASNs6yyFN+B5guZDrIvV2pUSoTYH2BCZ3ooQ3hEGYg1PNIKPStEyA0Zmx8Vf2vX2 yOjmYdwzVSuTUHswhF5dDBDmj5Vvv754Raxk0N3i0EG4fq77eeBKswAbp08FzA1JCJpSECg+otpX6 GlQzo4Vq6GTotbruDacDhOTo4UOyjCoyM7CzLIdzH6d+eJRkBZnS1iw8Hi8teGcssJX09udmIx6ty hEniM2YgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXlI-0004SZ-4F; Sat, 20 Feb 2021 19:17:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDXlF-0004Rt-0h for linux-arm-kernel@lists.infradead.org; Sat, 20 Feb 2021 19:17:49 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 416FE61481; Sat, 20 Feb 2021 19:17:47 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lDXlB-00F6Qi-4p; Sat, 20 Feb 2021 19:17:45 +0000 MIME-Version: 1.0 Date: Sat, 20 Feb 2021 19:17:44 +0000 From: Marc Zyngier To: Krzysztof Kozlowski Subject: Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource In-Reply-To: <20210220191323.ugmzrtkvcxyqqolj@kozik-lap> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-21-marcan@marcan.st> <20210215185135.onivzktfscv5myh2@kozik-lap> <20274436-7275-9734-5a07-d6da46b45c5f@marcan.st> <20210220191323.ugmzrtkvcxyqqolj@kozik-lap> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <5a4b3d7095d1ec4be97ec154109632dc@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: krzk@kernel.org, marcan@marcan.st, linux-arm-kernel@lists.infradead.org, robh@kernel.org, arnd@kernel.org, olof@lixom.net, mark.kettenis@xs4all.nl, tony@atomide.com, mohamed.mediouni@caramail.com, stan@corellium.com, graf@amazon.com, will@kernel.org, linus.walleij@linaro.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_141749_190139_8ABD163B X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Arnd Bergmann , Tony Lindgren , Linus Walleij , Hector Martin , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-02-20 19:13, Krzysztof Kozlowski wrote: > On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: >> On 16/02/2021 03.51, Krzysztof Kozlowski wrote: >> > > Also fix a bug checking the return value, which should use IS_ERR(). >> > >> > No, no, no. We never, never combine fixing bugs with some rework. >> > However devm_ioremap() returns NULL so where is the error? >> >> Sorry, this was a commit message mistake. The code is correct and so >> is the >> patch: just the NULL check is correct for the previous variant and >> IS_ERR is >> correct for devm_ioremap_resource. I confused myself while writing the >> commit message after the fact. >> >> > Did you test your patches on existing platforms? If not, please mark all >> > of them as RFT on next submission, so Greg does not pick them too fast. >> >> I unfortunately don't have any Exynos devices where I could test the >> code (I >> have a couple but no serial connections, and I have no idea if mailine >> would >> run on them). I'll mark v3 as RFT. > > If you have one of Odroid boards with Exynos, then you can nicely test > Exynos. Others - depends, on board. > Anyway I can test them for you. I just want to be sure that Greg waits > for this testing. Worse case, QEMU has some Exynos4210 emulation that is usable. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel