From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E928FC433EF for ; Wed, 20 Apr 2022 16:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rYl77XIMEMOo3ApOSScgLo/GHtWM6fpbPCiaA/qIZpk=; b=MhVkmxeNFZczy+P/3c07sjJKV/ k08E9qOKlGqp9/XKRsZ+k8K+6kUYj5OE89PQjp1FkNo9VdK1Ir5U4D+y1dBOsBzzsojzjpDqrjqeP f19jSTnzO3dC/sJ6vyTAE0dmW2nVon8z3Jv80o/v2h/r2hZFnb5VSjyPRjLCEzeAqzfCBlEn1KVhf hh6WBLJ6kLX4lLXxe/+QrjqDzntYoMhsdkIxLCYc1CUOlctlTUcnJ5FAkY96cKwnZkoyDnsThvkii Cf6tDqlsDHbySQkQWtUWuTXF0VZZxF1ogwcWeGuVUJqx+W70lCARpDQpW9b/+4cp9YyW+moXvRvpJ v5DXjo5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhCpU-009dWz-6n; Wed, 20 Apr 2022 16:05:20 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhCpR-009dV7-95 for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 16:05:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5433E1424; Wed, 20 Apr 2022 09:05:13 -0700 (PDT) Received: from [10.57.41.251] (unknown [10.57.41.251]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C9C83F766; Wed, 20 Apr 2022 09:05:10 -0700 (PDT) Message-ID: <5ae51610-5027-777e-36e3-7bdb92e00752@arm.com> Date: Wed, 20 Apr 2022 17:05:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 04/13] iommu/arm-smmu: Clean up bus_set_iommu() Content-Language: en-GB To: Will Deacon References: <2e59602d982fd4941ec923571940fa3c628b2188.1649935679.git.robin.murphy@arm.com> <20220419144042.GA6186@willie-the-truck> From: Robin Murphy In-Reply-To: <20220419144042.GA6186@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_090517_421618_01DD0353 X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe@linaro.org, mjrosato@linux.ibm.com, sven@svenpeter.dev, zhang.lyra@gmail.com, joro@8bytes.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, gerald.schaefer@linux.ibm.com, baolu.lu@linux.intel.com, yong.wu@mediatek.com, m.szyprowski@samsung.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-04-19 15:40, Will Deacon wrote: > On Thu, Apr 14, 2022 at 01:42:33PM +0100, Robin Murphy wrote: >> Stop calling bus_set_iommu() since it's now unnecessary. With device >> probes now replayed for every IOMMU instance registration, the whole >> sorry ordering workaround for legacy DT bindings goes too, hooray! > > Ha, I hope you tested this! Oh alright then, since it's you... :) I've hacked up a Juno DT with the old bindings, and (after needing a while to remember that they're fundamentally incompatible with disable_bypass), can confirm that with my whole dev branch including this series applied, it boots and creates IOMMU groups as expected. I then made the mistake of trying without the branch to check whether the squawks from iommu_setup_dma_ops() were new or not, and... well... plain rc3 doesn't even boot on the same setup - it's somehow blowing up in the failure cleanup path of iommu_bus_init(), apparently calling iommu_release_device() on something where dev->iommu->iommu_dev is NULL, for reasons that are far from clear and I'm not sure I can really be bothered to debug further... :/ Cheers, Robin. >> Signed-off-by: Robin Murphy >> --- >> drivers/iommu/arm/arm-smmu/arm-smmu.c | 84 +-------------------------- >> 1 file changed, 2 insertions(+), 82 deletions(-) > > Assuming it works, > > Acked-by: Will Deacon > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel