From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 645C1C432C2 for ; Thu, 26 Sep 2019 09:26:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3473E222C3 for ; Thu, 26 Sep 2019 09:26:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KH5hJHXz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3473E222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hMcEZjci38uoHATxCONheBlLoZNPBW/PsfzZVsxhJko=; b=KH5hJHXzL5BhGG nEgpd2jm8Eea+3OZkuPI2iKZ1SnnqSQodaD0RA4lIaxcuJ8nB27GFo9sJdTWSdBoe5HF2i9Wt/8aQ rNAsqeT4wvuQ0Oi1efQTD2+hXFLllhBhpe2E8Yv9d00TeVrt0i8BXtc26AFKocsWqZdkldUAYeHxS h5+V/Iy4fPhcRpBc2S8OkmUzHokuJd7cRhWrsa87G4ktvehxrAHFZImVf8XxiIexUJalhqv4GN2hL RNSlR0T7Z6VHC/h51lRIHFJeVjiinLFKNhJ1eYgxVydPxOVYD5UG0OtbYmfJFM66+uggu3Zv48jm9 uuCJOmLAi0V60urRU2uA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDQ2r-0000GP-Lt; Thu, 26 Sep 2019 09:26:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDQ2o-0000Fy-NX for linux-arm-kernel@lists.infradead.org; Thu, 26 Sep 2019 09:26:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F5691000; Thu, 26 Sep 2019 02:26:37 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 842F63F67D; Thu, 26 Sep 2019 02:26:36 -0700 (PDT) Subject: Re: [PATCH 1/2] kselftest: add capability to skip chosen TARGETS To: Tim.Bird@sony.com, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shuah@kernel.org References: <20190925132421.23572-1-cristian.marussi@arm.com> From: Cristian Marussi Message-ID: <5aeaf05c-e5da-458f-45b8-c78094e74eab@arm.com> Date: Thu, 26 Sep 2019 10:26:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190926_022638_809942_6B6B2BBC X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dave.martin@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tim thanks for the review. On 25/09/2019 21:20, Tim.Bird@sony.com wrote: > Just a few nits inline below. > >> -----Original Message----- >> From: Cristian Marussi on Wednesday, September 25, 2019 3:24 AM >> >> Let the user specify an optional TARGETS skiplist through the new optional >> SKIP_TARGETS Makefile variable. >> >> It is easier to skip at will a reduced and well defined list of possibly > > It seems like there's a word missing. > at will a -> at will using a > >> problematic targets with SKIP_TARGETS then to provide a partially stripped > > then -> than > >> down list of good targets using the usual TARGETS variable. >> >> Signed-off-by: Cristian Marussi >> --- >> tools/testing/selftests/Makefile | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/tools/testing/selftests/Makefile >> b/tools/testing/selftests/Makefile >> index 25b43a8c2b15..103936faa46d 100644 >> --- a/tools/testing/selftests/Makefile >> +++ b/tools/testing/selftests/Makefile >> @@ -132,6 +132,10 @@ else >> ARCH=$(ARCH) -C $(top_srcdir) headers_install >> endif >> >> +# User can optionally provide a TARGETS skiplist. >> +SKIP_TARGETS ?= >> +TARGETS := $(filter-out $(SKIP_TARGETS), $(TARGETS)) >> + >> all: khdr >> @for TARGET in $(TARGETS); do \ >> BUILD_TARGET=$$BUILD/$$TARGET; \ >> -- >> 2.17.1 > > Great feature! Thanks. > -- Tim > I'll fix all in V2. Thanks Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel