From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96B21C43217 for ; Sat, 26 Nov 2022 13:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sm8ZgVLM/7g5LhqM8RkzgUM1ANRDptc8jNkrCmTUeJk=; b=hNpJg30/Fq0Gwx G9Om5tHKjIB72C4sg0HGbkDhRqaMdkm3eChTh8KmN+L9etJvOfM3nlnXTa36wOH/Mmc3smyXsD7q9 i1AIHE7+6BWLbbecKcz7seq84eq2TAcP5iTeFQrSD8Th6fRAEjltE4cvxEBYtoIIpnflDF/MDoD2t v4MrcX6weUP1ETQCfUmW/sPFpeA8lWoIACC7kl+qpe11QD8aNRbLfisSUuNaRsRZuQZHym4IcW3B+ ASQqzRQmvX1FMLWvriIUiatx2QfSW0jmcsDUj3OX+hcpQu8SMXcnFrL1nHBZFKcQ22sBQ4mP7S4ke EX/zJfJ30apT+kPNAVbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyvCT-006Kyl-Ju; Sat, 26 Nov 2022 13:26:33 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyvCR-006Kw6-1d for linux-arm-kernel@lists.infradead.org; Sat, 26 Nov 2022 13:26:32 +0000 Received: by mail-lj1-x22c.google.com with SMTP id bn5so8064094ljb.2 for ; Sat, 26 Nov 2022 05:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o4HSsW8BSppm65SzOgKkp1ueBN0+yQmM4nOdtdewie4=; b=fQ948lgQWtUyPvTbVqFz9q/GMnUuxAq/xfBCHkJL16BWRoGwSi7N3Ll1/vKlrlTWf1 LN96gsqTnvCQpGN5YjYG10xuR+YaL9zM4L9WUOz8Xvv/hqroWL6TL3HT309cLxm2/KBG eCLfmz7owAKXhMPNkUHj3S0eRZidLboTGGrQwNMJE7IkX0/mvqgGT/rW5cwGPyNDqE7l ghJ5zdtCgdSttJXsAZjStUGWjArFUF3kjd7WbsSD6HxDO++Jp1lZM81h3ML1cpov6FmI 82K6z1t3VYJgrwpxQfkNtIMovDVq3xdq/yyUPZ01D40tY1sWMoYYT774LPidZ0QcrhD/ rlFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o4HSsW8BSppm65SzOgKkp1ueBN0+yQmM4nOdtdewie4=; b=2QoyE6S3HizbtU7+jGjdnFKh48sJ4gkNJwP+gjA/+FjpqeBnzlsEnZSjb3kMMp7Nc6 DTpGdBwtCQFy68p+zLJ+9bjyNmkvVhxiJGIP5vT9n/SFNnZdnu+ifzWO7SN5p2j2FyR4 RLT9mVURwfi65i39QDM8Y05mcU+Yf0GWMC3mQxfn9OVXFnhl6F/QK+PlcOqdW13sgAqh uPCTTihY6UCGZ0HHVZnQKOz8Y1yEb3u8QC1Nl73Y5odNyQbjLHyv/ue4RI5S7EsxiPoM VB+NyHi47ft88ApWzzL3I2kBHL9H6S2DNbV8uzkW8CLyRrABce5uXaPVrw2RkRsd/I1P 4rTg== X-Gm-Message-State: ANoB5pnPslDolOaMnLKtiYSYSnCy0C/520TF34VWUWlYVZmXYJapA3wV pCyOL8ViQM96qNCH97hZui5vsQ== X-Google-Smtp-Source: AA0mqf4diqUCufc5o5ynb6ePA7iRhvGzndvX4FgyVTV8biyv9XJ3eZhD7JtIGLRQ2Y+XGxyaz98WZg== X-Received: by 2002:a05:651c:11c1:b0:279:7b1c:9add with SMTP id z1-20020a05651c11c100b002797b1c9addmr5996583ljo.151.1669469187372; Sat, 26 Nov 2022 05:26:27 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id y30-20020a0565123f1e00b004a2386b8cf9sm931748lfa.206.2022.11.26.05.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 05:26:26 -0800 (PST) Message-ID: <5b05317d-28cc-bfc8-f415-e6acf453dc7c@linaro.org> Date: Sat, 26 Nov 2022 14:26:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/3] dt-bindings: net: sun8i-emac: Fix snps,dwmac.yaml inheritance Content-Language: en-US To: Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski Cc: LABBE Corentin , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org References: <20221125202008.64595-1-samuel@sholland.org> <20221125202008.64595-3-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20221125202008.64595-3-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221126_052631_118984_8895277D X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/11/2022 21:20, Samuel Holland wrote: > The sun8i-emac binding extends snps,dwmac.yaml, and should accept all > properties defined there, including "mdio", "resets", and "reset-names". > However, validation currently fails for these properties because the validation does not fail: make dt_binding_check -> no problems Maybe you meant that DTS do not pass dtbs_check? > local binding sets "unevaluatedProperties: false", and snps,dwmac.yaml > is only included inside an allOf block. Fix this by referencing > snps,dwmac.yaml at the top level. There is nothing being fixed here... > > Signed-off-by: Samuel Holland > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > index 1432fda3b603..34a47922296d 100644 > --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml > @@ -10,6 +10,8 @@ maintainers: > - Chen-Yu Tsai > - Maxime Ripard > > +$ref: "snps,dwmac.yaml#" > + > properties: > compatible: > oneOf: > @@ -60,7 +62,6 @@ required: > - syscon > > allOf: > - - $ref: "snps,dwmac.yaml#" > - if: > properties: > compatible: Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel