Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Judith Mendez <jm@ti.com>, Srinivas Kandagatla <srini@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] Support AM62P silicon revision detection via uniphier-efuse
Date: Tue, 1 Sep 2026 13:08:29 +0900	[thread overview]
Message-ID: <5b147a60-4d4d-4048-ab52-b5d956b68881@socionext.com> (raw)
In-Reply-To: <20260812154442.3379851-1-jm@ti.com>

Hi Judith,

Sorry for late.

On 2026/08/13 0:44, Judith Mendez wrote:
> This series adds support for reading AM62P silicon revision from the
> efuse GP_SW register. The solution reuses the  existing uniphier-efuse
> driver by adding ti,am62p-efuse as a compatible string. The three patches
> update the devicetree binding to document the new compatible, configure
> the driver as mandatory builtin for K3 architectures, and extend the
> driver
> to support AM62P devices. The uniphier-efuse driver is simple enough to be
> reused for efuse register reads on the AM62P SoC.

Reusing the uniphier-efuse driver seems reasonable to me.

The driver is already fairly generic, and contains no arch-specific elements
that would justify introducing a dedicated driver at this point.

> Feedback is welcome on whether reusing the uniphier-efuse driver is the
> preferred solution or if a dedicated AM62P efuse driver would be more
> appropriate.
> 
> Patches have been tested on AM62p SK hardware using SR1.0, SR1.1 and SR1.2
> silicon.

Provided the functionality has been validated on the target hardware,
I would prefer to reuse the driver rather than write another similar driver.

Thank you,

---
Best Regards
Kunihiko Hayashi


      parent reply	other threads:[~2026-09-01  4:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 15:44 [RFC PATCH 0/3] Support AM62P silicon revision detection via uniphier-efuse Judith Mendez
2026-08-12 15:44 ` [RFC PATCH 1/3] dt-bindings: nvmem: uniphier-efuse: Add ti,am62p-efuse compatible Judith Mendez
2026-08-12 15:44 ` [RFC PATCH 2/3] nvmem: uniphier-efuse: Enable for K3 SoCs Judith Mendez
2026-08-12 15:44 ` [RFC PATCH 3/3] nvmem: uniphier-efuse: Add ti,am62p-efuse compatible Judith Mendez
2026-09-01  4:08 ` Kunihiko Hayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b147a60-4d4d-4048-ab52-b5d956b68881@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jm@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox