* [PATCH v4 0/2] support PWM for exynosautov9 [not found] <CGME20230717094721epcas2p238ffd2f218899dc3c43f3fe68a079c54@epcas2p2.samsung.com> @ 2023-07-17 9:42 ` Jaewon Kim [not found] ` <CGME20230717094721epcas2p1c5c1254e24d4a1d0fb366e1b4d551536@epcas2p1.samsung.com> [not found] ` <CGME20230717094722epcas2p4408dc5ab0aca55e1da1a9eafdd3486f7@epcas2p4.samsung.com> 0 siblings, 2 replies; 6+ messages in thread From: Jaewon Kim @ 2023-07-17 9:42 UTC (permalink / raw) To: Thierry Reding, Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc, Jaewon Kim Add pwm nodes to support PWM fan on exynosautov9-sadk board. --- Changes in v4: - add document file. Changes in v3: - removed adding compatible to driver. Changes in v2: - add compatible string to driver. Jaewon Kim (2): dt-bindings: pwm: samsung: add exynosautov9 compatible arm64: dts: exynos: add pwm node for exynosautov9-sadk .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------ arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++ arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ 3 files changed, 26 insertions(+), 6 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20230717094721epcas2p1c5c1254e24d4a1d0fb366e1b4d551536@epcas2p1.samsung.com>]
* [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible [not found] ` <CGME20230717094721epcas2p1c5c1254e24d4a1d0fb366e1b4d551536@epcas2p1.samsung.com> @ 2023-07-17 9:42 ` Jaewon Kim 2023-07-17 10:59 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Jaewon Kim @ 2023-07-17 9:42 UTC (permalink / raw) To: Thierry Reding, Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc, Jaewon Kim Add samsung,exynosautov9-pwm compatible string to binding document. Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> --- .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml index fe603fb1b2cc..6f65e2b52f52 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml @@ -20,12 +20,16 @@ description: |+ properties: compatible: - enum: - - samsung,s3c2410-pwm # 16-bit, S3C24xx - - samsung,s3c6400-pwm # 32-bit, S3C64xx - - samsung,s5p6440-pwm # 32-bit, S5P64x0 - - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs - - samsung,exynos4210-pwm # 32-bit, Exynos + oneOf: + - const: samsung,s3c2410-pwm # 16-bit + - const: samsung,s3c6400-pwm # 32-bit, S3C64xx + - const: samsung,s5p6440-pwm # 32-bit, S5P64x0 + - const: samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs + - const: samsung,exynos4210-pwm # 32-bit, Exynos + - items: + - enum: + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9 + - const: samsung,exynos4210-pwm reg: maxItems: 1 -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible 2023-07-17 9:42 ` [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible Jaewon Kim @ 2023-07-17 10:59 ` Krzysztof Kozlowski 2023-07-17 11:26 ` Jaewon Kim 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-07-17 10:59 UTC (permalink / raw) To: Jaewon Kim, Thierry Reding, Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc On 17/07/2023 11:42, Jaewon Kim wrote: > Add samsung,exynosautov9-pwm compatible string to binding document. > > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > --- > .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml > index fe603fb1b2cc..6f65e2b52f52 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml > @@ -20,12 +20,16 @@ description: |+ > > properties: > compatible: > - enum: > - - samsung,s3c2410-pwm # 16-bit, S3C24xx > - - samsung,s3c6400-pwm # 32-bit, S3C64xx > - - samsung,s5p6440-pwm # 32-bit, S5P64x0 > - - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs > - - samsung,exynos4210-pwm # 32-bit, Exynos > + oneOf: > + - const: samsung,s3c2410-pwm # 16-bit > + - const: samsung,s3c6400-pwm # 32-bit, S3C64xx > + - const: samsung,s5p6440-pwm # 32-bit, S5P64x0 > + - const: samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs > + - const: samsung,exynos4210-pwm # 32-bit, Exynos These are still an enum. > + - items: > + - enum: > + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9 Let's drop the comment? > + - const: samsung,exynos4210-pwm > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible 2023-07-17 10:59 ` Krzysztof Kozlowski @ 2023-07-17 11:26 ` Jaewon Kim 2023-07-17 12:22 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Jaewon Kim @ 2023-07-17 11:26 UTC (permalink / raw) To: Krzysztof Kozlowski, Thierry Reding, Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc On 23. 7. 17. 19:59, Krzysztof Kozlowski wrote: > On 17/07/2023 11:42, Jaewon Kim wrote: >> Add samsung,exynosautov9-pwm compatible string to binding document. >> >> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> >> --- >> .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >> index fe603fb1b2cc..6f65e2b52f52 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >> @@ -20,12 +20,16 @@ description: |+ >> >> properties: >> compatible: >> - enum: >> - - samsung,s3c2410-pwm # 16-bit, S3C24xx >> - - samsung,s3c6400-pwm # 32-bit, S3C64xx >> - - samsung,s5p6440-pwm # 32-bit, S5P64x0 >> - - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >> - - samsung,exynos4210-pwm # 32-bit, Exynos >> + oneOf: >> + - const: samsung,s3c2410-pwm # 16-bit >> + - const: samsung,s3c6400-pwm # 32-bit, S3C64xx >> + - const: samsung,s5p6440-pwm # 32-bit, S5P64x0 >> + - const: samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >> + - const: samsung,exynos4210-pwm # 32-bit, Exynos > These are still an enum. Okay I will change const to enum. > >> + - items: >> + - enum: >> + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9 > Let's drop the comment? Should I just delete this comment or delete all comments in the enum(16-bit,S3C24xx, .....). > >> + - const: samsung,exynos4210-pwm >> > Best regards, > Krzysztof > > Thanks Jaewon Kim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible 2023-07-17 11:26 ` Jaewon Kim @ 2023-07-17 12:22 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-07-17 12:22 UTC (permalink / raw) To: Jaewon Kim, Thierry Reding, Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc On 17/07/2023 13:26, Jaewon Kim wrote: > > On 23. 7. 17. 19:59, Krzysztof Kozlowski wrote: >> On 17/07/2023 11:42, Jaewon Kim wrote: >>> Add samsung,exynosautov9-pwm compatible string to binding document. >>> >>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> >>> --- >>> .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------ >>> 1 file changed, 10 insertions(+), 6 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> index fe603fb1b2cc..6f65e2b52f52 100644 >>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> @@ -20,12 +20,16 @@ description: |+ >>> >>> properties: >>> compatible: >>> - enum: >>> - - samsung,s3c2410-pwm # 16-bit, S3C24xx >>> - - samsung,s3c6400-pwm # 32-bit, S3C64xx >>> - - samsung,s5p6440-pwm # 32-bit, S5P64x0 >>> - - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >>> - - samsung,exynos4210-pwm # 32-bit, Exynos >>> + oneOf: >>> + - const: samsung,s3c2410-pwm # 16-bit >>> + - const: samsung,s3c6400-pwm # 32-bit, S3C64xx >>> + - const: samsung,s5p6440-pwm # 32-bit, S5P64x0 >>> + - const: samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >>> + - const: samsung,exynos4210-pwm # 32-bit, Exynos >> These are still an enum. > Okay I will change const to enum. >> >>> + - items: >>> + - enum: >>> + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9 >> Let's drop the comment? > > Should I just delete this comment or delete all comments in the > enum(16-bit,S3C24xx, .....). No, the other can stay. Here it is redundant, since Autov9 is obvious - comes from compatible - and rest is coming from compatibility with older models. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20230717094722epcas2p4408dc5ab0aca55e1da1a9eafdd3486f7@epcas2p4.samsung.com>]
* [PATCH v4 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk [not found] ` <CGME20230717094722epcas2p4408dc5ab0aca55e1da1a9eafdd3486f7@epcas2p4.samsung.com> @ 2023-07-17 9:42 ` Jaewon Kim 0 siblings, 0 replies; 6+ messages in thread From: Jaewon Kim @ 2023-07-17 9:42 UTC (permalink / raw) To: Thierry Reding, Uwe Kleine-König, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: linux-pwm, devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc, Jaewon Kim Add pwm node to support fan on exynosautov9-sadk board. PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling in SADK board. Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> --- arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts | 6 ++++++ arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 10 ++++++++++ 2 files changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts index 101f51bf565a..bc1815f6ada2 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts @@ -49,6 +49,12 @@ }; }; +&pwm { + pinctrl-names = "default"; + pinctrl-0 = <&pwm_tout3>; + status = "okay"; +}; + &serial_0 { pinctrl-0 = <&uart0_bus_dual>; status = "okay"; diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index d3c5cdeff47f..3b906f4db907 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -1560,6 +1560,16 @@ samsung,syscon-phandle = <&pmu_system_controller>; samsung,cluster-index = <1>; }; + + pwm: pwm@103f0000 { + compatible = "samsung,exynosautov9-pwm", + "samsung,exynos4210-pwm"; + reg = <0x103f0000 0x100>; + samsung,pwm-outputs = <0>, <1>, <2>, <3>; + #pwm-cells = <3>; + clocks = <&xtcxo>; + clock-names = "timers"; + }; }; }; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-17 12:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20230717094721epcas2p238ffd2f218899dc3c43f3fe68a079c54@epcas2p2.samsung.com>
2023-07-17 9:42 ` [PATCH v4 0/2] support PWM for exynosautov9 Jaewon Kim
[not found] ` <CGME20230717094721epcas2p1c5c1254e24d4a1d0fb366e1b4d551536@epcas2p1.samsung.com>
2023-07-17 9:42 ` [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible Jaewon Kim
2023-07-17 10:59 ` Krzysztof Kozlowski
2023-07-17 11:26 ` Jaewon Kim
2023-07-17 12:22 ` Krzysztof Kozlowski
[not found] ` <CGME20230717094722epcas2p4408dc5ab0aca55e1da1a9eafdd3486f7@epcas2p4.samsung.com>
2023-07-17 9:42 ` [PATCH v4 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk Jaewon Kim
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).