From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC24C282C0 for ; Wed, 23 Jan 2019 12:12:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACF2020861 for ; Wed, 23 Jan 2019 12:12:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="USUjnIFS"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="oAGLcM2S"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="oAGLcM2S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACF2020861 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cycek5KvAu6TljTSlPPXVn3AHRlSHwm2I5e/A40YKkM=; b=USUjnIFSKbibF46KlUjCgmM2O 4WW6ngdpwSVJ7YCWP8iN44jcK0ggJ0OioccC0Kcr2u5q+XoVT0Co/UBgOD6IcM1hT/pqv6RwGQj9B IrpKuVRAhkoUrscqCca3FthR0gh2vz1YRbSN6foxBtY7ukb83gjdvp8uDB8zf8SYH+QMqmFVixPcM lbWj2GwIK9aQp2/g+5iEtBLvyxzNgdkzGQufpEXhhMN3TugQGv7MSMQy5VE5jPeseZbZMHyRJUxFu zIH/qXz5A9rYXvqniOhZbXJ0NCi99krLCpuN+B5mlMRQawdU26fhl2pW9GIbuDFqmJtvJnszZ+QlJ SiM8Gh+OQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmHO9-0004ci-5C; Wed, 23 Jan 2019 12:12:13 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmHO2-0004c1-DJ for linux-arm-kernel@lists.infradead.org; Wed, 23 Jan 2019 12:12:11 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C78E1602BA; Wed, 23 Jan 2019 12:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548245525; bh=TOwqByPOK0JcqDzIL0TmrrT3a7x2WZU8v1t4RkS0TnM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=oAGLcM2SANEZaUiyEp/kv9ys321vLR2E8Or16hna5DCgNXLQwOaRzFMfuKfRtrRdi Vtddcb3Lj7/vZGOjuhantWkhbpeyWAicbN6KbJuOvYwJ7ZSqjkQ4sGSCA/NlJ2JKzh 2vnT9y3tGds/QO2u8Zs9XwQElyvACqeRyg7V67zM= Received: from [10.79.129.250] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D1798602BA; Wed, 23 Jan 2019 12:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548245525; bh=TOwqByPOK0JcqDzIL0TmrrT3a7x2WZU8v1t4RkS0TnM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=oAGLcM2SANEZaUiyEp/kv9ys321vLR2E8Or16hna5DCgNXLQwOaRzFMfuKfRtrRdi Vtddcb3Lj7/vZGOjuhantWkhbpeyWAicbN6KbJuOvYwJ7ZSqjkQ4sGSCA/NlJ2JKzh 2vnT9y3tGds/QO2u8Zs9XwQElyvACqeRyg7V67zM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D1798602BA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org Subject: Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support To: Suzuki K Poulose , robh+dt@kernel.org, mathieu.poirier@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, andy.gross@linaro.org, david.brown@linaro.org, vivek.gautam@codeaurora.org, dianders@chromium.org, sboyd@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, mark.rutland@arm.com References: <1bd39862-0725-70ce-6535-fdb59569f683@arm.com> <75ed74af-6946-b86d-092e-42dc16e55308@codeaurora.org> <91a90daa-9e14-2d2e-e633-2ddfdc0955bf@arm.com> <3906faf1-abbd-9c28-ad55-ed3800f06352@codeaurora.org> From: Sai Prakash Ranjan Message-ID: <5b54c6e0-7d22-ecee-486f-31333f49f84a@codeaurora.org> Date: Wed, 23 Jan 2019 17:41:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190123_041206_485416_FD842AE1 X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rnayak@codeaurora.org, linux-arm-msm@vger.kernel.org, john.horley@arm.com, linux-kernel@vger.kernel.org, sibis@codeaurora.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On 1/23/2019 1:42 AM, Suzuki K Poulose wrote: > Hi Sai, > > On 01/22/2019 04:48 PM, Sai Prakash Ranjan wrote: >> Hi Suzuki, >> [..] >> >> SDM845 has 4 Kryo 385 Gold (ARM A75) + 4 Kryo 385 Silver (ARM A55), >> so the PID values should be same for 4 ETMs atleast. But here one >> pid value(001bb803) is same for 6 ETMs and other one for 2 >> ETMs(001bb802) which seems odd and hence the doubt if these pids >> are even valid ones. > > Have you checked other SoCs with A55 for the ETM PID ? The drivers > usually only care about PID0[7-0], PID1[7-0], PID2[3-0] and ignores > the other fields that may change over revisions of the core. So, in your > case the ETM ID could be treated as 0xbb802 and 0xbb803. > Very sorry to have mislead you here. I checked again today on SDM845 and as you said 4 ETMs based on A75 has 0xbb803 and other 4 ETMs based on A55 has 0Xbb803. I wrongly mentioned it as 6 and 2. [ 6.688809] resname=etm@7040000 pid = 0x1bb803 [ 6.694957] [ 6.694957] resname=etm@7140000 pid = 0x1bb803 [ 6.701135] [ 6.701135] resname=etm@7240000 pid = 0x1bb803 [ 6.707256] [ 6.707256] resname=etm@7340000 pid = 0x1bb803 [ 6.713454] [ 6.713454] resname=etm@7440000 pid = 0x1bb802 [ 6.719621] [ 6.719621] resname=etm@7540000 pid = 0x1bb802 [ 6.725814] [ 6.725814] resname=etm@7640000 pid = 0x1bb802 [ 6.731971] [ 6.731971] resname=etm@7740000 pid = 0x1bb802 So is it ok to add these to table as below in etm4x driver with the following comment since these do not exactly match A75 and A55 PIDs which you provided? Or any other way you prefer? @@ -1079,6 +1079,10 @@ static const struct amba_id etm4_ids[] = { ETM4x_AMBA_ID(0x000bb95a), /* Cortex-A72 */ ETM4x_AMBA_ID(0x000bb959), /* Cortex-A73 */ ETM4x_AMBA_ID(0x000bb9da), /* Cortex-A35 */ + ETM4x_AMBA_ID(0x000f0211), /* Qualcomm Kryo */ + ETM4x_AMBA_ID(0x000f0205), /* Qualcomm Kryo */ + ETM4x_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */ + ETM4x_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */ {}, }; For msm8996, cpu debug module pid returned is same as ETM which is causing the probe failure for cpu debug coresight module as shown in below logs. For this case, I tried adding these ids to cpu debug driver, but it splits some errors (coresight-cpu-debug: probe of 3840000.etm failed with error -16) since the ids are same. Can we override for this case or there is something else we can do here? [ 5.480629] resname=debug@3810000 pid = 0x102f0211 [ 5.480920] OF: graph: no port node found in /soc/debug@3810000 [ 5.513214] coresight-etm4x: probe of 3810000.debug failed with error -22 [ 5.524362] [ 5.524362] resname=debug@3910000 pid = 0x102f0211 [ 5.524888] OF: graph: no port node found in /soc/debug@3910000 [ 5.537586] coresight-etm4x: probe of 3910000.debug failed with error -22 [ 5.541481] [ 5.549643] resname=debug@3a10000 pid = 0x102f0205 [ 5.580990] OF: graph: no port node found in /soc/debug@3a10000 [ 5.586817] coresight-etm4x: probe of 3a10000.debug failed with error -22 [ 5.592082] [ 5.592629] resname=debug@3b10000 pid = 0x102f0205 [ 5.604922] OF: graph: no port node found in /soc/debug@3b10000 [ 5.611234] coresight-etm4x: probe of 3b10000.debug failed with error -22 Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel