Re: [PATCH] soc: mediatek: mtk-socinfo Add error handling in devm_kasprintf()

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

On 7/9/26 15:24, Griffin Kroah-Hartman wrote:
> Add an error check to the devm_kasprintf() function in
> mtk_socinfo_create_socinfo_node(), returning -ENOMEM if the function
> failed.
> 
> Assisted-by: gkh_clanker_t1000
> CC: Matthias Brugger <matthias.bgg@gmail.com>
> CC: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Griffin Kroah-Hartman <griffin@kroah.com>

Yeah, makes sense.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   drivers/soc/mediatek/mtk-socinfo.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-socinfo.c b/drivers/soc/mediatek/mtk-socinfo.c
> index 424a1eb82c20..e294730ba709 100644
> --- a/drivers/soc/mediatek/mtk-socinfo.c
> +++ b/drivers/soc/mediatek/mtk-socinfo.c
> @@ -76,11 +76,14 @@ static int mtk_socinfo_create_socinfo_node(struct mtk_socinfo *mtk_socinfop)
>   	if (!attrs)
>   		return -ENOMEM;
>   
> -	if (data->marketing_name != NULL && data->marketing_name[0] != '\0')
> +	if (data->marketing_name != NULL && data->marketing_name[0] != '\0') {
>   		attrs->family = devm_kasprintf(mtk_socinfop->dev, GFP_KERNEL, "MediaTek %s",
>   					       data->marketing_name);
> -	else
> +		if (!attrs->family)
> +			return -ENOMEM;
> +	} else {
>   		attrs->family = soc_manufacturer;
> +	}
>   
>   	attrs->soc_id = data->soc_name;
>   	/*