From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
To: Haoyu Lu <hechushiguitu666@gmail.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Len Brown <lenb@kernel.org>,
Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] acpi: arm64: agdi: fix missing newline in error message
Date: Tue, 31 Mar 2026 18:13:58 -0700 (PDT) [thread overview]
Message-ID: <5b7727e1-45d1-7f5e-97da-43d3af905f40@os.amperecomputing.com> (raw)
In-Reply-To: <20260331025257.463-1-hechushiguitu666@gmail.com>
On Tue, 31 Mar 2026, Haoyu Lu wrote:
> Add the missing trailing newline to the dev_err() message
> printed when SDEI event registration fails.
>
> This keeps the error output as a properly terminated log line.
>
> Fixes: a2a591fb76e6f5461dfd04715b69c317e50c43a5 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")
> Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
Thanks for the patch.
Would you mind changing the prefix on the subject line to match the
previous patches? That is, change it to "ACPI: AGDI: ....".
With that change
Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Cheers, Ilkka
> ---
> drivers/acpi/arm64/agdi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c
> index feb4b2cb4618..0c2d9d6c160b 100644
> --- a/drivers/acpi/arm64/agdi.c
> +++ b/drivers/acpi/arm64/agdi.c
> @@ -36,7 +36,7 @@ static int agdi_sdei_probe(struct platform_device *pdev,
>
> err = sdei_event_register(adata->sdei_event, agdi_sdei_handler, pdev);
> if (err) {
> - dev_err(&pdev->dev, "Failed to register for SDEI event %d",
> + dev_err(&pdev->dev, "Failed to register for SDEI event %d\n",
> adata->sdei_event);
> return err;
> }
> --
> 2.17.1
>
>
prev parent reply other threads:[~2026-04-01 1:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 2:52 [PATCH 1/2] acpi: arm64: agdi: fix missing newline in error message Haoyu Lu
2026-04-01 1:13 ` Ilkka Koskinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b7727e1-45d1-7f5e-97da-43d3af905f40@os.amperecomputing.com \
--to=ilkka@os.amperecomputing.com \
--cc=catalin.marinas@arm.com \
--cc=guohanjun@huawei.com \
--cc=hechushiguitu666@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=rafael@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sudeep.holla@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox