From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7059C4332F for ; Tue, 12 Dec 2023 20:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UWPNCyQBsMIAg8DSf4DuHx66udaVye/CwAfAjlIrA2M=; b=qRjFewnlXkanFN /VTzrw7po3XoEWSV7j5I6dLhOo3ndUvalMHvrB9cnh6ottDxCspumNZ4oQt/rqFBmQQ40UX5X84Qb dRM2i5EiO+daSwuLdx4lyo7eA9ugZeQZ30joJQlgHFjeLcTAEdKorYSXSK+/n83Qay+hT2IKl6Mby eB0iFTyutJFiENoWlNOCxHYH0T5yjxO7SPMOAfpgi26s2j7zp+HcVEuCvqHMq/vqS8cyFn09Gupr2 aR1QXttEXN9jaWAAJE175PrtNgkbBjGu3BTVMu5bgBQBnvBG4YzXR1aXAKMd0YnNwpajnVa5ENwkE bxknvih9tVsonNEIeuaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD9Kx-00ChkD-2n; Tue, 12 Dec 2023 20:26:39 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD9Kv-00Chi9-0h for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 20:26:38 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40c48d7a7a7so21426555e9.3 for ; Tue, 12 Dec 2023 12:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702412795; x=1703017595; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hgxv7EF4Irll71B8Hw+ZNuQf2aAKASeN0rbDIOWc5pE=; b=e9q7AOTh+346r28AHPeDuGEJMYNTqYRODAOpfxBTBfxm32WT5eFRLZSByl/8WKIa7j sF61svQAe32Wzw59aqIhGzqGrHZhsxq1oz4Iy4+Jr+cZThJiColR2A+7QZxK2Z9v44yh FxRfUehRMiCXFGffoVz4PdfcIs8qfZh3BuCkDaxq44Vt3671RHr45CykaUfxn5OTd7Ef za5i1GcFSkVxBlhKvHUNcU/lgSpwSdVxhEoNY1OmutwLw2BjyEVqXyy/msL7Rd+zAIHs xbwf2WIEgOSTTnBuATXd1F3W6aYWcxoxP5SNHhpHhhI4bUeATXSXyRPKP2IQ6qoodIu/ NtKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702412795; x=1703017595; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hgxv7EF4Irll71B8Hw+ZNuQf2aAKASeN0rbDIOWc5pE=; b=ItTmQoiTzgcaU+UH5yBzFHDFvxeabD9BuyqvdVcFQ4MjQwhjUIzuisxrPJ5cFwVuSs NDZxFiPYpfTj35W20sKvVDY70VZlf1ndNpUgSj44m84y5k7OEiZHgBTVNnmdEW5rkFan B4Bxi4ly3Y46IaUCesqAuiAc38LNb3Y1fYWYScG6M6FD7mi+CUpQJi0w9Jz0d9xPxi+Y Vuv8jJxBlk063qPRxFMclD8bCsgQavx4sqIHWEFHVpVbbxit+ZmTkQVzKByd8dfnppiz oaulPWu0bq/juv3StmTGDqOTgauhhDMXp0xTbGVfcTEbvsAH5owHEc+uNZCaXw4kRgMJ WUSQ== X-Gm-Message-State: AOJu0YzLPXIZww75PEbikOimU45SmATIka1bCzPnWTvwxqwXw4am3QjI UkWBL4A7qXrnB+vVxWzAuMQ2mg== X-Google-Smtp-Source: AGHT+IGWv/YdluhtwVphE7CoDTj82BpgPHXdubShtukPi5QX8GCQ6dewT+kR6iaFEQFQPaMMh7Vcgw== X-Received: by 2002:a7b:c3d8:0:b0:40c:3820:eff0 with SMTP id t24-20020a7bc3d8000000b0040c3820eff0mr3489292wmj.105.1702412795584; Tue, 12 Dec 2023 12:26:35 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id w6-20020a5d6806000000b00336103442d2sm10177965wru.76.2023.12.12.12.26.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 12:26:35 -0800 (PST) Message-ID: <5b98538a-8ffe-42ec-b020-514dcfcebba3@linaro.org> Date: Tue, 12 Dec 2023 21:26:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more Content-Language: en-US To: Ninad Palsule , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, johannes.holland@infineon.com, linux@roeck-us.net, broonie@kernel.org Cc: patrick.rudolph@9elements.com, vincent@vtremblay.dev, peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com, bhelgaas@google.com, naresh.solanki@9elements.com, alexander.stein@ew.tq-group.com, festevam@denx.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org, geissonator@yahoo.com References: <20231212164004.1683589-1-ninad@linux.ibm.com> <20231212164004.1683589-9-ninad@linux.ibm.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231212164004.1683589-9-ninad@linux.ibm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_122637_259902_37B86734 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/12/2023 17:40, Ninad Palsule wrote: > This drop adds following devices in the device tree. > - EEPROM/VPD > - Power supplies > - Humidity, pressure and temperature sensors. > - Trusted platform module(TPM) chip > > Tested: > This board is tested using the simics simulator. > > Signed-off-by: Ninad Palsule > --- Don't mix DTS with drivers. DTS and drivers go via different subsystems and cannot have dependencies, so why DTS is patch #6, then driver #7 and now again DTS #7? > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > index 75562aa63701..d960b938fe8d 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > @@ -461,6 +461,11 @@ &kcs3 { > &i2c0 { > status = "okay"; > > + eeprom@50 { > + compatible = "atmel,24c64"; > + reg = <0x50>; > + }; > + > regulator@60 { > compatible = "maxim,max8952"; > reg = <0x60>; > @@ -655,6 +660,25 @@ pca0: pca9539@74 { > > &i2c2 { > status = "okay"; > + > + power-supply@58 { > + compatible = "ibm,cffps"; > + reg = <0x58>; > + }; > + > + power-supply@59 { > + compatible = "ibm,cffps"; > + reg = <0x59>; > + }; > + > + power-supply@5a { > + compatible = "ibm,cffps"; > + reg = <0x5a>; > + }; Missing blank line > + power-supply@5b { > + compatible = "ibm,cffps"; > + reg = <0x5b>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel