From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 336DAC43334 for ; Wed, 13 Jul 2022 11:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dHivJTQvDf0qs6UR/7nNAT4RcU3KIMgyJOWIPUt7GQw=; b=tKfoMxwG3emYVJ BAJnTo4x417aZiYIfw/6v5K9y/lthrAQp6WlN4Y1hVxIiXvaFD8fuFVDL+y9K3p/810SbEwWK1RZp +1Ic2LKRYhKVw03DhV1UNWTcqxnvAgrHTIczZHJ+nJ2b3NKwJL1AQ3Wbt3PgufZ5sMzIvvUHh4Su/ clIuJuLSptncfEMLsWoBEnfPrg6WX8r6pMiX8+FWxyoeNKGcbTTz8pdui43NWq3ZECYRB5bzTSA+F sCc/CejEVnJkLnI9TmZWTNQlMizeN8GbivkmzLQUU5bIEvFeiwb4oymMnZECpfJZvoiqIe14nbrev HMTNpudjHA9nlQyAEZYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBaOB-0032Y4-DR; Wed, 13 Jul 2022 11:18:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBaNB-0031an-4u for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 11:17:43 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBaMw-00045N-ID; Wed, 13 Jul 2022 13:17:26 +0200 Message-ID: <5bb33ccf17f89cd398342922af6fd7a04f015c07.camel@pengutronix.de> Subject: Re: [PATCH v14 14/17] PCI: imx6: Do not hide phy driver callbacks and refine the error handling From: Lucas Stach To: Hongxing Zhu , "bhelgaas@google.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "lorenzo.pieralisi@arm.com" , "festevam@gmail.com" , "francesco.dolcini@toradex.com" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" , dl-linux-imx Date: Wed, 13 Jul 2022 13:17:24 +0200 In-Reply-To: References: <1656645935-1370-1-git-send-email-hongxing.zhu@nxp.com> <1656645935-1370-15-git-send-email-hongxing.zhu@nxp.com> <4f49f28d15ad859e34aeeb714b5ddd5d6eba4b4a.camel@pengutronix.de> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220713_041741_247940_393BDF6A X-CRM114-Status: GOOD ( 27.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gTWl0dHdvY2gsIGRlbSAxMy4wNy4yMDIyIHVtIDEwOjU3ICswMDAwIHNjaHJpZWIgSG9uZ3hp bmcgWmh1Ogo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEx1Y2FzIFN0 YWNoIDxsLnN0YWNoQHBlbmd1dHJvbml4LmRlPgo+ID4gU2VudDogMjAyMuW5tDfmnIgxM+aXpSAx Njo1OQo+ID4gVG86IEhvbmd4aW5nIFpodSA8aG9uZ3hpbmcuemh1QG54cC5jb20+OyBiaGVsZ2Fh c0Bnb29nbGUuY29tOwo+ID4gcm9iaCtkdEBrZXJuZWwub3JnOyBicm9vbmllQGtlcm5lbC5vcmc7 IGxvcmVuem8ucGllcmFsaXNpQGFybS5jb207Cj4gPiBmZXN0ZXZhbUBnbWFpbC5jb207IGZyYW5j ZXNjby5kb2xjaW5pQHRvcmFkZXguY29tCj4gPiBDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9y ZzsKPiA+IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsKPiA+IGxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGtlcm5lbEBwZW5ndXRyb25peC5kZTsgZGwtbGludXgtaW14 Cj4gPiA8bGludXgtaW14QG54cC5jb20+Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYxNCAxNC8x N10gUENJOiBpbXg2OiBEbyBub3QgaGlkZSBwaHkgZHJpdmVyCj4gPiBjYWxsYmFja3MgYW5kCj4g PiByZWZpbmUgdGhlIGVycm9yIGhhbmRsaW5nCj4gPiAKPiA+IEFtIEZyZWl0YWcsIGRlbSAwMS4w Ny4yMDIyIHVtIDExOjI1ICswODAwIHNjaHJpZWIgUmljaGFyZCBaaHU6Cj4gPiA+IC0gTW92ZSB0 aGUgcGh5X3Bvd2VyX29uKCkgdG8gaG9zdF9pbml0IGZyb20KPiA+ID4gaW14Nl9wY2llX2Nsa19l bmFibGUoKS4KPiA+ID4gLSBNb3ZlIHRoZSBwaHlfaW5pdCgpIHRvIGhvc3RfaW5pdCBmcm9tCj4g PiA+IGlteDZfcGNpZV9kZWFzc2VydF9jb3JlX3Jlc2V0KCkuCj4gPiA+IAo+ID4gPiBSZWZpbmUg dGhlIGVycm9yIGhhbmRsaW5nIGluIGlteDZfcGNpZV9ob3N0X2luaXQoKSBhY2NvcmRpbmdseS4K PiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFJpY2hhcmQgWmh1IDxob25neGluZy56aHVAbnhw LmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xl LmNvbT4KPiA+ID4gLS0tCj4gPiA+IMKgZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlt eDYuYyB8IDM0ICsrKysrKysrKysrKysrKysrLS0tLQo+ID4gPiAtLS0tLS0KPiA+ID4gwqAxIGZp bGUgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlteDYuYwo+ID4g Yi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCj4gPiA+IGluZGV4IDVhMDZm YmNhODJkNi4uMGIyYTUyNTZmYjBkIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250 cm9sbGVyL2R3Yy9wY2ktaW14Ni5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIv ZHdjL3BjaS1pbXg2LmMKPiA+ID4gQEAgLTYzOSwxNCArNjM5LDYgQEAgc3RhdGljIGludCBpbXg2 X3BjaWVfY2xrX2VuYWJsZShzdHJ1Y3QKPiA+ID4gaW14Nl9wY2llCj4gPiAqaW14Nl9wY2llKQo+ ID4gPiDCoAkJZ290byBlcnJfcmVmX2NsazsKPiA+ID4gwqAJfQo+ID4gPiAKPiA+ID4gLQlzd2l0 Y2ggKGlteDZfcGNpZS0+ZHJ2ZGF0YS0+dmFyaWFudCkgewo+ID4gPiAtCWNhc2UgSU1YOE1NOgo+ ID4gPiAtCQlpZiAocGh5X3Bvd2VyX29uKGlteDZfcGNpZS0+cGh5KSkKPiA+ID4gLQkJCWRldl9l cnIoZGV2LCAidW5hYmxlIHRvIHBvd2VyIG9uCj4gPiA+IFBIWVxuIik7Cj4gPiA+IC0JCWJyZWFr Owo+ID4gPiAtCWRlZmF1bHQ6Cj4gPiA+IC0JCWJyZWFrOwo+ID4gPiAtCX0KPiA+ID4gwqAJLyog YWxsb3cgdGhlIGNsb2NrcyB0byBzdGFiaWxpemUgKi8KPiA+ID4gwqAJdXNsZWVwX3JhbmdlKDIw MCwgNTAwKTsKPiA+ID4gwqAJcmV0dXJuIDA7Cj4gPiA+IEBAIC03MjMsMTAgKzcxNSw2IEBAIHN0 YXRpYyBpbnQKPiA+ID4gaW14Nl9wY2llX2RlYXNzZXJ0X2NvcmVfcmVzZXQoc3RydWN0Cj4gPiBp bXg2X3BjaWUgKmlteDZfcGNpZSkKPiA+ID4gwqAJY2FzZSBJTVg4TVE6Cj4gPiA+IMKgCQlyZXNl dF9jb250cm9sX2RlYXNzZXJ0KGlteDZfcGNpZS0KPiA+ID4gPnBjaWVwaHlfcmVzZXQpOwo+ID4g PiDCoAkJYnJlYWs7Cj4gPiA+IC0JY2FzZSBJTVg4TU06Cj4gPiA+IC0JCWlmIChwaHlfaW5pdChp bXg2X3BjaWUtPnBoeSkpCj4gPiA+IC0JCQlkZXZfZXJyKGRldiwgIndhaXRpbmcgZm9yIHBoeSBy ZWFkeQo+ID4gPiB0aW1lb3V0IVxuIik7Cj4gPiA+IC0JCWJyZWFrOwo+ID4gPiDCoAljYXNlIElN WDdEOgo+ID4gPiDCoAkJcmVzZXRfY29udHJvbF9kZWFzc2VydChpbXg2X3BjaWUtCj4gPiA+ID5w Y2llcGh5X3Jlc2V0KTsKPiA+ID4gCj4gPiA+IEBAIC03NjIsNiArNzUwLDcgQEAgc3RhdGljIGlu dAo+ID4gPiBpbXg2X3BjaWVfZGVhc3NlcnRfY29yZV9yZXNldChzdHJ1Y3QKPiA+IGlteDZfcGNp ZSAqaW14Nl9wY2llKQo+ID4gPiDCoAkJdXNsZWVwX3JhbmdlKDIwMCwgNTAwKTsKPiA+ID4gwqAJ CWJyZWFrOwo+ID4gPiDCoAljYXNlIElNWDZROgkJLyogTm90aGluZyB0byBkbyAqLwo+ID4gPiAr CWNhc2UgSU1YOE1NOgo+ID4gPiDCoAkJYnJlYWs7Cj4gPiA+IMKgCX0KPiA+ID4gCj4gPiA+IEBA IC05MTMsMTcgKzkwMiwzNiBAQCBzdGF0aWMgaW50IGlteDZfcGNpZV9ob3N0X2luaXQoc3RydWN0 Cj4gPiA+IHBjaWVfcG9ydAo+ID4gKnBwKQo+ID4gPiDCoAkJCXJldHVybiByZXQ7Cj4gPiA+IMKg CQl9Cj4gPiA+IMKgCX0KPiA+ID4gKwlpZiAoaW14Nl9wY2llLT5waHkpIHsKPiA+ID4gKwkJcmV0 ID0gcGh5X3Bvd2VyX29uKGlteDZfcGNpZS0+cGh5KTsKPiA+ID4gKwkJaWYgKHJldCkgewo+ID4g PiArCQkJZGV2X2VycihkZXYsICJwY2llIHBoeSBwb3dlciB1cAo+ID4gPiBmYWlsZWQuXG4iKTsK PiA+ID4gKwkJCWdvdG8gZXJyX3JlZ19kaXNhYmxlOwo+ID4gPiArCQl9Cj4gPiA+ICsJfQo+ID4g PiAKPiA+ID4gwqAJcmV0ID0gaW14Nl9wY2llX2RlYXNzZXJ0X2NvcmVfcmVzZXQoaW14Nl9wY2ll KTsKPiA+ID4gwqAJaWYgKHJldCA8IDApIHsKPiA+ID4gwqAJCWRldl9lcnIoZGV2LCAicGNpZSBk ZWFzc2VydCBjb3JlIHJlc2V0IGZhaWxlZDoKPiA+ID4gJWRcbiIsIHJldCk7Cj4gPiA+IC0JCWdv dG8gZXJyX3JlZ19kaXNhYmxlOwo+ID4gPiArCQlnb3RvIGVycl9waHlfb2ZmOwo+ID4gPiDCoAl9 Cj4gPiA+IAo+ID4gPiArCWlmIChpbXg2X3BjaWUtPnBoeSkgewo+ID4gPiArCQlyZXQgPSBwaHlf aW5pdChpbXg2X3BjaWUtPnBoeSk7Cj4gPiA+ICsJCWlmIChyZXQpIHsKPiA+ID4gKwkJCWRldl9l cnIoZGV2LCAid2FpdGluZyBmb3IgcGh5IHJlYWR5Cj4gPiA+IHRpbWVvdXQhXG4iKTsKPiA+ID4g KwkJCWdvdG8gZXJyX2Nsa19kaXNhYmxlOwo+ID4gPiArCQl9Cj4gPiA+ICsJfQo+ID4gCj4gPiBX b3VsZG4ndCBpdCBiZSBtb3JlIGxvZ2ljYWwgdG8gcHV0IHRoaXMgaW50byBpbXg2X3BjaWVfaW5p dF9waHkoKT8KPiA+IAo+IEJlZm9yZSBhZGRpbmcgaS5NWDhNTSBQQ0llIHN1cHBvcnQsIHRoZSBp bXg2X3BjaWVfaW5pdF9waHkoKSBvbmx5Cj4gdG91Y2hlcyB0aGUKPiDCoEdQUiByZWdpc3RlcnMu IFBDSWUgY2xvY2tzIGFuZCBzbyBvbiBhcmUgbm90IHJlcXVpcmVkIGluIHRoaXMgY2FzZS4KPiBC dXQgcGh5X2luaXQoKSB1c2VkIGJ5IGkuTVg4TU0gUENJZSB0b3VjaGVzIG5vdCBvbmx5IHRoZSBH UFIKPiByZWdpc3RlcnMgYnV0Cj4gwqBhbHNvIHRoZSBQSFkncyByZWdpc3RlcnMuCj4gVGhlIGNs b2NrcyBzaG91bGQgYmUgb24gYW5kIHJlc2V0cyBvZiBQSFkgc2hvdWxkIGJlIGNvbmZpZ3VyZWQK PiBwcm9wZXJseSB3aGVuCj4gwqBwaHlfaW5pdCgpIGlzIGludm9rZWQuCj4gU28sIHBoeV9pbml0 KCkgaXMgcGxhY2VkIGJlaGluZCBvZiBpbXg2X3BjaWVfZGVhc3NlcnRfY29yZV9yZXNldCgpCj4g aGVyZS4KClRoZSBQSFkgZHJpdmVyIHNob3VsZCBiZSBzZWxmLWNvbnRhaW5lZCBlbm91Z2ggdG8g bm90IGNhcmUgYWJvdXQgdGhlCnN0YXRlIG9mIHRoZSBjb250cm9sbGVyIGhlcmUsIG5vPyBJdCBz aG91bGQgc2V0IGFsbCB0aGUgbmVjZXNzYXJ5IEdQUnMKYW5kIGVuYWJsZSBjbG9ja3MgYXMgbmVl ZGVkIG9uIGl0cyBvd24uIElzIHRoaXMgbm90IHRoZSBjYXNlIHdpdGggdGhlCmN1cnJlbnQgY29k ZT8KCkFsc28gUEhZIGluaXQgc2hvdWxkIGJlIGNhbGxlZCBiZWZvcmUgUEhZIHBvd2VyLW9uLCB0 byBtYWtlIHRoaW5ncwpzeW1tZXRyaWMgd2l0aCB0aGUgc2h1dGRvd24gcGF0aHMgd2hpY2ggZG8g cGh5X3Bvd2VyX29mZigpIGZpcnN0LCB0aGVuCnBoeV9leGl0KCkuCgpSZWdhcmRzLApMdWNhcwoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK