From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 154C6CF6497 for ; Mon, 30 Sep 2024 10:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: In-Reply-To:From:References:Cc:To:Subject:Date:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r4BvdowF4yU280w3m5jWi+Qy600EcLeUWOklrU7maQU=; b=4ykRq4yK6W8DIB8M3FMGTSA2cs 1asi+ws4RnzTgO+iTPbj8nolsyVubIaRM9y5fwkTX4T6M5J4jhGIniYUdNuoOAn6beuom1WPteo4t XyDihEfGJKLmDhHY+LD1CBQvOb5stSJYvBmhzZQkSx2ynYMGzXJVQkS8sV4yiONpt/d7dngLcznfX /gfGQMb1EiQQA/ORRccereVCI/np8URz4Zd8d1zLWnyogF1Y8a1GJs5UVEpFPcT/BmJEEWggjjAks pZ7x9l2fOjicPQ1CFk1IigiTMGBeXR3wgyqxCgMNVUlAs1M243TOdiTAuTqnjL6ButGd3OpNgRUyB c9KJUAfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svDGJ-0000000Gd43-2ys4; Mon, 30 Sep 2024 10:04:15 +0000 Received: from mail-db8eur05on20601.outbound.protection.outlook.com ([2a01:111:f403:2614::601] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svCt4-0000000GZGv-3lr6 for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2024 09:40:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KNI0jZr8X9H/CrURQf5iuOTrbzpoM5X985V6CDnyScaJD6SdxLmpTIfZ1J/nYy1TIyR352jvZtgTPUJwFLYXOG2Ass2uoVhB5DAcCK9MFspUTvJdDo75WPLzHnLMn1/GWvdCNl7+oujVT3HiIrcv/qxq0vuqdp6Dd9N6AYDmgiwJvNJ/nl75g8sLEt2ThfzSChMwwPXTmjyqU5uY1kTIc6l6HeJDMc904+0IpOPYPsQ/zYO9Rt++n+YI8mdA4/KcB5MEr8J1RMvO6JBqs97Kbmssnn/bPX1ew1EsHoHMBSPG9W0GYlIibTJTWx0Cc+zMANrBqjKpk/QFTcZDAnLBzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r4BvdowF4yU280w3m5jWi+Qy600EcLeUWOklrU7maQU=; b=tZwtQd9DekbqdU9M2yBzntWXABxxJ/gYRMSgwgBsfrjH+p6+FT3ODgaClFHsunrLI3SYtcc2NAQ65ysfMpXez9oHtkcxuCDLbCUfNSSEemu+Bg9m7t6FP60Z9mO0Mx6qkOLgKDRzIUBcJxkeR07FBMiO8ru602e5iiB1iYbvFN5QMNm+fAt7tIxV1pxe8x877KeCyqkh97iN498L70F2err/tG/cg8OU1k7KyN/5RFyggcNI8QFB2LgOD0pmUk1wB4rUNYlkOFwaVVBvqq89Mh25MoXHLJ92aXDvZeQTtFTDYzF3ZF4lOxORyapN/P+R7ipOsn/SUJp18xknpmvr8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r4BvdowF4yU280w3m5jWi+Qy600EcLeUWOklrU7maQU=; b=UDy4i/Lnl3UIzcg4Cu3EP6lMGDbv6fplzJIFNkU23NcyzCyubt6+Mlk9SNfhcd0EaxSscDGFFpaoM8855uIoQrv0TSUkcsQ8Yp0kccm5Av9YEj3Ecl5Gw/dOq9vPteADbUhIZYe6F45DukQ14nh4av0t9myZNdvX1hWZEe+HKzI8CK7FRM0tUSEj/axflSuzQ8fkSYSSKGtfun/gVZImQbITYsELatcGtsXY4uDOBrxBY6yaOLYLJ9hajo/bepExy/Z1xmX3rX7GxdCQeXAK+nYFTmaf855wPaMTKoFxWCNjdw7mogroiRfxM72SVSXaIA0GASREheI1r3QSJlR9sA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by DU2PR04MB8727.eurprd04.prod.outlook.com (2603:10a6:10:2de::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.27; Mon, 30 Sep 2024 09:40:06 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%4]) with mapi id 15.20.8005.024; Mon, 30 Sep 2024 09:40:05 +0000 Message-ID: <5bdd86cf-ee76-452c-b854-171b3aecb04b@nxp.com> Date: Mon, 30 Sep 2024 17:40:25 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI converter To: Biju Das , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" Cc: "andrzej.hajda@intel.com" , "neil.armstrong@linaro.org" , "rfoss@kernel.org" , "laurent.pinchart" , "jonas@kwiboo.se" , "jernej.skrabec@gmail.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "tzimmermann@suse.de" , "airlied@gmail.com" , "simona@ffwll.ch" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "quic_bjorande@quicinc.com" , "geert+renesas@glider.be" , "dmitry.baryshkov@linaro.org" , "arnd@arndb.de" , "nfraprado@collabora.com" , "o.rempel@pengutronix.de" , "y.moog@phytec.de" References: <20240930052903.168881-1-victor.liu@nxp.com> <20240930052903.168881-7-victor.liu@nxp.com> From: Liu Ying Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-ClientProxiedBy: SI2PR02CA0018.apcprd02.prod.outlook.com (2603:1096:4:194::18) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|DU2PR04MB8727:EE_ X-MS-Office365-Filtering-Correlation-Id: c5b5b55d-6bc0-4e36-8e03-08dce133dd7a X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MXZ4K2VLMnhSNHB6aEdwTG9ySEg0RXJUOEx3MnpRbVlhQVdCU045MUVtTDlM?= =?utf-8?B?NlN3dDk2K0ZJeGxSRkFHT0ZlK0RnRm53MHR6S3R2aUs4RndkR2FJeEJ0ZVJX?= =?utf-8?B?TVV2Qi9YWkZpZVdPRjhsT0dHd1FPTHNERTlvNHBOMlBzRlEraTJEM1BZVDJn?= =?utf-8?B?UEwxQURENU9aUzR5RUNGelFjeDVRWVZXNnplNEc0MkcrSWVlV0RmeDVoNCtQ?= =?utf-8?B?THpBNlk2TWkxcUxFb05xMXloT3NXMmVGQ054ZXZOUDZMQ3poaThTSjh2c01v?= =?utf-8?B?WmtvV1pTTzBMK2NvZ0xoQUFySkZmbXd1VTkrM3I2NXBaVjdua0RHU281c3pp?= =?utf-8?B?NEdxR2ROSGVXSk80OHBEWXJWWHRmaTh6SFc2cSt6VmY2TmV1MUJLc0pIZHVk?= =?utf-8?B?SEVuNXlOYS9HRTZma3lWZTFEN3JCekg1VW85RHh5bzdaQmpVUE9PQkNkS3lx?= =?utf-8?B?V3pxVWtPWDExUEpacVJDNWNrdit5YXJZRzI1R1ZEVEI1Y05wTXBvSXUrZTdJ?= =?utf-8?B?b0MrZHdlVEptR2g2TFpBeTZnbTRtQW9jMGFUQW13UC9ZSEp3RjA1N3d5dmJw?= =?utf-8?B?TEhHMUhlazNWd1RCZmZ3YlorMjk2ZGdmUWRhZlZtZjNkSlFpbTV5M285Zng3?= =?utf-8?B?aDRzY3Zoc1YzNkxMdFBZRkl4ZjF6em9QZXU0dUd0RmJEdFFWdmx3VzlIYlVS?= =?utf-8?B?RkFSQ1AwVkNibTZlcmd3YjJIK1VocWsybS9VWFNmck5rcjNSWk44M2N5anVQ?= =?utf-8?B?TjJ6RlVTSEw5TGhES0R6aEpjZHQ5TFNaanZDSVZzQmdERGFMbFpYM0h2SnJw?= =?utf-8?B?UjFTNng4R2ozdHgveFRDL0dKaTFKMVBrZjZqQ3JmZk5jdEM0SU9MUlRkdk90?= =?utf-8?B?YlNNTFVkMGNhYmp0eW03cDd5eGtOWFVzNmx4SUZyMUE1SWVzUDI3aFFNczQx?= =?utf-8?B?UnpJNFpIYnlQaWx2TTFNTjJIcWc2a1U5MXlxUlJGS2FGbXEwRXZjSVBpTm9k?= =?utf-8?B?ZlZpOEtLc0RqTFM0VFNxdzFsSjRCUEFsY2J5UkNYZUJIMThBOExPQ2d3eWpS?= =?utf-8?B?VWJNWm5CdmFDQ21oQndXcExPNlNKb2tZU09MNnY2RDhZNngxclVETWYwbUM4?= =?utf-8?B?SEhlNDZxM3l3bCtTaXFKZlpab0krNFo4Z0VoTXhVWG5PeVFRbmN1QjgrQWlv?= =?utf-8?B?dWJKaE5iQTZLOWpVV01EeCs4Sjk4QUkxb2FTaW1HZzh2N1hQTWhrWGRLc0c3?= =?utf-8?B?SUROUDBJeUtkT3BPNmFlZWtPdlRmaVFYWmFpd1ArTFFCUlN6ZkZFNU42RDY2?= =?utf-8?B?T1FOZzF1UUJQREtBaDh2a3VEWWJxcXhGTDNZdWpWRTlONzd6dklqTStRbDM4?= =?utf-8?B?YmhIZ2xvVWZyWUFrcGRBbk9zVEJEZ09QbGE3WkVBUFp4U1NhZ0FFSnZLWWEr?= =?utf-8?B?QXRDaFc2WklQUWUvTzZZTy9LZGhiYkp3QW5zOGRBWU9oNElQN2FkSVV3c3Fn?= =?utf-8?B?MGFUR1ovK1JxbGREbWd2SU00L1d4MndmSklRdkFFVUpaTzdybWlUcXVNalpU?= =?utf-8?B?djZ6a3V0MlJoMzZjZXh5Yk1rdFJKSzJodjU0elZ4K25WNld4RURYc0pqRnZx?= =?utf-8?B?bmdmZ1dOcENQVXRmd2lOWlVCTW43WTgyOGRDRXdPeFcrSUFLakhiZHBXY0h5?= =?utf-8?B?RkszcE5SbVN0OU8zcEF2ZG5mZjQrcHpEelBQYjlGS3I3RHlXMzMxa1IzUk4z?= =?utf-8?B?cWRWRTJ3Q0NIWGllWDZiSzR3T3cyckdLMk1tcDZ1a2ZIenJPSkVGZnFWa05Z?= =?utf-8?B?bVRLOUdyckZjWERLR1lVdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3VxT0I0dXVCUkJ4UE5ydnhQS2h1YTdvM29Uc3JlUWM1LzdGMmpoTWlRMVc4?= =?utf-8?B?VjBSS0pEaXFYQ25Oa1MraHdOSE1kL0F4UjREMExrcHVPQWgwUU1sd2s2ME9q?= =?utf-8?B?ZzZJUXlxRWQzWFBycEJ2aXEzUi9CcFpnbVVYRDIvdHBPYmZWb3pMekpsemFR?= =?utf-8?B?Y1QzeU1UbEJtRmxINHphQTM0c3FGTEthbUJRbmFNeDFzcWNmbFB1eVpzZ3pr?= =?utf-8?B?T1ZQUzd4RFlNaUUrS2p1NVJsbWxMY2tlNDRZbGQ0NDhjakxCSUY5ZTlNeXpI?= =?utf-8?B?enYzdWVsU1I5d09hb0hQbnhiZEJEZW1meHFJZGVrU0pGREJSeUN1VHBvbjZB?= =?utf-8?B?ejVJME9MRkJpV21uUVYwVmxwNWhCZnJQWXFLSXVHZEM4TGVHWEQzWXNVNFlu?= =?utf-8?B?NFh3R0RvL3paSlhoNUpsb1dMdHV1Z09IYmJjNzN1b0NudmlUTTI4Mkx3SDhI?= =?utf-8?B?MVQwejdxdVFuamxhVXNCdGhlcFFHeXFwbEtabGlwQzlSaW5MR3lSekZwMXdC?= =?utf-8?B?M3lPSjhyTVFIanpuTmFrY1M1VzFaOWRvM1ozVTZNc2R0Y2kxeGxBcFNYMFJI?= =?utf-8?B?MElKRXFCdllSQU5qRGhsQWV6ajliTVZCVnloZHVVQ09DZm5PZXZ5Ymg4aDdD?= =?utf-8?B?ZnFvYi81UEd5Z25xQWpIa1J2cEhES0x6dFJmUy9IMFBWS0FRemRnNjdiMVho?= =?utf-8?B?K2x5SUd4WjdDOG0xNVhxZGl4ajVtWmkvaDFNNmRnQnV6TG5qTUhQM1VYV2F3?= =?utf-8?B?N0xEanZqV2dCbFhRcU9JZXo0a01SZURxL2RTbjVtWjRPUmZlUHA5bk16WmtX?= =?utf-8?B?eFRjWXdwT3ZzRkZtSkNOT24xLzkxcXJwenRWS2JHVi9nUmIvRSt1Mk9ZQ1pu?= =?utf-8?B?ODRFMllyaW5PUHZFZ2Noek5acWxpNjYwOUxrVnZFMEFTQmxjOU9DTmJJWnB3?= =?utf-8?B?MnJrTFRkL3ZUck1MN1h6bzVSbzgzS3FkQmVtMkptR3JUWnUvVlZBcG9Yazky?= =?utf-8?B?UmZuQXR3UzJKNVdEa0ZSZ05IMnl2K3BNYi8wb0lwVlltc0hFWTdFZ2pxMzNr?= =?utf-8?B?cEN4cVFHS2lsMm10d0J2YVJpenhnSFoySUJISFdnWkhRaWJpUktFN3FXQUtR?= =?utf-8?B?ZGtxRW9PeVI0cmlmbGlEN1JLSmV4TXo1cFh1YXNBVm9ySGp5TWV0b2VBV1Er?= =?utf-8?B?dHk5eWY2RkVUWXNxdUk1dnNKZUdUREQ4bXpHUS9uY1dqOEh1UTdUN2JSTUZB?= =?utf-8?B?RXI3OUJDMFA0K2xVbW05UCtkdWVocXRTbXRJSWRyV0lRRVBGM3Jzd1pDODB6?= =?utf-8?B?QmZQaXNpQUVRcWkwVFJiQ3lSaE55MzBhU0ZobGFlRHcrTnpVaEswL0NhT3Nm?= =?utf-8?B?OVFVRkU1bk9QQnFuVERORWlPK3FhNUZYQThLY1U4cmJSczBScmo5QzU2aHp1?= =?utf-8?B?NCtQU0VzMWdhRmR3Rm1ubFZzOUlyWG5KTU9ua09FRlVnTE1wNzF4dFV5RVpa?= =?utf-8?B?SGczbGlGbHdrc0grTDZseHNEWU5JVnhQN04xcnU1NmNoMVFYd2dkT2hFd1k2?= =?utf-8?B?bzBUNTl0Nm9SUnpQYVZyVGRucnVGVGdoaE1MdCtEOW1HVkdMYWtDQXgyVW1W?= =?utf-8?B?SENGdzRzbXBsdS9xaFNNdUMvVkFTYXFSMzdlQjRiNFdiZlpaMlU2Nm9yVVVl?= =?utf-8?B?dnE4WS8xMEg2ZW43VFdJYVVsa1JDNHZRSnVWbWkwZFZXS2t5TDVZUll0QlNB?= =?utf-8?B?QVoxQlIwK2lMcll4OUp1bk9pVitzNzlCMVdybjhQWDNwdEI1NHZpckw3cEhk?= =?utf-8?B?UFlsR2hWSG9VSTBhUENWU1RLWCtTVk4waWRUOFgyeWhQNHR4VnpUallUR0JY?= =?utf-8?B?RlA1UzNmWW5uOUs5Y0NLckhhU3NrZmNGR2JVZjZzWllFM1lyL1FJa0VyWGFr?= =?utf-8?B?U3drTTVFVllUNVpGeFBhUy9JRVdQYVAvREFJaVBrdFh1UFNTOHlCTWZ5STJW?= =?utf-8?B?WTVwVlhTaGJpYndDTzhIYUNOVDBmZzBNVS82N3daNGNlV09mMDBXcEozajJR?= =?utf-8?B?QlVHNXlVWVBMRnhoR0xmVlpmR3FtRFBMNzN4TnEzV2V3c3J6MURwbHpBR3pj?= =?utf-8?Q?s1eZuOtIw/tEdjXrOil/nsTPR?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5b5b55d-6bc0-4e36-8e03-08dce133dd7a X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2024 09:40:05.8243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fE1yr7KPK32XAqfjatpCw2KC3X9fsGFpuYq+AtB700QEs4Ru3u8yojl5kTbnZ/rldQb9nZKlc1swrJ6SyNYHvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8727 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_024015_146115_2BFD1C14 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/30/2024, Biju Das wrote: > Hi Liu, Hi Biju, > > Thanks for the patch. > >> -----Original Message----- >> From: linux-arm-kernel On Behalf Of Liu Ying >> Sent: Monday, September 30, 2024 6:29 AM >> Subject: [PATCH 6/8] drm/bridge: Add ITE IT6263 LVDS to HDMI converter >> >> Add basic HDMI video output support. Currently, only RGB888 output pixel format is supported. At the >> LVDS input side, the driver supports single LVDS link and dual LVDS links with "jeida-24" LVDS >> mapping. >> >> Product link: >> https://www.ite.com.tw/en/product/cate1/IT6263 >> >> Signed-off-by: Liu Ying >> --- >> drivers/gpu/drm/bridge/Kconfig | 8 + >> drivers/gpu/drm/bridge/Makefile | 1 + >> drivers/gpu/drm/bridge/ite-it6263.c | 829 ++++++++++++++++++++++++++++ >> 3 files changed, 838 insertions(+) >> create mode 100644 drivers/gpu/drm/bridge/ite-it6263.c >> >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index >> 3eb955333c80..93f99682a090 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -90,6 +90,14 @@ config DRM_FSL_LDB >> help >> Support for i.MX8MP DPI-to-LVDS on-SoC encoder. >> >> +config DRM_ITE_IT6263 >> + tristate "ITE IT6263 LVDS/HDMI bridge" >> + depends on OF >> + select DRM_KMS_HELPER >> + select REGMAP_I2C >> + help >> + ITE IT6263 LVDS to HDMI bridge chip driver. >> + >> config DRM_ITE_IT6505 >> tristate "ITE IT6505 DisplayPort bridge" >> depends on OF >> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile index >> 7df87b582dca..f3776dd473fd 100644 >> --- a/drivers/gpu/drm/bridge/Makefile >> +++ b/drivers/gpu/drm/bridge/Makefile >> @@ -6,6 +6,7 @@ obj-$(CONFIG_DRM_CHRONTEL_CH7033) += chrontel-ch7033.o >> obj-$(CONFIG_DRM_CROS_EC_ANX7688) += cros-ec-anx7688.o >> obj-$(CONFIG_DRM_DISPLAY_CONNECTOR) += display-connector.o >> obj-$(CONFIG_DRM_FSL_LDB) += fsl-ldb.o >> +obj-$(CONFIG_DRM_ITE_IT6263) += ite-it6263.o >> obj-$(CONFIG_DRM_ITE_IT6505) += ite-it6505.o >> obj-$(CONFIG_DRM_LONTIUM_LT8912B) += lontium-lt8912b.o >> obj-$(CONFIG_DRM_LONTIUM_LT9211) += lontium-lt9211.o diff --git a/drivers/gpu/drm/bridge/ite-it6263.c >> b/drivers/gpu/drm/bridge/ite-it6263.c >> new file mode 100644 >> index 000000000000..886588497bc1 >> --- /dev/null >> +++ b/drivers/gpu/drm/bridge/ite-it6263.c >> @@ -0,0 +1,829 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright 2024 NXP >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include #include >> +#include #include #include >> + #include #include >> + >> + >> +/* >> +----------------------------------------------------------------------- >> +------ >> + * LVDS registers >> + */ >> + >> +/* LVDS software reset registers */ >> +#define LVDS_REG_05 0x05 >> +#define REG_SOFT_P_RST BIT(1) >> + >> +/* LVDS system configuration registers */ >> +/* 0x0b */ >> +#define LVDS_REG_0B 0x0b >> +#define REG_SSC_PCLK_RF BIT(0) >> +#define REG_LVDS_IN_SWAP BIT(1) >> + >> +/* LVDS test pattern gen control registers */ >> +/* 0x2c */ >> +#define LVDS_REG_2C 0x2c >> +#define REG_COL_DEP GENMASK(1, 0) >> +#define BIT8 FIELD_PREP(REG_COL_DEP, 2) >> +#define OUT_MAP BIT(4) >> +#define JEIDA 0 >> +#define REG_DESSC_ENB BIT(6) >> +#define DMODE BIT(7) >> +#define DISO BIT(7) >> +#define SISO 0 >> + >> +#define LVDS_REG_3C 0x3c >> +#define LVDS_REG_3F 0x3f >> +#define LVDS_REG_47 0x47 >> +#define LVDS_REG_48 0x48 >> +#define LVDS_REG_4F 0x4f >> +#define LVDS_REG_52 0x52 >> + >> +/* >> +----------------------------------------------------------------------- >> +------ >> + * HDMI registers are separated into three banks: >> + * 1) HDMI register common bank: 0x00 ~ 0x2f */ >> + >> +/* HDMI genernal registers */ >> +#define HDMI_REG_SW_RST 0x04 >> +#define SOFTREF_RST BIT(5) >> +#define SOFTA_RST BIT(4) >> +#define SOFTV_RST BIT(3) >> +#define AUD_RST BIT(2) >> +#define HDCP_RST BIT(0) >> +#define HDMI_RST_ALL (SOFTREF_RST | SOFTA_RST | SOFTV_RST | \ >> + AUD_RST | HDCP_RST) >> + >> +#define HDMI_REG_SYS_STATUS 0x0e >> +#define HPDETECT BIT(6) >> +#define TXVIDSTABLE BIT(4) >> + >> +#define HDMI_REG_BANK_CTRL 0x0f >> +#define REG_BANK_SEL BIT(0) >> + >> +/* HDMI System DDC control registers */ >> +#define HDMI_REG_DDC_MASTER_CTRL 0x10 >> +#define MASTER_SEL_HOST BIT(0) >> + >> +#define HDMI_REG_DDC_HEADER 0x11 >> + >> +#define HDMI_REG_DDC_REQOFF 0x12 >> +#define HDMI_REG_DDC_REQCOUNT 0x13 >> +#define HDMI_REG_DDC_EDIDSEG 0x14 >> + >> +#define HDMI_REG_DDC_CMD 0x15 >> +#define DDC_CMD_EDID_READ 0x3 >> +#define DDC_CMD_FIFO_CLR 0x9 >> + >> +#define HDMI_REG_DDC_STATUS 0x16 >> +#define DDC_DONE BIT(7) >> +#define DDC_NOACK BIT(5) >> +#define DDC_WAITBUS BIT(4) >> +#define DDC_ARBILOSE BIT(3) >> +#define DDC_ERROR (DDC_NOACK | DDC_WAITBUS | DDC_ARBILOSE) >> + >> +#define HDMI_DDC_FIFO_BYTES 32 >> +#define HDMI_REG_DDC_READFIFO 0x17 >> +#define HDMI_REG_LVDS_PORT 0x1d /* LVDS input control I2C addr */ >> +#define HDMI_REG_LVDS_PORT_EN 0x1e >> +#define LVDS_INPUT_CTRL_I2C_ADDR 0x33 >> + >> +/* >> +----------------------------------------------------------------------- >> +------ >> + * 2) HDMI register bank0: 0x30 ~ 0xff >> + */ >> + >> +/* HDMI AFE registers */ >> +#define HDMI_REG_AFE_DRV_CTRL 0x61 >> +#define AFE_DRV_PWD BIT(5) >> +#define AFE_DRV_RST BIT(4) >> + >> +#define HDMI_REG_AFE_XP_CTRL 0x62 >> +#define AFE_XP_GAINBIT BIT(7) >> +#define AFE_XP_ER0 BIT(4) >> +#define AFE_XP_RESETB BIT(3) >> + >> +#define HDMI_REG_AFE_ISW_CTRL 0x63 >> + >> +#define HDMI_REG_AFE_IP_CTRL 0x64 >> +#define AFE_IP_GAINBIT BIT(7) >> +#define AFE_IP_ER0 BIT(3) >> +#define AFE_IP_RESETB BIT(2) >> + >> +/* HDMI input data format registers */ >> +#define HDMI_REG_INPUT_MODE 0x70 >> +#define IN_RGB 0x00 >> + >> +/* HDMI general control registers */ >> +#define HDMI_REG_HDMI_MODE 0xc0 >> +#define TX_HDMI_MODE BIT(0) >> + >> +#define HDMI_REG_GCP 0xc1 >> +#define AVMUTE BIT(0) >> +#define HDMI_COLOR_DEPTH GENMASK(6, 4) >> +#define HDMI_COLOR_DEPTH_24 FIELD_PREP(HDMI_COLOR_DEPTH, 4) >> + >> +#define HDMI_REG_PKT_GENERAL_CTRL 0xc6 >> +#define ENABLE_PKT BIT(0) >> +#define REPEAT_PKT BIT(1) >> + >> +/* >> +----------------------------------------------------------------------- >> +------ >> + * 3) HDMI register bank1: 0x130 ~ 0x1ff (HDMI packet registers) */ >> + >> +/* AVI packet registers */ >> +#define HDMI_REG_AVI_DB1 0x158 >> +#define AVI_DB1_COLOR_SPACE GENMASK(6, 5) >> +#define AVI_COLOR_SPACE_RGB FIELD_PREP(AVI_DB1_COLOR_SPACE, 0) >> + >> +#define MAX_PIXEL_CLOCK_KHZ 150000 >> +#define HIGH_PIXEL_CLOCK_KHZ 80000 >> + >> +struct it6263 { >> + struct device *dev; >> + struct i2c_client *hdmi_i2c; >> + struct i2c_client *lvds_i2c; >> + struct regmap *hdmi_regmap; >> + struct regmap *lvds_regmap; >> + struct drm_bridge bridge; >> + struct drm_bridge *next_bridge; >> + struct drm_connector connector; >> + struct gpio_desc *reset_gpio; >> + bool lvds_dual_link; >> + bool lvds_link12_swap; >> +}; >> + >> +static inline struct it6263 *bridge_to_it6263(struct drm_bridge >> +*bridge) { >> + return container_of(bridge, struct it6263, bridge); } >> + >> +static inline struct it6263 *connector_to_it6263(struct drm_connector >> +*conn) { >> + return container_of(conn, struct it6263, connector); } >> + >> +static bool it6263_hdmi_writeable_reg(struct device *dev, unsigned int >> +reg) { >> + switch (reg) { >> + case HDMI_REG_SW_RST: >> + case HDMI_REG_BANK_CTRL: >> + case HDMI_REG_DDC_MASTER_CTRL: >> + case HDMI_REG_DDC_HEADER: >> + case HDMI_REG_DDC_REQOFF: >> + case HDMI_REG_DDC_REQCOUNT: >> + case HDMI_REG_DDC_EDIDSEG: >> + case HDMI_REG_DDC_CMD: >> + case HDMI_REG_LVDS_PORT: >> + case HDMI_REG_LVDS_PORT_EN: >> + case HDMI_REG_AFE_DRV_CTRL: >> + case HDMI_REG_AFE_XP_CTRL: >> + case HDMI_REG_AFE_ISW_CTRL: >> + case HDMI_REG_AFE_IP_CTRL: >> + case HDMI_REG_INPUT_MODE: >> + case HDMI_REG_HDMI_MODE: >> + case HDMI_REG_GCP: >> + case HDMI_REG_PKT_GENERAL_CTRL: >> + case HDMI_REG_AVI_DB1: >> + return true; >> + default: >> + return false; >> + } >> +} >> + >> +static bool it6263_hdmi_readable_reg(struct device *dev, unsigned int >> +reg) { >> + if (it6263_hdmi_writeable_reg(dev, reg)) >> + return true; >> + >> + switch (reg) { >> + case HDMI_REG_SYS_STATUS: >> + case HDMI_REG_DDC_STATUS: >> + case HDMI_REG_DDC_READFIFO: >> + return true; >> + default: >> + return false; >> + } >> +} >> + >> +static bool it6263_hdmi_volatile_reg(struct device *dev, unsigned int >> +reg) { >> + switch (reg) { >> + case HDMI_REG_SW_RST: >> + case HDMI_REG_SYS_STATUS: >> + case HDMI_REG_DDC_STATUS: >> + case HDMI_REG_DDC_READFIFO: >> + return true; >> + default: >> + return false; >> + } >> +} >> + >> +static const struct regmap_range_cfg it6263_hdmi_range_cfg = { >> + .range_min = 0x00, >> + .range_max = HDMI_REG_AVI_DB1, >> + .selector_reg = HDMI_REG_BANK_CTRL, >> + .selector_mask = REG_BANK_SEL, >> + .selector_shift = 0, >> + .window_start = 0x00, >> + .window_len = 0x100, >> +}; >> + >> +static const struct regmap_config it6263_hdmi_regmap_config = { >> + .name = "it6263-hdmi", >> + .reg_bits = 8, >> + .val_bits = 8, >> + .writeable_reg = it6263_hdmi_writeable_reg, >> + .readable_reg = it6263_hdmi_readable_reg, >> + .volatile_reg = it6263_hdmi_volatile_reg, >> + .max_register = HDMI_REG_AVI_DB1, >> + .ranges = &it6263_hdmi_range_cfg, >> + .num_ranges = 1, >> + .cache_type = REGCACHE_MAPLE, >> +}; >> + >> +static bool it6263_lvds_writeable_reg(struct device *dev, unsigned int >> +reg) { >> + switch (reg) { >> + case LVDS_REG_05: >> + case LVDS_REG_0B: >> + case LVDS_REG_2C: >> + case LVDS_REG_3C: >> + case LVDS_REG_3F: >> + case LVDS_REG_47: >> + case LVDS_REG_48: >> + case LVDS_REG_4F: >> + case LVDS_REG_52: >> + return true; >> + default: >> + return false; >> + } >> +} >> + >> +static bool it6263_lvds_readable_reg(struct device *dev, unsigned int >> +reg) { >> + return it6263_lvds_writeable_reg(dev, reg); } >> + >> +static bool it6263_lvds_volatile_reg(struct device *dev, unsigned int >> +reg) { >> + return reg == LVDS_REG_05; >> +} >> + >> +static const struct regmap_config it6263_lvds_regmap_config = { >> + .name = "it6263-lvds", >> + .reg_bits = 8, >> + .val_bits = 8, >> + .writeable_reg = it6263_lvds_writeable_reg, >> + .readable_reg = it6263_lvds_readable_reg, >> + .volatile_reg = it6263_lvds_volatile_reg, >> + .max_register = LVDS_REG_52, >> + .cache_type = REGCACHE_MAPLE, >> +}; >> + >> +static const char * const it6263_supplies[] = { >> + "ivdd", "ovdd", "txavcc18", "txavcc33", "pvcc1", "pvcc2", >> + "avcc", "anvdd", "apvdd" >> +}; >> + >> +static int it6263_parse_dt(struct it6263 *it) { >> + struct device *dev = it->dev; >> + struct device_node *port0, *port1; >> + int ret = 0; >> + >> + it->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 2, 0); >> + if (IS_ERR(it->next_bridge)) >> + return dev_err_probe(dev, PTR_ERR(it->next_bridge), >> + "failed to get next bridge\n"); >> + >> + port0 = of_graph_get_port_by_id(dev->of_node, 0); >> + port1 = of_graph_get_port_by_id(dev->of_node, 1); >> + if (port0 && port1) { >> + if (of_property_read_bool(port0, "dual-lvds-even-pixels") && >> + of_property_read_bool(port1, "dual-lvds-odd-pixels")) { >> + it->lvds_dual_link = true; >> + it->lvds_link12_swap = true; >> + } else if (of_property_read_bool(port0, "dual-lvds-odd-pixels") && >> + of_property_read_bool(port1, "dual-lvds-even-pixels")) { >> + it->lvds_dual_link = true; >> + } >> + >> + if (!it->lvds_dual_link) { >> + dev_err(dev, >> + "failed to get LVDS dual link pixel order\n"); >> + ret = -EINVAL; >> + } >> + } else if (port1) { >> + ret = -EINVAL; >> + dev_err(dev, "single input LVDS port1 is not supported\n"); > > Are you supporting single input LVDS port0?? > >> + } else if (!port0) { >> + ret = -EINVAL; >> + dev_err(dev, "no input LVDS port\n"); >> + } >> + >> + of_node_put(port0); >> + of_node_put(port1); >> + >> + return ret; >> +} >> + >> +static inline void it6263_reset(struct it6263 *it) { >> + if (!it->reset_gpio) >> + return; >> + >> + gpiod_set_value_cansleep(it->reset_gpio, 0); >> + fsleep(1000); >> + gpiod_set_value_cansleep(it->reset_gpio, 1); >> + /* The chip maker says the low pulse should be at least 40ms. */ >> + fsleep(40000); >> + gpiod_set_value_cansleep(it->reset_gpio, 0); >> + /* addtional time to wait the high voltage to be stable */ >> + fsleep(5000); > > What about other resets ?? > > /* AFE PLL reset and pclk reset */ > >> +} >> + >> +static inline int it6263_lvds_set_i2c_addr(struct it6263 *it) { >> + int ret; >> + >> + ret = regmap_write(it->hdmi_regmap, HDMI_REG_LVDS_PORT, >> + LVDS_INPUT_CTRL_I2C_ADDR << 1); >> + if (ret) >> + return ret; >> + >> + return regmap_write(it->hdmi_regmap, HDMI_REG_LVDS_PORT_EN, BIT(0)); } >> + >> +static inline void it6263_lvds_reset(struct it6263 *it) { >> + /* AFE PLL reset */ >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_3C, BIT(0), 0x0); >> + fsleep(1000); >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_3C, BIT(0), BIT(0)); >> + >> + /* software pixel clock domain reset */ >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_05, REG_SOFT_P_RST, >> + REG_SOFT_P_RST); >> + fsleep(1000); >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_05, REG_SOFT_P_RST, 0x0); >> + fsleep(10000); >> +} >> + >> +static inline void it6263_lvds_set_interface(struct it6263 *it) { >> + /* color depth */ >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_2C, REG_COL_DEP, BIT8); >> + /* output mapping */ >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_2C, OUT_MAP, JEIDA); >> + >> + if (it->lvds_dual_link) { >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_2C, DMODE, DISO); >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_52, BIT(1), BIT(1)); >> + } else { >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_2C, DMODE, SISO); >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_52, BIT(1), 0); >> + } >> +} >> + >> +static inline void it6263_lvds_set_afe(struct it6263 *it) { >> + regmap_write(it->lvds_regmap, LVDS_REG_3C, 0xaa); >> + regmap_write(it->lvds_regmap, LVDS_REG_3F, 0x02); >> + regmap_write(it->lvds_regmap, LVDS_REG_47, 0xaa); >> + regmap_write(it->lvds_regmap, LVDS_REG_48, 0x02); >> + regmap_write(it->lvds_regmap, LVDS_REG_4F, 0x11); >> + >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_0B, REG_SSC_PCLK_RF, >> + REG_SSC_PCLK_RF); >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_3C, 0x07, 0); >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_2C, REG_DESSC_ENB, >> + REG_DESSC_ENB); >> +} >> + >> +static inline void it6263_lvds_sys_cfg(struct it6263 *it) { >> + regmap_write_bits(it->lvds_regmap, LVDS_REG_0B, REG_LVDS_IN_SWAP, >> + it->lvds_link12_swap ? REG_LVDS_IN_SWAP : 0); } >> + >> +static inline void it6263_lvds_config(struct it6263 *it) { >> + it6263_lvds_reset(it); >> + it6263_lvds_set_interface(it); >> + it6263_lvds_set_afe(it); >> + it6263_lvds_sys_cfg(it); >> +} >> + >> +static inline void it6263_hdmi_config(struct it6263 *it) { >> + regmap_write(it->hdmi_regmap, HDMI_REG_SW_RST, HDMI_RST_ALL); >> + regmap_write(it->hdmi_regmap, HDMI_REG_INPUT_MODE, IN_RGB); >> + regmap_write_bits(it->hdmi_regmap, HDMI_REG_GCP, HDMI_COLOR_DEPTH, >> + HDMI_COLOR_DEPTH_24); >> + regmap_write_bits(it->hdmi_regmap, HDMI_REG_AVI_DB1, >> + AVI_DB1_COLOR_SPACE, AVI_COLOR_SPACE_RGB); } >> + >> +static enum drm_connector_status it6263_detect(struct it6263 *it) { >> + unsigned int val; >> + >> + regmap_read(it->hdmi_regmap, HDMI_REG_SYS_STATUS, &val); >> + if (val & HPDETECT) >> + return connector_status_connected; >> + else >> + return connector_status_disconnected; } >> + >> +static enum drm_connector_status >> +it6263_connector_detect(struct drm_connector *connector, bool force) { >> + struct it6263 *it = connector_to_it6263(connector); >> + >> + return it6263_detect(it); >> +} >> + >> +static const struct drm_connector_funcs it6263_connector_funcs = { >> + .detect = it6263_connector_detect, >> + .fill_modes = drm_helper_probe_single_connector_modes, >> + .destroy = drm_connector_cleanup, >> + .reset = drm_atomic_helper_connector_reset, >> + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, >> + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, >> +}; >> + >> +static int it6263_read_edid(void *data, u8 *buf, unsigned int block, >> +size_t len) { >> + struct it6263 *it = data; >> + struct regmap *regmap = it->hdmi_regmap; >> + unsigned int start = (block % 2) * EDID_LENGTH; >> + unsigned int segment = block >> 1; >> + unsigned int count, val; >> + int ret; >> + >> + regmap_write(regmap, HDMI_REG_DDC_MASTER_CTRL, MASTER_SEL_HOST); >> + regmap_write(regmap, HDMI_REG_DDC_HEADER, DDC_ADDR << 1); >> + regmap_write(regmap, HDMI_REG_DDC_EDIDSEG, segment); >> + >> + while (len) { >> + /* clear DDC FIFO */ >> + regmap_write(regmap, HDMI_REG_DDC_CMD, DDC_CMD_FIFO_CLR); >> + >> + ret = regmap_read_poll_timeout(regmap, HDMI_REG_DDC_STATUS, >> + val, val & DDC_DONE, >> + 2000, 10000); >> + if (ret) { >> + dev_err(it->dev, "failed to clear DDC FIFO:%d\n", ret); >> + return ret; >> + } >> + >> + count = len > HDMI_DDC_FIFO_BYTES ? HDMI_DDC_FIFO_BYTES : len; >> + >> + /* fire the read command */ >> + regmap_write(regmap, HDMI_REG_DDC_REQOFF, start); >> + regmap_write(regmap, HDMI_REG_DDC_REQCOUNT, count); >> + regmap_write(regmap, HDMI_REG_DDC_CMD, DDC_CMD_EDID_READ); >> + >> + start += count; >> + len -= count; >> + >> + ret = regmap_read_poll_timeout(regmap, HDMI_REG_DDC_STATUS, val, >> + val & (DDC_DONE | DDC_ERROR), >> + 20000, 250000); >> + if (ret && !(val & DDC_ERROR)) { >> + dev_err(it->dev, "failed to read EDID:%d\n", ret); >> + return ret; >> + } >> + >> + if (val & DDC_ERROR) { >> + dev_err(it->dev, "DDC error\n"); >> + return -EIO; >> + } >> + >> + /* cache to buffer */ >> + for (; count > 0; count--) { >> + regmap_read(regmap, HDMI_REG_DDC_READFIFO, &val); >> + *(buf++) = val; >> + } >> + } >> + >> + return 0; >> +} >> + >> +static int it6263_connector_get_modes(struct drm_connector *connector) >> +{ >> + struct it6263 *it = connector_to_it6263(connector); >> + const struct drm_edid *drm_edid; >> + int count; >> + >> + drm_edid = drm_edid_read_custom(connector, it6263_read_edid, it); >> + >> + drm_edid_connector_update(connector, drm_edid); >> + count = drm_edid_connector_add_modes(connector); >> + >> + drm_edid_free(drm_edid); >> + >> + return count; >> +} >> + >> +static const struct drm_connector_helper_funcs it6263_connector_helper_funcs = { >> + .get_modes = it6263_connector_get_modes, }; >> + >> +static int it6263_bridge_atomic_check(struct drm_bridge *bridge, >> + struct drm_bridge_state *bridge_state, >> + struct drm_crtc_state *crtc_state, >> + struct drm_connector_state *conn_state) { >> + struct drm_display_mode *mode = &crtc_state->adjusted_mode; >> + >> + return mode->clock > MAX_PIXEL_CLOCK_KHZ ? -EINVAL : 0; } >> + >> +static void >> +it6263_bridge_atomic_disable(struct drm_bridge *bridge, >> + struct drm_bridge_state *old_bridge_state) { >> + struct it6263 *it = bridge_to_it6263(bridge); >> + >> + regmap_write_bits(it->hdmi_regmap, HDMI_REG_GCP, AVMUTE, AVMUTE); >> + regmap_write(it->hdmi_regmap, HDMI_REG_PKT_GENERAL_CTRL, 0); >> + regmap_write(it->hdmi_regmap, HDMI_REG_AFE_DRV_CTRL, >> + AFE_DRV_RST | AFE_DRV_PWD); >> +} >> + >> +static void >> +it6263_bridge_atomic_enable(struct drm_bridge *bridge, >> + struct drm_bridge_state *old_bridge_state) { >> + struct drm_atomic_state *state = old_bridge_state->base.state; >> + struct it6263 *it = bridge_to_it6263(bridge); >> + const struct drm_crtc_state *crtc_state; >> + struct regmap *regmap = it->hdmi_regmap; >> + const struct drm_display_mode *mode; >> + struct drm_connector *connector; >> + bool is_stable = false; >> + struct drm_crtc *crtc; >> + unsigned int val; >> + bool pclk_high; >> + int i, ret; >> + >> + connector = drm_atomic_get_new_connector_for_encoder(state, >> + bridge->encoder); >> + crtc = drm_atomic_get_new_connector_state(state, connector)->crtc; >> + crtc_state = drm_atomic_get_new_crtc_state(state, crtc); >> + mode = &crtc_state->adjusted_mode; >> + >> + regmap_write(regmap, HDMI_REG_HDMI_MODE, TX_HDMI_MODE); >> + >> + /* HDMI AFE setup */ >> + pclk_high = mode->clock > HIGH_PIXEL_CLOCK_KHZ ? true : false; >> + regmap_write(regmap, HDMI_REG_AFE_DRV_CTRL, AFE_DRV_RST); >> + if (pclk_high) >> + regmap_write(regmap, HDMI_REG_AFE_XP_CTRL, >> + AFE_XP_GAINBIT | AFE_XP_RESETB); >> + else >> + regmap_write(regmap, HDMI_REG_AFE_XP_CTRL, >> + AFE_XP_ER0 | AFE_XP_RESETB); >> + regmap_write(regmap, HDMI_REG_AFE_ISW_CTRL, 0x10); >> + if (pclk_high) >> + regmap_write(regmap, HDMI_REG_AFE_IP_CTRL, >> + AFE_IP_GAINBIT | AFE_IP_RESETB); >> + else >> + regmap_write(regmap, HDMI_REG_AFE_IP_CTRL, >> + AFE_IP_ER0 | AFE_IP_RESETB); >> + >> + /* HDMI software video reset */ >> + regmap_write_bits(regmap, HDMI_REG_SW_RST, SOFTV_RST, SOFTV_RST); >> + fsleep(1000); >> + regmap_write_bits(regmap, HDMI_REG_SW_RST, SOFTV_RST, 0); >> + >> + /* reconfigure LVDS and retry several times in case video is instable */ >> + for (i = 0; i < 3; i++) { >> + ret = regmap_read_poll_timeout(regmap, HDMI_REG_SYS_STATUS, val, >> + val & TXVIDSTABLE, >> + 20000, 500000); >> + if (!ret) { >> + is_stable = true; >> + break; >> + } >> + >> + it6263_lvds_config(it); >> + } >> + >> + if (!is_stable) >> + dev_warn(it->dev, "failed to wait for video stable\n"); >> + >> + /* HDMI AFE reset release and power up */ >> + regmap_write(regmap, HDMI_REG_AFE_DRV_CTRL, 0); >> + >> + regmap_write_bits(regmap, HDMI_REG_GCP, AVMUTE, 0); >> + >> + regmap_write(regmap, HDMI_REG_PKT_GENERAL_CTRL, ENABLE_PKT | >> +REPEAT_PKT); } >> + >> +static enum drm_mode_status >> +it6263_bridge_mode_valid(struct drm_bridge *bridge, >> + const struct drm_display_info *info, >> + const struct drm_display_mode *mode) { >> + return mode->clock > MAX_PIXEL_CLOCK_KHZ ? MODE_CLOCK_HIGH : MODE_OK; >> +} >> + >> +static int it6263_bridge_attach(struct drm_bridge *bridge, >> + enum drm_bridge_attach_flags flags) { >> + struct it6263 *it = bridge_to_it6263(bridge); >> + int ret; >> + >> + ret = drm_bridge_attach(bridge->encoder, it->next_bridge, bridge, >> + flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR); >> + if (ret < 0) >> + return ret; >> + >> + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) >> + return 0; >> + >> + it->connector.polled = DRM_CONNECTOR_POLL_CONNECT | >> + DRM_CONNECTOR_POLL_DISCONNECT; >> + >> + ret = drm_connector_init(bridge->dev, &it->connector, >> + &it6263_connector_funcs, >> + DRM_MODE_CONNECTOR_HDMIA); >> + if (ret) >> + return ret; >> + >> + drm_connector_helper_add(&it->connector, >> + &it6263_connector_helper_funcs); >> + drm_connector_attach_encoder(&it->connector, bridge->encoder); >> + >> + return 0; >> +} >> + >> +static enum drm_connector_status it6263_bridge_detect(struct drm_bridge >> +*bridge) { >> + struct it6263 *it = bridge_to_it6263(bridge); >> + >> + return it6263_detect(it); >> +} >> + >> +static const struct drm_edid * >> +it6263_bridge_edid_read(struct drm_bridge *bridge, >> + struct drm_connector *connector) >> +{ >> + struct it6263 *it = bridge_to_it6263(bridge); >> + >> + return drm_edid_read_custom(connector, it6263_read_edid, it); } >> + >> +static u32 * >> +it6263_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, >> + struct drm_bridge_state *bridge_state, >> + struct drm_crtc_state *crtc_state, >> + struct drm_connector_state *conn_state, >> + u32 output_fmt, >> + unsigned int *num_input_fmts) >> +{ >> + u32 *input_fmts; >> + >> + input_fmts = kmalloc(sizeof(*input_fmts), GFP_KERNEL); >> + if (!input_fmts) { >> + *num_input_fmts = 0; >> + return NULL; >> + } >> + >> + input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA; > > Why is it hardcoded? What about supporting VESA?? > >> + *num_input_fmts = 1; >> + >> + return input_fmts; >> +} >> + >> +static const struct drm_bridge_funcs it6263_bridge_funcs = { >> + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, >> + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, >> + .atomic_reset = drm_atomic_helper_bridge_reset, >> + .attach = it6263_bridge_attach, >> + .mode_valid = it6263_bridge_mode_valid, >> + .atomic_disable = it6263_bridge_atomic_disable, >> + .atomic_enable = it6263_bridge_atomic_enable, >> + .atomic_check = it6263_bridge_atomic_check, >> + .detect = it6263_bridge_detect, >> + .edid_read = it6263_bridge_edid_read, >> + .atomic_get_input_bus_fmts = it6263_bridge_atomic_get_input_bus_fmts, >> +}; >> + >> +static int it6263_probe(struct i2c_client *client) { >> + struct device *dev = &client->dev; >> + struct it6263 *it; >> + int ret; >> + >> + it = devm_kzalloc(dev, sizeof(*it), GFP_KERNEL); >> + if (!it) >> + return -ENOMEM; >> + >> + it->dev = dev; >> + it->hdmi_i2c = client; >> + >> + it->hdmi_regmap = devm_regmap_init_i2c(client, >> + &it6263_hdmi_regmap_config); >> + if (IS_ERR(it->hdmi_regmap)) >> + return dev_err_probe(dev, PTR_ERR(it->hdmi_regmap), >> + "failed to init I2C regmap for HDMI\n"); >> + >> + it->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); >> + if (IS_ERR(it->reset_gpio)) >> + return dev_err_probe(dev, PTR_ERR(it->reset_gpio), >> + "failed to get reset gpio\n"); >> + >> + ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(it6263_supplies), >> + it6263_supplies); >> + if (ret) >> + return dev_err_probe(dev, ret, "failed to get power supplies\n"); >> + >> + ret = it6263_parse_dt(it); >> + if (ret) >> + return ret; >> + >> + it6263_reset(it); >> + >> + ret = it6263_lvds_set_i2c_addr(it); >> + if (ret) >> + return dev_err_probe(dev, ret, "failed to set I2C addr\n"); >> + >> + it->lvds_i2c = devm_i2c_new_dummy_device(dev, client->adapter, >> + LVDS_INPUT_CTRL_I2C_ADDR); >> + if (IS_ERR(it->lvds_i2c)) >> + dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c), >> + "failed to allocate I2C device for LVDS\n"); > > Maybe use action_or_reset and call i2c_unregister_device(); devm_i2c_new_dummy_device() is called here. It is a dev managed function call. Action devm_i2c_release_dummy() is added in it already. > >> + >> + it->lvds_regmap = devm_regmap_init_i2c(it->lvds_i2c, >> + &it6263_lvds_regmap_config); >> + if (IS_ERR(it->lvds_regmap)) >> + return dev_err_probe(dev, PTR_ERR(it->lvds_regmap), >> + "failed to init I2C regmap for LVDS\n"); > >> + >> + it6263_lvds_config(it); >> + it6263_hdmi_config(it); > >> + >> + i2c_set_clientdata(client, it); >> + >> + it->bridge.funcs = &it6263_bridge_funcs; >> + it->bridge.of_node = dev->of_node; >> + it->bridge.ops = DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT; > > it->bridge.type = DRM_MODE_CONNECTOR_HDMIA; ?? Will add this. Thanks. > >> + drm_bridge_add(&it->bridge); >> + >> + return 0; >> +} >> + >> +static void it6263_remove(struct i2c_client *client) { >> + struct it6263 *it = i2c_get_clientdata(client); >> + >> + drm_bridge_remove(&it->bridge); > >> +} >> + >> +static const struct of_device_id it6263_of_match[] = { >> + { .compatible = "ite,it6263", }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, it6263_of_match); >> + >> +static const struct i2c_device_id it6263_i2c_ids[] = { >> + { "it6263", 0 }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(i2c, it6263_i2c_ids); >> + >> +static struct i2c_driver it6263_driver = { >> + .probe = it6263_probe, >> + .remove = it6263_remove, >> + .driver = { >> + .name = "it6263", >> + .of_match_table = it6263_of_match, >> + }, >> + .id_table = it6263_i2c_ids, >> +}; >> +module_i2c_driver(it6263_driver); >> + >> +MODULE_DESCRIPTION("ITE Tech. Inc. IT6263 LVDS/HDMI bridge"); >> +MODULE_AUTHOR("Liu Ying "); MODULE_LICENSE("GPL"); >> -- >> 2.34.1 >> > -- Regards, Liu Ying