From: Ada Couprie Diaz <ada.coupriediaz@arm.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ian Rogers <irogers@google.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
Max Filippov <jcmvbkbc@gmail.com>,
WANG Xuerui <kernel@xen0n.name>, Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Waiman Long <longman@redhat.com>,
Clark Williams <clrkwllms@kernel.org>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
James Clark <james.clark@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
loongarch@lists.linux.dev, Namhyung Kim <namhyung@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-arm-kernel@lists.infradead.org,
Chris Zankel <chris@zankel.net>,
Linus Walleij <linusw@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH v3] ARM, ARM64, LONGARCH, XTENSA: Delay HW BP notification to task_work()
Date: Fri, 9 Oct 2026 14:21:18 +0100 [thread overview]
Message-ID: <5becc0b8-9b31-4539-b477-2d4af66c89a4@arm.com> (raw)
In-Reply-To: <20261008192117.ZIKKU3Yh@linutronix.de>
Hi Sebastian,
On 08/10/2026 20:21, Sebastian Andrzej Siewior wrote:
> On 2026-10-06 18:17:52 [+0100], Ada Couprie Diaz wrote:
>> Hi Sebastian,
> Hi Ada,
>
>> I find the function names a bit counter-intuitive, compared to the other
>> arch-specific perf functions.
>> Given the name `perf_arch_...`, I would have expected them to be defined
>> in arch code, rather than in the generic perf code.
>> From what I can see, usually perf functions calling an arch-specific
>> function lack the `_arch_` infix of their `arch_` counterpart.
>>
>> I do not know very well what we expect in perf, so I might be off-base,
>> but would calling them `perf_hwbp_send_sig()` and `perf_hwbp_notify()`
>> make sense ?
> Thanks for looking at this. I renamed them as:
> - perf_arch_hwbp_notify() -> perf_hwbp_notify() (generic)
> - arch_hwbp_send_sig() -> perf_arch_hwbp_send_sig() (arch specific)
> - perf_arch_hwbp_send_sig() -> perf_hwbp_send_sig() (generic)
>
> [...]
>
> Sebastian
That sounds good to me, thanks !
Kind regards
Ada
prev parent reply other threads:[~2026-10-09 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 14:35 [PATCH v3] ARM, ARM64, LONGARCH, XTENSA: Delay HW BP notification to task_work() Sebastian Andrzej Siewior
2026-10-06 17:17 ` Ada Couprie Diaz
2026-10-08 19:21 ` Sebastian Andrzej Siewior
2026-10-09 13:21 ` Ada Couprie Diaz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5becc0b8-9b31-4539-b477-2d4af66c89a4@arm.com \
--to=ada.coupriediaz@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=clrkwllms@kernel.org \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel@xen0n.name \
--cc=lgoncalv@redhat.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux@armlinux.org.uk \
--cc=longman@redhat.com \
--cc=loongarch@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox