public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: olivier.moysan@st.com (Olivier MOYSAN)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] ASoC: stm32: add bindings for SAI
Date: Tue, 2 May 2017 07:45:35 +0000	[thread overview]
Message-ID: <5bf88908-37ec-412f-9123-6f90938b5b66@st.com> (raw)
In-Reply-To: <20170428205358.fxjqaki44xqim4ta@rob-hp-laptop>

Hello Rob,

On 04/28/2017 10:53 PM, Rob Herring wrote:
> On Mon, Apr 10, 2017 at 05:19:55PM +0200, olivier moysan wrote:
>> This patch adds documentation of device tree bindings for the
>> STM32 SAI ASoC driver.
>>
>> Signed-off-by: olivier moysan <olivier.moysan@st.com>
>> ---
>>  .../devicetree/bindings/sound/st,stm32-sai.txt     | 89 ++++++++++++++++++++++
>>  1 file changed, 89 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-sai.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.txt b/Documentation/devicetree/bindings/sound/st,stm32-sai.txt
>> new file mode 100644
>> index 0000000..c59a3d7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.txt
>> @@ -0,0 +1,89 @@
>> +STMicroelectronics STM32 Serial Audio Interface (SAI).
>
> [...]
>
>> +	sai1b: audio-controller at 40015824 {
>> +		#sound-dai-cells = <0>;
>> +		compatible = "st,stm32-sai-sub-b";
>> +		reg = <0x40015824 0x1C>;
>> +		clocks = <&rcc 1 CLK_SAI2>;
>> +		clock-names = "sai_ck";
>> +		dmas = <&dma2 5 0 0x400 0x0>;
>> +		dma-names = "tx";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_sai1b>;
>> +
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			sai1b_port: port at 0 {
>> +				reg = <0>;
>> +				cpu_endpoint: endpoint {
>> +					remote-endpoint = <&codec_endpoint>;
>> +					audio-graph-card,format = "i2s";
>> +					audio-graph-card,bitclock-master = <&codec_endpoint>;
>> +					audio-graph-card,frame-master = <&codec_endpoint>;
>
> These property names are wrong.
>

I have taken into account this comment (and previous ones).
They will be included in next update of this patch set.

>> +				};
>> +			};
>> +		};
>> +	};
>> +};
>> +
>> +audio-codec {
>> +	codec_port: port {
>> +		codec_endpoint: endpoint {
>> +			remote-endpoint = <&cpu_endpoint>;
>> +		};
>> +	};
>> +};
>> --
>> 1.9.1
>>

Best regards
Olivier

  reply	other threads:[~2017-05-02  7:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 15:19 [PATCH v3 0/2] Add STM32 SAI support olivier moysan
2017-04-10 15:19 ` [PATCH v3 1/2] ASoC: stm32: add bindings for SAI olivier moysan
2017-04-26 15:50   ` Applied "ASoC: stm32: add bindings for SAI" to the asoc tree Mark Brown
2017-04-28 20:53   ` [PATCH v3 1/2] ASoC: stm32: add bindings for SAI Rob Herring
2017-05-02  7:45     ` Olivier MOYSAN [this message]
2017-04-10 15:19 ` [PATCH v3 2/2] ASoC: stm32: add SAI driver olivier moysan
2017-04-26 15:50   ` Applied "ASoC: stm32: add SAI driver" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bf88908-37ec-412f-9123-6f90938b5b66@st.com \
    --to=olivier.moysan@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox