linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	linux-aspeed@lists.ozlabs.org,  openbmc@lists.ozlabs.org,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: aspeed: Use block syntax for function and groups
Date: Mon, 17 Jun 2024 16:51:00 +0930	[thread overview]
Message-ID: <5bf8e1dddd2b958a102e7b1b9f9c080a34f9deff.camel@codeconstruct.com.au> (raw)
In-Reply-To: <0908995dfd2181e687181bd1b075c4cb27624e94.camel@codeconstruct.com.au>

Hi Linus,

On Wed, 2024-06-05 at 10:17 +0930, Andrew Jeffery wrote:
> On Tue, 2024-06-04 at 14:27 -0500, Rob Herring wrote:
> > On Fri, May 31, 2024 at 12:32:47PM +0930, Andrew Jeffery wrote:
> > > The expansion makes the documents a lot longer, but it's easier to
> > > review changes to functions and groups when we're not having to deal
> > > with line wrapping.
> > 
> > Do you really expect to be updating this frequently? I would leave it 
> > as-is, but whatever you decide.
> 
> I don't expect to be updating it frequently. However it's happened
> occasionally in the past and the diff chaos irks me. So I prefer we
> explode it.
> 
> > 
> > > Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> > > ---
> > 
> > Acked-by: Rob Herring (Arm) <robh@kernel.org>
> 
> Thanks.
> 

Are you okay to apply these (I see they're not yet in linux-pinctrl.git
for-next)? Turns out there's another concern lurking in the AST2600
RMII pin groups[1], and it would be nice if we could rework the patch
for that on top of this series.

[1]: https://lore.kernel.org/linux-gpio/20240613080725.2531580-1-potin.lai.pt@gmail.com/

Andrew


  reply	other threads:[~2024-06-17  7:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31  3:02 [PATCH 0/3] dt-bindings: pinctrl: aspeed: Define missing functions and groups Andrew Jeffery
2024-05-31  3:02 ` [PATCH 1/3] dt-bindings: pinctrl: aspeed: Use block syntax for function " Andrew Jeffery
2024-06-04 19:27   ` Rob Herring
2024-06-05  0:47     ` Andrew Jeffery
2024-06-17  7:21       ` Andrew Jeffery [this message]
2024-05-31  3:02 ` [PATCH 2/3] dt-bindings: pinctrl: aspeed,ast2500-pinctrl: Describe SGPM Andrew Jeffery
2024-06-04 19:28   ` Rob Herring (Arm)
2024-05-31  3:02 ` [PATCH 3/3] dt-bindings: pinctrl: aspeed,ast2600-pinctrl: Describe I3C, USB Andrew Jeffery
2024-06-04 19:28   ` Rob Herring (Arm)
2024-06-17  7:34 ` [PATCH 0/3] dt-bindings: pinctrl: aspeed: Define missing functions and groups Linus Walleij
2024-06-17  7:36   ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bf8e1dddd2b958a102e7b1b9f9c080a34f9deff.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).