From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2158C27C6E for ; Mon, 17 Jun 2024 07:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4O1Yg19zvG/1BCea2tUlqBSAUzPuV9/WXaIGbdGrvU4=; b=PZ/U5yXi4K5Z7DG7j6+ItjCYo1 ZAmAOi7G81NmOjv70gGiZK3pu5Uon7+Hphlf0q43EcSVoJkom1NplHMyURdzWEftSTDG4Yzi3rQ0D 917OFStuWz/gAHCRjAxjbhp+72QBv/6GBmCwU+b55X7aZdIk6mnq/k0jW/ksqS7W3+1Jt/oJevcxG 3Ibhhm9Tqsc+Zz2142ukWPYF0zAZYxjpuonG+Ay2LdUC/OXmrg5cTS/MetGe9upsPPUZ5ERREN0dJ +ykTyBzugGgxX2S49xiXS33DvTdV+ta+Zpb+GSoTO9TTksbU9j6JLHak37pjMQEOiEhN5G5EeU+is SGhhuEqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6g5-00000009cgT-36Ki; Mon, 17 Jun 2024 07:21:22 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6fz-00000009cdc-3sAX for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 07:21:19 +0000 Received: from [192.168.68.112] (ppp118-210-79-194.adl-adc-lon-bras32.tpg.internode.on.net [118.210.79.194]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 70DCB2014A; Mon, 17 Jun 2024 15:21:03 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1718608866; bh=4O1Yg19zvG/1BCea2tUlqBSAUzPuV9/WXaIGbdGrvU4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=TbMb/VLBPIZdVWKQv6Pq9BqQTf63/B5/EwG7UiyQeT6z/FyqQMMCXEuD6jHztfmnI hRM+73HNO1WNHiqbdoqNEQs7f4IRbdIG85AVhD2gwl1YFcMixfCAvZeRTT3DeFZulV 8JWH+T80+ubT0cmjz6FGC6QhdVYi27VhGNjICtzcp/R2kTY/Rgwm6Ox0qEiHejcpT7 ebC52k8USG+7lwkrqjB9zoSpyL9nIitIcPRaB4ZbfEQmBCqhsikgkQhAGtxsvSe/Eh tE0u7IfUr34rKVJ9CehcdC0bP/M4Wg7euA2bQVZe8hjRD2V2jXbN7abOkzU31PeYDK YUC3YIpy0DMBw== Message-ID: <5bf8e1dddd2b958a102e7b1b9f9c080a34f9deff.camel@codeconstruct.com.au> Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: aspeed: Use block syntax for function and groups From: Andrew Jeffery To: Linus Walleij Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 17 Jun 2024 16:51:00 +0930 In-Reply-To: <0908995dfd2181e687181bd1b075c4cb27624e94.camel@codeconstruct.com.au> References: <20240531-dt-warnings-gpio-ast2600-pinctrl-funcs-groups-v1-0-a6fe2281a1b8@codeconstruct.com.au> <20240531-dt-warnings-gpio-ast2600-pinctrl-funcs-groups-v1-1-a6fe2281a1b8@codeconstruct.com.au> <20240604192755.GA1065421-robh@kernel.org> <0908995dfd2181e687181bd1b075c4cb27624e94.camel@codeconstruct.com.au> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_002116_352018_06F3C388 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, On Wed, 2024-06-05 at 10:17 +0930, Andrew Jeffery wrote: > On Tue, 2024-06-04 at 14:27 -0500, Rob Herring wrote: > > On Fri, May 31, 2024 at 12:32:47PM +0930, Andrew Jeffery wrote: > > > The expansion makes the documents a lot longer, but it's easier to > > > review changes to functions and groups when we're not having to deal > > > with line wrapping. > >=20 > > Do you really expect to be updating this frequently? I would leave it= =20 > > as-is, but whatever you decide. >=20 > I don't expect to be updating it frequently. However it's happened > occasionally in the past and the diff chaos irks me. So I prefer we > explode it. >=20 > >=20 > > > Signed-off-by: Andrew Jeffery > > > --- > >=20 > > Acked-by: Rob Herring (Arm) >=20 > Thanks. >=20 Are you okay to apply these (I see they're not yet in linux-pinctrl.git for-next)? Turns out there's another concern lurking in the AST2600 RMII pin groups[1], and it would be nice if we could rework the patch for that on top of this series. [1]: https://lore.kernel.org/linux-gpio/20240613080725.2531580-1-potin.lai.= pt@gmail.com/ Andrew