From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00F33C4332F for ; Fri, 25 Nov 2022 01:22:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QbGoqzUywGtbWl6TpEu/QSMYHEQsvc6zKe53Wk129Y8=; b=pd+m0lVO8YARiujubOhgnDTx6g yAXhSDI++vtVPt1mkT4euX6C69c07rLZ0LoINlEpdfVoLuhCltZd2ZA4PO9bvR0eSpXOXMI1VzfhJ MQG//dtXKy9p2TEdalbCP4gl+++CfWZoJG17p//YuntZNKWqseC0xL1ZOpNAua+cSzb2dIYHymRKq MSIDU4YwdDAme3CCgVFWMuy/osGYDhYhedSfQUdtlAakGWoYT8gNoCL6pxipuX8kMzO7HJGgozHvH vAilxsd1O2zps+mg7Ytudfmqq2u6AP+11SALCwte3OPrI83r8vU3mzJlvQZ+BJTiXbyzTd2D6/zdc n+KezebA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyNOn-00C3pZ-3m; Fri, 25 Nov 2022 01:21:01 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyNOj-00C3gl-SK for linux-arm-kernel@lists.infradead.org; Fri, 25 Nov 2022 01:20:59 +0000 Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NJH8q5gLzzmW9b; Fri, 25 Nov 2022 09:19:55 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 25 Nov 2022 09:20:29 +0800 Received: from [10.174.178.247] (10.174.178.247) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 25 Nov 2022 09:20:28 +0800 Subject: Re: [PATCH 3/3] arm_scpi: modify to support acpi To: Sudeep Holla , Wang Honghui CC: Cristian Maruss , Jassi Brar , , References: <20221124111015.vrfuroty4fbemqv7@bogus> From: Hanjun Guo Message-ID: <5c005ae4-bdf2-8d4a-ef3a-c2964c9df5d8@huawei.com> Date: Fri, 25 Nov 2022 09:20:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20221124111015.vrfuroty4fbemqv7@bogus> Content-Language: en-GB X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221124_172058_133798_87018BF2 X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022/11/24 19:10, Sudeep Holla wrote: > Hi Wang, > > On Thu, Nov 24, 2022 at 03:09:31PM +0800, Wang Honghui wrote: >> arm_scpi: modify to support acpi >> > > 1. The commit message is pretty useless. I don't get the complete picture > of why you need this change or what you are trying to do in this change. > > 2. I am unable to see the series as a whole, just have 2 versions of 3/3 > in my inbox. > > 3. This is not the correct way to use SCPI or mailbox in ACPI. You need > to use PCC and PCC OpRegion to achieve what you want. The whole SCPI > protocol details gets abstracted in the firmware(ACPI ASL) Agreed, using PCC for ARM SCPI support, not some self-defined bindings. If you have any issue to support SCPI in your platform, we can add the support in the ACPI spec first, but from what I read from the ACPI spec, the PCC or PCC OpRegion can support SPCI well, let me know if any issues. Thanks Hanjun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel