From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B722CED275 for ; Tue, 8 Oct 2024 07:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fy2shiK3fmb6j9W5GjzkVqsj9Kn/pQMnvw0hDyVzAGg=; b=UedH/EZCwrf9oKmqNU6eBUwzc8 qRnKqyZYqtvfL8uylitL/G2I1B50Niu4Xrh67zFj7oXy50MnL1m3kMb1bg3DqFRTmpp1+l5r393hl dwVF/xZgS/YmAqCz6Ii1PnIHAKKMZoAaSow0g1CMMFRrIsyKsNc3ncd2Rn5VuTWuem3yHUQuzT/w7 MKcMvYI+lpwZOX2jG8uGrfZ46HgdIutNF5XR110h7mcSkdCmH4YN4cyH/RS6WtXan+23Ap5IRprnb pLu8vtZjO14Q2M5GjVONfdXTHKYTC7E0ukVCQGaGtUldhKpBAT/HOm7EZtZn40X3PsF70fXIx19Iu 0gZ65Tfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy4k2-00000004oI0-3Fcq; Tue, 08 Oct 2024 07:34:46 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy4ga-00000004nPv-3fH1 for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 07:31:14 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-37cc84c12c2so2807296f8f.3 for ; Tue, 08 Oct 2024 00:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728372671; x=1728977471; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=fy2shiK3fmb6j9W5GjzkVqsj9Kn/pQMnvw0hDyVzAGg=; b=WzoReafHcyHykCjPr/59IXd9kQmkBueL0v+Q84+v09J4eaH8yY2vVR2/T7oSZ+41mZ +bAZeGC7xAPeB9ZPP1pJ+bdamrhHNoyNiIsdL9oE6eGd21xDO7Xb0ctefm4tmEGr92oV 3VBe3mvvt0OwQ6CgJgf2pztmfgqxllyb7arpZ2Lmv8OPEhBjblkU3rea4bCr722+pD7c vV7nSpjqgWqr6+RWxCa35+2bkmL/5rCy9EJayvbFjBg8Bhe1lAG9FHIjYLChaLFknK+D pvviVAibD550JjGu+DhIo50IeZqO6Y3qV1FMZq/uJWnLv7W5Bbm/luSEWMNAs2LKMK3W tBIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728372671; x=1728977471; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fy2shiK3fmb6j9W5GjzkVqsj9Kn/pQMnvw0hDyVzAGg=; b=sTxZ+PT43YYwK8/KYJLfrLdtfQYTYcsgI2EiCwVYwY8HWWXRQPtQem71wve7OF0ooo VT38UnuH5a9bb//nTgD74SPp6k2OfXvR0qxH1AAmCKbLOL11yL1B5ayXHBhXJ8U1fppM fdFUuu31svEaPHBSPiOOxOIXfTHfbpwzH+3xGudJrgLPbS3TkE6hh/SZeL2ffMRHw1J2 6uC4OIUbpQhkCVaIIGVklLTXvJe3DGjkgva9/Fgz63s3fXBD0RE8AXnpb2vM1gBxp80l 1vEwpex1DKIAdt9qHkUm+OwdLHTijPRGdw+kVyWw0c5eJZdIF6GVMUCQhTtbIaVtd5QG YUNA== X-Forwarded-Encrypted: i=1; AJvYcCXp7S5pHMnq+192AnNTL5zxOXqpZeg4ZG6+QRcqU22fOsuAaMQ9/eZ/ECEDh3GveLOHFrXwtXe7g0yxzgrZ/qd+@lists.infradead.org X-Gm-Message-State: AOJu0YwM2E/3BFJ+BBp/kwL6BhcZrCwf9fUx2WeUig/OTYArF1PQl/fu 8lGS1j8NtxzjIpjzGKzldz1zp032mk2eN4YdmNjs4XJsNftH0hvWKROmssnjjsg= X-Google-Smtp-Source: AGHT+IHIPRLHczs/vsnv1oAAp5+Q/um5G5Z/VdRLJkNxGk807Uk3XMrbK8IQ+3b5doUrR7C6rxdWqQ== X-Received: by 2002:a05:6000:1b8b:b0:37c:ce45:96f2 with SMTP id ffacd0b85a97d-37d0e8f7390mr7513067f8f.50.1728372671045; Tue, 08 Oct 2024 00:31:11 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:4595:23ef:4ba2:2d19? ([2a01:e0a:982:cbb0:4595:23ef:4ba2:2d19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86a20393sm116449555e9.12.2024.10.08.00.31.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 00:31:09 -0700 (PDT) Message-ID: <5c3a6fdb-e4f0-4a22-9a8d-84baee12769c@linaro.org> Date: Tue, 8 Oct 2024 09:31:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Subject: Re: [PATCH 3/3] pwm: meson: Enable constant and polarity features for g12, axg, s4 To: George Stark , u.kleine-koenig@pengutronix.de, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com Cc: linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@salutedevices.com References: <20241007193203.1753326-1-gnstark@salutedevices.com> <20241007193203.1753326-4-gnstark@salutedevices.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241007193203.1753326-4-gnstark@salutedevices.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_003112_956746_8DBEB69F X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/10/2024 21:32, George Stark wrote: > g12, axg and s4 SoC families support constant and polarity bits so enable > those features in corresponding chip data structs. > > Signed-off-by: George Stark > --- > drivers/pwm/pwm-meson.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c > index 6701738c55e3..c6f032bdfe78 100644 > --- a/drivers/pwm/pwm-meson.c > +++ b/drivers/pwm/pwm-meson.c > @@ -571,26 +571,36 @@ static const struct meson_pwm_data pwm_gxbb_ao_data = { > static const struct meson_pwm_data pwm_axg_ee_data = { > .parent_names = { "xtal", "fclk_div5", "fclk_div4", "fclk_div3" }, > .channels_init = meson_pwm_init_channels_meson8b_legacy, > + .has_constant = true, > + .has_polarity = true, > }; > > static const struct meson_pwm_data pwm_axg_ao_data = { > .parent_names = { "xtal", "axg_ao_clk81", "fclk_div4", "fclk_div5" }, > .channels_init = meson_pwm_init_channels_meson8b_legacy, > + .has_constant = true, > + .has_polarity = true, > }; > > static const struct meson_pwm_data pwm_g12a_ee_data = { > .parent_names = { "xtal", NULL, "fclk_div4", "fclk_div3" }, > .channels_init = meson_pwm_init_channels_meson8b_legacy, > + .has_constant = true, > + .has_polarity = true, > }; > > static const struct meson_pwm_data pwm_g12a_ao_ab_data = { > .parent_names = { "xtal", "g12a_ao_clk81", "fclk_div4", "fclk_div5" }, > .channels_init = meson_pwm_init_channels_meson8b_legacy, > + .has_constant = true, > + .has_polarity = true, > }; > > static const struct meson_pwm_data pwm_g12a_ao_cd_data = { > .parent_names = { "xtal", "g12a_ao_clk81", NULL, NULL }, > .channels_init = meson_pwm_init_channels_meson8b_legacy, > + .has_constant = true, > + .has_polarity = true, > }; > > static const struct meson_pwm_data pwm_meson8_v2_data = { > @@ -599,6 +609,8 @@ static const struct meson_pwm_data pwm_meson8_v2_data = { > > static const struct meson_pwm_data pwm_s4_data = { > .channels_init = meson_pwm_init_channels_s4, > + .has_constant = true, > + .has_polarity = true, > }; > > static const struct of_device_id meson_pwm_matches[] = { Reviewed-by: Neil Armstrong