From: dinguyen@kernel.org (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] socfpga_a10: reset CPU1 in socfpga_cpu_kill()
Date: Fri, 12 May 2017 09:25:32 -0500 [thread overview]
Message-ID: <5c3ad20d-5d22-3164-e678-5122efed4d74@kernel.org> (raw)
In-Reply-To: <20170510051304.131042-2-yanjiang.jin@windriver.com>
On 05/10/2017 12:13 AM, yanjiang.jin at windriver.com wrote:
> From: Yanjiang Jin <yanjiang.jin@windriver.com>
>
> Kexec's second kernel would hang if CPU1 isn't reset.
>
Can you please be a bit more descriptive on the commit log? Is it
because when kexec starts, the SMP on the kexec's kernel try to run on CPU1?
> Signed-off-by: Yanjiang Jin <yanjiang.jin@windriver.com>
> ---
> arch/arm/mach-socfpga/platsmp.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c
> index 0ee7677..db3940e 100644
> --- a/arch/arm/mach-socfpga/platsmp.c
> +++ b/arch/arm/mach-socfpga/platsmp.c
> @@ -117,6 +117,16 @@ static int socfpga_cpu_kill(unsigned int cpu)
> {
> return 1;
> }
> +
> +static int socfpga_a10_cpu_kill(unsigned int cpu)
> +{
> + /* This will put CPU #1 into reset. */
> + if (socfpga_cpu1start_addr)
Do you need to check for socfpga_cpu1start_addr?
Dinh
next prev parent reply other threads:[~2017-05-12 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 5:13 [PATCH] socfpga_a10: fix a kexec boot issue yanjiang.jin at windriver.com
2017-05-10 5:13 ` [PATCH] socfpga_a10: reset CPU1 in socfpga_cpu_kill() yanjiang.jin at windriver.com
2017-05-12 14:25 ` Dinh Nguyen [this message]
2017-05-12 14:36 ` Mark Rutland
2017-05-15 9:05 ` yjin
2017-05-15 10:00 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2017-05-15 9:13 [V2 PATCH] socfpga_a10: fix a kexec boot issue yanjiang.jin at windriver.com
2017-05-15 9:13 ` [PATCH] socfpga_a10: reset CPU1 in socfpga_cpu_kill() yanjiang.jin at windriver.com
2017-05-15 9:55 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c3ad20d-5d22-3164-e678-5122efed4d74@kernel.org \
--to=dinguyen@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).