From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F6AC433ED for ; Wed, 28 Apr 2021 15:28:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BA6E610A5 for ; Wed, 28 Apr 2021 15:28:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BA6E610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cALgIwlyDrt0iYMSsmDwNWd7aIAoOFkasNjS6gu0v3M=; b=N77Dj0X4eHQIt98gvuGBFch+J 48aHQMWn067ZDar8sYdTQZgQ9b2E/vmD/SQrwKodVVavsD+RhH5fFvPg4OrXdG/8yn/lBMovj/hnV YhTAZTfpkUoQPYyJFzGjvUz5vHguNhovVLqMT2+497NAXokck2IdeZKuMMtDM9nD2sZEd47SUbSGd K2V69sh0vT6nw5jsksCd5W36HhxTiQp9isR20uWf2FVifB4z/NV+JtQnYiF0ZyfNUy9QoZZBYKkuH s8Z55G0MdKkZ3pcNZcjoUO5KGrLtzMUwF4MIq35V01Jpx16Vd/CNsdYU0z0JIt07IvH4sNRs+s5m/ p0nWNb85g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbm5M-003kTj-BH; Wed, 28 Apr 2021 15:26:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbm5J-003kTT-Gw for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 15:26:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=N9sLSkMd2PrkFOc/KnB2Eh0J9f5STmd+QbevjYr4WCA=; b=4AoCy8/a9Qk2lM5O31MdFncnwp RwAoqjIc0HY3A8Qh4dv8zu+tvsyVdtV+TYoCKBw7WaZ3FTyzyADNAc5hawpUqJCSFL+HlOQ/0iSiw FlRlQVlwiEiWrdz9UosI7jIBm4gnNzZEf3msNzBeRgRBNnAaGP29QTsGeYuAhJJ/robDf4ElaYK7T Qr2SAHmUol2pb5yMWoCj/ZWy3SMm7ovKnHtOWecA5RYfh6cDWwYw6dgW9YiDppkWkUSWorF7FqGi9 wcXGSGy7TnvN8dQwPeBPrXiXN843xOmBITU+KPSE/PaqRpcUN+GQxLngpd8atLtLJaaRxsAKBCAH+ teXfuNJQ==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbm5H-00HYJF-2W for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 15:26:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619623594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N9sLSkMd2PrkFOc/KnB2Eh0J9f5STmd+QbevjYr4WCA=; b=TmEskfnxABWtCB0LRmx6vA+Yj6MDtd4KGnKUL1KA3J1xFuU0Sc7xQD1z3nwad44NOb+6gT gsAoZXjVKNUbZpSzW3GbOwFaeTvYdkXlCeJCwDBIIQYICDfAI+2m8T1edzweM19KltIE33 LHZlkpG7epTUZRCYXdmit2HS2SngqNM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-3DP7XKC2MKKxA7cDD_b_jQ-1; Wed, 28 Apr 2021 11:26:32 -0400 X-MC-Unique: 3DP7XKC2MKKxA7cDD_b_jQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD33880ED8D; Wed, 28 Apr 2021 15:26:30 +0000 (UTC) Received: from [10.36.113.191] (ovpn-113-191.ams2.redhat.com [10.36.113.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC4E91007610; Wed, 28 Apr 2021 15:26:28 +0000 (UTC) Subject: Re: [kvm-unit-tests PATCH v1 1/4] arm64: split its-trigger test into KVM and TCG variants To: Marc Zyngier , Alexandru Elisei Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , kvm@vger.kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com References: <20210428101844.22656-1-alex.bennee@linaro.org> <20210428101844.22656-2-alex.bennee@linaro.org> <87fszasjdg.fsf@linaro.org> <996210ae-9c63-54ff-1a65-6dbd63da74d2@arm.com> <87k0omo4rr.wl-maz@kernel.org> From: Auger Eric Message-ID: <5c446e6e-fb21-3a47-587b-6ad5e6baf096@redhat.com> Date: Wed, 28 Apr 2021 17:26:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <87k0omo4rr.wl-maz@kernel.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_082639_224832_4D7FB028 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 4/28/21 4:36 PM, Marc Zyngier wrote: > On Wed, 28 Apr 2021 15:00:15 +0100, > Alexandru Elisei wrote: >> >> I interpret that as that an INVALL guarantees that a change is >> visible, but it the change can become visible even without the >> INVALL. > > Yes. Expecting the LPI to be delivered or not in the absence of an > invalidate when its configuration has been altered is wrong. The > architecture doesn't guarantee anything of the sort. > >> The test relies on the fact that changes to the LPI tables are not >> visible *under KVM* until the INVALL command, but that's not >> necessarily the case on real hardware. To match the spec, I think >> the test "dev2/eventid=20 still does not trigger any LPI" should be >> removed and the stats reset should take place before the >> configuration for LPI 8195 is set to the default. Yes I do agree with Alexandru and Marc after another reading of the spec. I initially thought the INVALL was the gate keeper for the new config but that sounds wrong. This test shall be removed then. Eric > > If that's what the test expects (I haven't tried to investigate), it > should be dropped completely, rather than trying to sidestep it for > TCG. > > Thanks, > > M. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel