From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8D85C43334 for ; Fri, 15 Jul 2022 02:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ex0VP5LJ2mZ4AZg0nsA1T6s9VJVacTikihjJF4qf6AM=; b=F9zX4Ubs/VpXF1 imiaL3VHyX2O9mKPxTSXTODI97GAVq/uUwYVhrIxTLEFMD2tCjaJC2jE/G5Ze0gTE2pk+UAVoe9kQ 0kj9caEHqB4jAF7ZIyBE808fYc2q2HqlKkeBsgSe2EurqL0aYrPThllDibKRoFxakkVjvN/S4HROx K27O2XQwm1Zfv4WDw5C/cCR4jAPpB+Nt+GzMHMdYjjaKVbipKe+BEGcs1cZhLCtjirxdvYvtThp4n OkhmLUVgSGXhFAHCeu6df+iviDGrLKH9gW9THxNOp8fwFpKU+1Nl2GQkwo/6lp6QWiHbk4a2ThnDk ZKsrFpkYosaaa4RC2zLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCBGR-003b10-LI; Fri, 15 Jul 2022 02:41:11 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCBGK-003ayI-VU; Fri, 15 Jul 2022 02:41:09 +0000 Received: by mail-pf1-x42a.google.com with SMTP id 70so3521406pfx.1; Thu, 14 Jul 2022 19:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=j0LkY7V697d3ZVo5WxziZUxKlyEGG8e7be+I9q1UHZc=; b=HfNLipGrzytDB935p8bmqPON5CCDTAZMyAiAxewGU+bb/fGa4ILTdeVF+rsA4E81LY EA6isllOd40wVpZ6xg1LL2AajDouAQ33p+qW7Q/SvFeC4F1lghs54MRqNaZJCUEXCBYq UxtT/gqB7umL6Xt45HXp9mgQVZ1RnwCbB6mgmRnncSJAnapzo5xyLzkVCAXjbZkq8eJh LgkuOBU2P0vbzdH66t0uxhDFM2YbmWZjOl/mtrkcJp4QH7Y7xs2klWo16ZL2TiS5SS4T ymjvoAo0UjNRMW+A4929mxUHchP/jUvtFFPq1Xh3iH3mtcF5wHmMIehpW7SSxNWC02jg LsFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=j0LkY7V697d3ZVo5WxziZUxKlyEGG8e7be+I9q1UHZc=; b=nYkEHq1TQx5FLpDUlScb/s7rTHqAfuq1xbBtwSMluQfPXPvDA87ceattsh+FIHVDvP O/D7XZAL7L+XcvO/LREX9MJS/YmiN7AmcpKZ2UxOKrBSqjAxlrM+MGIaQdbqPkuxaLwc Q16C1c0pgMKEg4Ec45n53cULM4Eqc3ex/qnQP6VQcSNS/kE3ZFZIOWRnm6OYQ30xw61y l0pgyWBqn4LbK7Xa1Ca8HijD//Xu7H9MYzazm++vhx8LYWNikPahd2Bmv1E9Mov9ZP8l uCBdQM9nxfkChAsr8lzAuseuHRXzyRHA1++PYrsUGgEJObiiRixviDKd8fT/M8ZpY7JX TR5A== X-Gm-Message-State: AJIora/0f55j0ukGCQsuSCrJACRqakxUWpgFCJUtgzNSu/NTW6LaBVv7 tVzV6U+JgLmiYUUdct0c5CFGS5ioa9Q= X-Google-Smtp-Source: AGRyM1tO2r9TY0BZlwAeQKSbwkOO9lVL+SsDXgiA7s/1gDBB1Hm5KsYfHtWLb0kGfqWH37Va1WZoBg== X-Received: by 2002:aa7:94b3:0:b0:52a:198a:e3cb with SMTP id a19-20020aa794b3000000b0052a198ae3cbmr11363086pfl.60.1657852864219; Thu, 14 Jul 2022 19:41:04 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id v188-20020a622fc5000000b0052ab0a73752sm2409633pfv.198.2022.07.14.19.41.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 19:41:03 -0700 (PDT) Message-ID: <5c4ddf6d-3f6c-b64e-5503-0f8cad4a9364@gmail.com> Date: Thu, 14 Jul 2022 19:41:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH -next v3] serial: 8250_bcm2835aux: Add missing clk_disable_unprepare() Content-Language: en-US To: Guo Mengqi , gregkh@linuxfoundation.org Cc: jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, athierry@redhat.com, linux-serial@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xuqiang36@huawei.com References: <7c4eaa8e-2812-b805-c81b-9964a5cb6b52@huawei.com> <20220715023312.37808-1-guomengqi3@huawei.com> From: Florian Fainelli In-Reply-To: <20220715023312.37808-1-guomengqi3@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_194105_066883_585CE5A5 X-CRM114-Status: UNSURE ( 8.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/14/2022 7:33 PM, Guo Mengqi wrote: > The error path when get clock frequency fails in bcm2835aux_serial > driver does not correctly disable the clock. > > This flaw was found using a static analysis tool "Hulk Robot", which > reported the following warning when analyzing linux-next/master: > > drivers/tty/serial/8250/8250_bcm2835aux.c: > warning: clk_disable_unprepare_missing.cocci > > The cocci script checks for the existence of clk_disable_unprepare() > paired with clk_prepare_enable(). > > Add the missing clk_disable_unprepare() to the error path. > > Fixes: fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support") > Reported-by: Hulk Robot > Signed-off-by: Guo Mengqi Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel